From patchwork Fri Nov 22 14:57:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Jensen X-Patchwork-Id: 3222751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A0E3D9F3A0 for ; Fri, 22 Nov 2013 15:00:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 52EE2205BB for ; Fri, 22 Nov 2013 15:00:12 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 203452054A for ; Fri, 22 Nov 2013 15:00:11 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsBz-0001Y4-Hg; Fri, 22 Nov 2013 14:58:49 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsBj-0000MF-3w; Fri, 22 Nov 2013 14:58:31 +0000 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsBK-0000Hi-7j for linux-arm-kernel@lists.infradead.org; Fri, 22 Nov 2013 14:58:07 +0000 Received: by mail-la0-f52.google.com with SMTP id ev20so1033364lab.11 for ; Fri, 22 Nov 2013 06:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7fZE2rC82Mjn1ZvbP6xbhSnfRgibQOa8L7RCRyol6NQ=; b=d36Hu2B07oK0WNqnxX2bw0jEq90jwBxDjDIzZIHsG3hBV6oejBWsqebsCddFkd7bfb xV81r8k9l+YgC1XLGISURCLprrYUnMM2LE3ZTP+JSSlqOBoexdUg+Ay3CgPELwokWU0o 7DvKT9U+/MSXTPo695xHL31wJWdtz4iDEDnuVx1xSbtkLU/Hs1qEFQ5PjnOi9V56fbyT 6kqQmfKXH7rKZigyxcGQ4FAS9nWeOR7Ra7BhbPAi1OfHVPaPVI5pBijs3w8lTs9YNqdH +EFq5wczTw0LKHC4qOXVemG9uIig6iDZ2Neeps7Edi6w+Xk4rpemaSIDKlLlUbGU6ZOB 69uQ== X-Received: by 10.152.8.199 with SMTP id t7mr7846496laa.21.1385132264080; Fri, 22 Nov 2013 06:57:44 -0800 (PST) Received: from Ildjarn.ath.cx (static-213-115-41-10.sme.bredbandsbolaget.se. [213.115.41.10]) by mx.google.com with ESMTPSA id e10sm38129328laa.6.2013.11.22.06.57.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 Nov 2013 06:57:43 -0800 (PST) From: Jonas Jensen To: netdev@vger.kernel.org Subject: [PATCH 4/5] net: MOXA ART: generate random address Date: Fri, 22 Nov 2013 15:57:21 +0100 Message-Id: <1385132242-3204-4-git-send-email-jonas.jensen@gmail.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1385132242-3204-1-git-send-email-jonas.jensen@gmail.com> References: <1385132242-3204-1-git-send-email-jonas.jensen@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131122_095806_475317_9AD757E4 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) Cc: Jonas Jensen , davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The address register is zero:ed on boot, fill it with a randomly generated address on probe. Signed-off-by: Jonas Jensen --- Notes: Applies to next-20131122 drivers/net/ethernet/moxa/moxart_ether.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index 08c3905..c02075a 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -700,6 +700,12 @@ static int moxart_mac_probe(struct platform_device *pdev) goto init_fail; } + if (!is_valid_ether_addr(ndev->dev_addr)) { + eth_hw_addr_random(ndev); + netdev_info(ndev, "generated random MAC address %pM\n", + ndev->dev_addr); + } + netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n", __func__, ndev->irq, ndev->dev_addr);