From patchwork Fri Nov 22 14:57:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Jensen X-Patchwork-Id: 3222761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 26CFFC045B for ; Fri, 22 Nov 2013 15:00:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 848B0205BB for ; Fri, 22 Nov 2013 15:00:41 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1F232054A for ; Fri, 22 Nov 2013 15:00:36 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsCE-0001eW-SJ; Fri, 22 Nov 2013 14:59:03 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsBr-0000My-KG; Fri, 22 Nov 2013 14:58:39 +0000 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjsBM-0000Hm-R7 for linux-arm-kernel@lists.infradead.org; Fri, 22 Nov 2013 14:58:09 +0000 Received: by mail-lb0-f176.google.com with SMTP id x18so1017728lbi.7 for ; Fri, 22 Nov 2013 06:57:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SFG+bkUFSeKwINM/bKJoj+DPegXGcR+JXMcuEAwU4Mo=; b=KRlJ+SQZ9zVFfrsjg/GmZLF61o/14zEaFlEYDrki0IUKIebqc4QssAEuEYWF+7leLi Ew6hEPiHBTZvpy+mwpQm+4FK3TOIxUe/IOTJGjWTWAT41tNZvDXgdElVnihnLnBIuORh 0KaLKwnMn1ouPLV3JPnfa6BXgnLfqnUw28o5rwuPrNYGYo+7F8Pk46uIzqU6/t037ERw FAaQ8N/EOIdJA91/ntgc/mii4JUHAnwT9pGlBwlgXMFBcDnTHZqZBVELIt/dIwTC3aFh CAt9gYSqZ3WklTd4pNxeTcJOroZMo8lILcH69CAR996kGJYL67nmZvFHzTuShi6hQ7NK KhHA== X-Received: by 10.152.170.199 with SMTP id ao7mr1524184lac.40.1385132266587; Fri, 22 Nov 2013 06:57:46 -0800 (PST) Received: from Ildjarn.ath.cx (static-213-115-41-10.sme.bredbandsbolaget.se. [213.115.41.10]) by mx.google.com with ESMTPSA id e10sm38129328laa.6.2013.11.22.06.57.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 Nov 2013 06:57:45 -0800 (PST) From: Jonas Jensen To: netdev@vger.kernel.org Subject: [PATCH 5/5] net: MOXA ART: use eth_mac_addr() Date: Fri, 22 Nov 2013 15:57:22 +0100 Message-Id: <1385132242-3204-5-git-send-email-jonas.jensen@gmail.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1385132242-3204-1-git-send-email-jonas.jensen@gmail.com> References: <1385132242-3204-1-git-send-email-jonas.jensen@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131122_095809_075227_7CF37935 X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) Cc: Jonas Jensen , davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace boilerplate in moxart_set_mac_address() with eth_mac_addr(). Signed-off-by: Jonas Jensen --- Notes: Applies to next-20131122 drivers/net/ethernet/moxa/moxart_ether.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index c02075a..9a11d34 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -56,12 +56,7 @@ static void moxart_update_mac_address(struct net_device *ndev) static int moxart_set_mac_address(struct net_device *ndev, void *addr) { - struct sockaddr *address = addr; - - if (!is_valid_ether_addr(address->sa_data)) - return -EADDRNOTAVAIL; - - memcpy(ndev->dev_addr, address->sa_data, ndev->addr_len); + eth_mac_addr(ndev, addr); moxart_update_mac_address(ndev); return 0;