From patchwork Fri Nov 22 23:57:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 3224591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3ED6EC045B for ; Fri, 22 Nov 2013 23:57:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7561C205E4 for ; Fri, 22 Nov 2013 23:57:21 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E8EB204D1 for ; Fri, 22 Nov 2013 23:57:20 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vk0ae-000276-FE; Fri, 22 Nov 2013 23:56:48 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vk0aU-0007mo-6k; Fri, 22 Nov 2013 23:56:38 +0000 Received: from mail-pb0-f51.google.com ([209.85.160.51]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vk0aH-0007l1-5i for linux-arm-kernel@lists.infradead.org; Fri, 22 Nov 2013 23:56:26 +0000 Received: by mail-pb0-f51.google.com with SMTP id up15so1966907pbc.24 for ; Fri, 22 Nov 2013 15:56:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wHjNNC7YbOrDLbbULUzn/Lko5G4GhY9C2oUWOlbIqCA=; b=h3SUf5bszNvkhwtLaMGB9O85gyjeucg2WbrLdDkG3xii5IivRP9edi0uAVOJrQN2I6 O3IYnFCG4uDmahmZYLIN3/fPb0stD7brFYJ1a4ZDKZ52L9NP05ptNw1/Pojqr6uWNI5J ouiCNmnQdb67QM00JKk6eiud22djx+mCdn4zc4LGOeIXRksluPXK8WY13VUClCLkcsOR Z04UP1J8dJqA8gMTTxOLMxOXJJ1UONQPMTnfbSOmLEIQamzTo8maxX/z4+giHsO6zZWN CwyPYdsdztLFoAc6fQt5wVYr3GoWFuPrUkebV+Yg5BEhaLslRqpOf372Xyz7A0d4CZJC Ol9A== X-Gm-Message-State: ALoCoQnPY7M5N4/4T4yRV2izNJpSmR01guN2oKAj0DK5L3E4fr+RgovLlMQrbcAnGCK/U18h21Vj X-Received: by 10.68.251.133 with SMTP id zk5mr5252657pbc.69.1385164563013; Fri, 22 Nov 2013 15:56:03 -0800 (PST) Received: from localhost.localdomain (c-67-169-181-221.hsd1.ca.comcast.net. [67.169.181.221]) by mx.google.com with ESMTPSA id sd3sm55895043pbb.42.2013.11.22.15.56.01 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Nov 2013 15:56:02 -0800 (PST) From: Christoffer Dall To: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] arm/arm64: KVM: vgic: Bugfix in vgic_dispatch_sgi Date: Fri, 22 Nov 2013 15:57:18 -0800 Message-Id: <1385164639-18710-3-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 1.8.4.3 In-Reply-To: <1385164639-18710-1-git-send-email-christoffer.dall@linaro.org> References: <1385164639-18710-1-git-send-email-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131122_185625_316116_FDD3204D X-CRM114-Status: GOOD ( 11.64 ) X-Spam-Score: -2.6 (--) Cc: Haibin Wang , Christoffer Dall X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When software writes to the GICD_SGIR with the TargetListFilter field set to 0, we should use the target_cpus mask as the VCPU destination mask for the SGI. However, because we were falling through to the next case due to a missing break, we would always send the SGI to all other cores than ourselves. This does not change anything on dual-core system (unless a core is IPI'ing itself), but would look quite bad on systems with more cores. Cc: Haibin Wang Reported-by: Haibin Wang Signed-off-by: Christoffer Dall --- virt/kvm/arm/vgic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 6699ed9..ecee766 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c @@ -751,7 +751,7 @@ static void vgic_dispatch_sgi(struct kvm_vcpu *vcpu, u32 reg) case 0: if (!target_cpus) return; - + break; case 1: target_cpus = ((1 << nrcpus) - 1) & ~(1 << vcpu_id) & 0xff; break;