From patchwork Mon Nov 25 15:27:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Jensen X-Patchwork-Id: 3232961 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4B7569F3B8 for ; Mon, 25 Nov 2013 15:29:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 962CD2011C for ; Mon, 25 Nov 2013 15:29:23 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAB17201BF for ; Mon, 25 Nov 2013 15:29:18 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky5M-0006YH-A1; Mon, 25 Nov 2013 15:28:28 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky5B-0002D8-89; Mon, 25 Nov 2013 15:28:17 +0000 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky4p-00028H-TG for linux-arm-kernel@lists.infradead.org; Mon, 25 Nov 2013 15:27:56 +0000 Received: by mail-lb0-f181.google.com with SMTP id q8so3366691lbi.12 for ; Mon, 25 Nov 2013 07:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fxM954TP6dO/KF8xuQj8P2kcQ7EzLUBZJ6KKdz+13s8=; b=bSpZi4vPGcX4kzegs3Wz9itq9OrkZZwRQYsgLqjh1xJ9jtC+9qr+i5JGK/R85fME71 SGYrP8QduhR/lxGbXM5pH0Kiq0PTpgB7+XqEF6qKS3oKiJxh9OdlpbhPYL/d2eC2pmSJ ul8ligTrpUBuCnvUJar0lk8m2uXPeuAAmXHzjmg+l9nJSVP6dFshgrZBURnb0Wilmn5V FWIZxrQlu32+srErRJCWy37+l8HTlO2CsbznaqmAcwAq8YT4QkUL3+zWPN05P+uZyxe3 C7R4qCqhLuHX7JL0Nhud7MOtAbeem17yg9Ptu1icxSy9OjsuQabWqQhkR+FInH+ApeVy cxZg== X-Received: by 10.112.199.196 with SMTP id jm4mr47348lbc.59.1385393253748; Mon, 25 Nov 2013 07:27:33 -0800 (PST) Received: from Ildjarn.ath.cx (static-213-115-41-10.sme.bredbandsbolaget.se. [213.115.41.10]) by mx.google.com with ESMTPSA id bo10sm6487292lbb.16.2013.11.25.07.27.32 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Nov 2013 07:27:33 -0800 (PST) From: Jonas Jensen To: netdev@vger.kernel.org Subject: [PATCH v2 5/6] net: MOXA ART: generate random address Date: Mon, 25 Nov 2013 16:27:07 +0100 Message-Id: <1385393228-22416-5-git-send-email-jonas.jensen@gmail.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1385393228-22416-1-git-send-email-jonas.jensen@gmail.com> References: <1385393228-22416-1-git-send-email-jonas.jensen@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131125_102756_149725_BB4A061C X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, Jonas Jensen , bhutchings@solarflare.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The address register is zero:ed on boot, fill it with a randomly generated address on probe. Signed-off-by: Jonas Jensen --- Notes: Applies to next-20131125 drivers/net/ethernet/moxa/moxart_ether.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index d1c4a83..ef7a347 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -734,6 +734,12 @@ static int moxart_mac_probe(struct platform_device *pdev) goto init_fail; } + if (!is_valid_ether_addr(ndev->dev_addr)) { + eth_hw_addr_random(ndev); + netdev_info(ndev, "generated random MAC address %pM\n", + ndev->dev_addr); + } + netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n", __func__, ndev->irq, ndev->dev_addr);