From patchwork Mon Nov 25 15:27:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Jensen X-Patchwork-Id: 3232971 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B59D9C045B for ; Mon, 25 Nov 2013 15:30:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 18F59201ED for ; Mon, 25 Nov 2013 15:30:12 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E240D201BF for ; Mon, 25 Nov 2013 15:30:10 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky5d-0006g5-MR; Mon, 25 Nov 2013 15:28:47 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky5K-0002Dr-GN; Mon, 25 Nov 2013 15:28:26 +0000 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vky4r-00028Y-Ro for linux-arm-kernel@lists.infradead.org; Mon, 25 Nov 2013 15:27:59 +0000 Received: by mail-la0-f43.google.com with SMTP id n7so3228233lam.30 for ; Mon, 25 Nov 2013 07:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Zq5LYCQ5TZpg5IFNEbG6P/hxii0SxgYVpVABi9dvr+E=; b=io1Nx6qv7chLsbsPsPrLAdeilZUwOp3uA9iiJrdyDr+3ZkJVQnp5Yi8eRXXEap4Ao3 nzTnqtUw+vsOr+IPy++/52/rpmfQjuj4KyhyGcMqzlZvKa8k5NzsAn94UZGysLCIZBYi WVKl6gMuSYKRlj6fXlxA7FJnn/5VwjQApXCFmVS3wnsoHWi34v62MrAdLzUvBTDesgfR J6NyenQPr+BevD475BMwcGhHR6m0EncUit4US4vBkaCGp8MntDWJx23OedNNk3Grm+Zh Cg8CqaaIPcOzaJsI7CGSa+TOnixwgXcZhUvvjeP70XgXtz4lblK7qtbfssuRLxrBoWPm qXcQ== X-Received: by 10.112.200.100 with SMTP id jr4mr1821829lbc.36.1385393255531; Mon, 25 Nov 2013 07:27:35 -0800 (PST) Received: from Ildjarn.ath.cx (static-213-115-41-10.sme.bredbandsbolaget.se. [213.115.41.10]) by mx.google.com with ESMTPSA id bo10sm6487292lbb.16.2013.11.25.07.27.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Nov 2013 07:27:34 -0800 (PST) From: Jonas Jensen To: netdev@vger.kernel.org Subject: [PATCH v2 6/6] net: MOXA ART: use eth_mac_addr() Date: Mon, 25 Nov 2013 16:27:08 +0100 Message-Id: <1385393228-22416-6-git-send-email-jonas.jensen@gmail.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1385393228-22416-1-git-send-email-jonas.jensen@gmail.com> References: <1385393228-22416-1-git-send-email-jonas.jensen@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131125_102758_117674_1461424D X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, Jonas Jensen , bhutchings@solarflare.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace boilerplate in moxart_set_mac_address() with eth_mac_addr(). Signed-off-by: Jonas Jensen --- Notes: Applies to next-20131125 drivers/net/ethernet/moxa/moxart_ether.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index ef7a347..e6e42ee 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -57,12 +57,7 @@ static void moxart_update_mac_address(struct net_device *ndev) static int moxart_set_mac_address(struct net_device *ndev, void *addr) { - struct sockaddr *address = addr; - - if (!is_valid_ether_addr(address->sa_data)) - return -EADDRNOTAVAIL; - - memcpy(ndev->dev_addr, address->sa_data, ndev->addr_len); + eth_mac_addr(ndev, addr); moxart_update_mac_address(ndev); return 0;