diff mbox

[03/15] serial: sh-sci: Restrict non-COMPILE_TEST compilation

Message ID 1385515117-23664-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laurent Pinchart Nov. 27, 2013, 1:18 a.m. UTC
Hardware supported by the driver is only found on SUPERH or
ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Simon Horman Nov. 28, 2013, 7:37 a.m. UTC | #1
On Wed, Nov 27, 2013 at 02:18:25AM +0100, Laurent Pinchart wrote:
> Hardware supported by the driver is only found on SUPERH or
> ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-serial@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/tty/serial/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index a3817ab..a640d0b 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
>  
>  config SERIAL_SH_SCI
>  	tristate "SuperH SCI(F) serial port support"
> -	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> +	depends on HAVE_CLK
> +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
>  	select SERIAL_CORE
>  
>  config SERIAL_SH_SCI_NR_UARTS
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Greg KH Dec. 3, 2013, 6:45 p.m. UTC | #2
On Wed, Nov 27, 2013 at 02:18:25AM +0100, Laurent Pinchart wrote:
> Hardware supported by the driver is only found on SUPERH or
> ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-serial@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/tty/serial/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laurent Pinchart Dec. 11, 2013, 12:44 p.m. UTC | #3
Hi Simon,

Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci 
updates for v3.14" series ?

On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
> On Wed, Nov 27, 2013 at 02:18:25AM +0100, Laurent Pinchart wrote:
> > Hardware supported by the driver is only found on SUPERH or
> > ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-serial@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> 
> > ---
> > 
> >  drivers/tty/serial/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index a3817ab..a640d0b 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > 
> >  config SERIAL_SH_SCI
> >  	tristate "SuperH SCI(F) serial port support"
> > -	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > +	depends on HAVE_CLK
> > +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> >  	select SERIAL_CORE
> >  
> >  config SERIAL_SH_SCI_NR_UARTS
Laurent Pinchart Dec. 24, 2013, 12:03 p.m. UTC | #4
Hi Simon,

On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:
> Hi Simon,
> 
> Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci
> updates for v3.14" series ?

I've updated all my pending branches to your latest devel tag and this patch 
is missing. Could you please pick it up ?

> On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
> > On Wed, Nov 27, 2013 at 02:18:25AM +0100, Laurent Pinchart wrote:
> > > Hardware supported by the driver is only found on SUPERH or
> > > ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
> > > 
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: linux-serial@vger.kernel.org
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Acked-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > > ---
> > > 
> > >  drivers/tty/serial/Kconfig | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > index a3817ab..a640d0b 100644
> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > > 
> > >  config SERIAL_SH_SCI
> > >  	tristate "SuperH SCI(F) serial port support"
> > > -	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > > +	depends on HAVE_CLK
> > > +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> > >  	select SERIAL_CORE
> > >  
> > >  config SERIAL_SH_SCI_NR_UARTS
Simon Horman Dec. 24, 2013, 2:26 p.m. UTC | #5
On Tue, Dec 24, 2013 at 01:03:10PM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci
> > updates for v3.14" series ?
> 
> I've updated all my pending branches to your latest devel tag and this patch 
> is missing. Could you please pick it up ?

Sure, will do.

> 
> > On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
> > > On Wed, Nov 27, 2013 at 02:18:25AM +0100, Laurent Pinchart wrote:
> > > > Hardware supported by the driver is only found on SUPERH or
> > > > ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
> > > > 
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: linux-serial@vger.kernel.org
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Acked-by: Simon Horman <horms+renesas@verge.net.au>
> > > 
> > > > ---
> > > > 
> > > >  drivers/tty/serial/Kconfig | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > > index a3817ab..a640d0b 100644
> > > > --- a/drivers/tty/serial/Kconfig
> > > > +++ b/drivers/tty/serial/Kconfig
> > > > @@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
> > > > 
> > > >  config SERIAL_SH_SCI
> > > >  	tristate "SuperH SCI(F) serial port support"
> > > > -	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> > > > +	depends on HAVE_CLK
> > > > +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> > > >  	select SERIAL_CORE
> > > >  
> > > >  config SERIAL_SH_SCI_NR_UARTS
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Simon Horman Dec. 27, 2013, 2:17 a.m. UTC | #6
On Tue, Dec 24, 2013 at 11:26:41PM +0900, Simon Horman wrote:
> On Tue, Dec 24, 2013 at 01:03:10PM +0100, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:
> > > Hi Simon,
> > > 
> > > Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci
> > > updates for v3.14" series ?
> > 
> > I've updated all my pending branches to your latest devel tag and this patch 
> > is missing. Could you please pick it up ?
> 
> Sure, will do.

I have now done so. But I'm not sure that it will make it into v3.14.
If not it might be best to send it back to Greg for v3.15. I can handle that.
diff mbox

Patch

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a3817ab..a640d0b 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -709,7 +709,8 @@  config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS