| Message ID | 1386124624-22414-3-git-send-email-voice.shen@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/12/2013 03:37, Bo Shen wrote: > Change sam9x5 with wm8731 work in DSP A mode, this will fix the > left/right channel swap issue. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > --- > sound/soc/atmel/sam9x5_wm8731.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c > index 992ae38..06c1811 100644 > --- a/sound/soc/atmel/sam9x5_wm8731.c > +++ b/sound/soc/atmel/sam9x5_wm8731.c > @@ -107,7 +107,7 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev) > dai->stream_name = "WM8731 PCM"; > dai->codec_dai_name = "wm8731-hifi"; > dai->init = sam9x5_wm8731_init; > - dai->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF > + dai->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF > | SND_SOC_DAIFMT_CBM_CFM; > > ret = snd_soc_of_parse_card_name(card, "atmel,model"); > Tested-by: Richard Genoud <richard.genoud@gmail.com> on at91sam9g35-ek with 3.12-rc2 + "ASoC: wm8731: fix dsp mode configuration" Thanks !
On Wed, Dec 04, 2013 at 10:37:04AM +0800, Bo Shen wrote: > Change sam9x5 with wm8731 work in DSP A mode, this will fix the > left/right channel swap issue. Applied, thanks.
Richard, > -----Original Message----- > From: linux-arm-kernel [mailto:linux-arm-kernel- > bounces@lists.infradead.org] On Behalf Of Richard Genoud > Sent: Wednesday, December 04, 2013 6:38 AM > To: Bo Shen > Cc: zql@glomationinc.com; nicolas.ferre@atmel.com; alsa-devel@alsa- > project.org; linux-sound@vger.kernel.org; broonie@kernel.org; linux- > arm-kernel@lists.infradead.org > Subject: Re: [PATCH 2/2] ASoC: sam9x5_wm8731: change to work in DSP A > mode > > On 04/12/2013 03:37, Bo Shen wrote: > > Change sam9x5 with wm8731 work in DSP A mode, this will fix the > > left/right channel swap issue. > > > > > Tested-by: Richard Genoud <richard.genoud@gmail.com> on at91sam9g35-ek > with 3.12-rc2 + "ASoC: wm8731: fix dsp mode configuration" > > > Thanks ! > > Where can I get a snap shot of your kernel source? My test still have the same issue after I applied the two patches. Thanks, Zhong
2013/12/4 Zhong Li <zql@glomationinc.com>: > Richard, > >> -----Original Message----- >> From: linux-arm-kernel [mailto:linux-arm-kernel- >> bounces@lists.infradead.org] On Behalf Of Richard Genoud >> Sent: Wednesday, December 04, 2013 6:38 AM >> To: Bo Shen >> Cc: zql@glomationinc.com; nicolas.ferre@atmel.com; alsa-devel@alsa- >> project.org; linux-sound@vger.kernel.org; broonie@kernel.org; linux- >> arm-kernel@lists.infradead.org >> Subject: Re: [PATCH 2/2] ASoC: sam9x5_wm8731: change to work in DSP A >> mode >> >> On 04/12/2013 03:37, Bo Shen wrote: >> > Change sam9x5 with wm8731 work in DSP A mode, this will fix the >> > left/right channel swap issue. >> > > >> > >> Tested-by: Richard Genoud <richard.genoud@gmail.com> on at91sam9g35-ek >> with 3.12-rc2 + "ASoC: wm8731: fix dsp mode configuration" >> >> >> Thanks ! >> >> > > Where can I get a snap shot of your kernel source? My test still have the > same issue after I applied the two patches. I don't have a public git, but I just applied the patches : "ASoC: wm8731: fix dsp mode configuration" "ASoC: sam9x5_wm8731: change to work in DSP A mode" "ASoC: atmel_ssc_dai: add dai trigger ops" on top of 3.12-rc2 => maybe you missed the third patch "ASoC: wm8731: fix dsp mode configuration" which was not part of the serie. (without it, you should have a left channel almost ok and a noisy right channel) and if you want a git tree, you can still test with mark's : git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git branch sound_asoc/for-next or tag asoc-v3.13-rc2
diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c index 992ae38..06c1811 100644 --- a/sound/soc/atmel/sam9x5_wm8731.c +++ b/sound/soc/atmel/sam9x5_wm8731.c @@ -107,7 +107,7 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev) dai->stream_name = "WM8731 PCM"; dai->codec_dai_name = "wm8731-hifi"; dai->init = sam9x5_wm8731_init; - dai->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF + dai->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM; ret = snd_soc_of_parse_card_name(card, "atmel,model");
Change sam9x5 with wm8731 work in DSP A mode, this will fix the left/right channel swap issue. Signed-off-by: Bo Shen <voice.shen@atmel.com> --- sound/soc/atmel/sam9x5_wm8731.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)