Message ID | 1386666370-6394-1-git-send-email-linus.walleij@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 841CE9F37C for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 10 Dec 2013 09:06:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 79AAA2017A for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 10 Dec 2013 09:06:54 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 411832016D for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 10 Dec 2013 09:06:53 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJHE-0001EK-S8; Tue, 10 Dec 2013 09:06:49 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJHC-0000LX-C1; Tue, 10 Dec 2013 09:06:46 +0000 Received: from mail-la0-f41.google.com ([209.85.215.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJH9-0000K7-K1 for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2013 09:06:44 +0000 Received: by mail-la0-f41.google.com with SMTP id eo20so2457144lab.0 for <linux-arm-kernel@lists.infradead.org>; Tue, 10 Dec 2013 01:06:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hlIC12rR7b8zzAegYWIt/Jtg8yzvVmcvCaZtqqVJOkI=; b=jidBF0s3q/b6VzSQPb9Ceo8ouq3ydukphO8Gc8JrOxrQ62LcWHhLWC4rwBdCUIIhkV iXeXnXCt3X3ucTJsBB9iJd8FcRFq01cKjFB3dNufMcoFw79ScVa5rq5bBL+pnRaq03Rh N9rEmQIgoeisS5Qnho3cuoyqn0n/zkfgsfIykAKgg/3T5wAY8t4N2T5NbsDZft7mJrU7 M+71spSl4VoWA1ztLL9lxaZA7TgpMi3NGrAXzdMt7myWjQXlPPPDTbKc7XaUv0QVGY9K mrLrgK/GSqabmmRrCe/U7Vx1E/lyNN21mz9JTOQ5+lN8larZe6awfr5/Ogz+DXZIqFtK zDhw== X-Gm-Message-State: ALoCoQm2/jNgIgijwfg6/Q9DTfl79RCJNEtLB3qNxoWcPDedyOzmOExcQpXrLcHjgyPQTMW0H3tb X-Received: by 10.152.9.193 with SMTP id c1mr4604299lab.53.1386666380054; Tue, 10 Dec 2013 01:06:20 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id c8sm20370364lag.3.2013.12.10.01.06.16 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Dec 2013 01:06:18 -0800 (PST) From: Linus Walleij <linus.walleij@linaro.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] pinctrl: make the MSM SoC driver depend on OF Date: Tue, 10 Dec 2013 10:06:10 +0100 Message-Id: <1386666370-6394-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131210_040643_788690_576695BC X-CRM114-Status: GOOD ( 10.13 ) X-Spam-Score: -2.6 (--) Cc: Linus Walleij <linus.walleij@linaro.org>, Stephen Warren <swarren@nvidia.com>, Bjorn Andersson <bjorn.andersson@sonymobile.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 06e057bb3376..30fcb897eb99 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -211,6 +211,7 @@ config PINCTRL_MSM config PINCTRL_MSM8X74 bool "Qualcomm 8x74 pin controller driver" + depends on OF && OF_IRQ select PINCTRL_MSM config PINCTRL_NOMADIK
We had a compilation failure on x86_64 due to missing OF support as this was an implicit dependency. Add an explicit dependency on OF and OF_IRQ on the SoC driver. Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v2->v3: - Total failure with older approaches: what we need to do is have the *SoC subdriver* depend on OF and OF_IRQ. This is because the placeholder bool PINCTRL_MSM cannot cascade its dependencies when a subdriver selects it, Kconfig is smart but not that smart. ChangeLog v1->v2: - OK so "depends on OF" did not work here let's try to simply select OF and OF_IRQ for this then? It's one of those "warning: (PINCTRL_MSM8X74) selects PINCTRL_MSM which has unmet direct dependencies (PINCTRL && OF)" that I simply cannot find my way out of :-/ --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)