From patchwork Thu Dec 12 08:39:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olof Johansson X-Patchwork-Id: 3330661 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A6D6B9F37A for ; Thu, 12 Dec 2013 08:39:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 95907204E4 for ; Thu, 12 Dec 2013 08:39:20 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 624AB20461 for ; Thu, 12 Dec 2013 08:39:19 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vr1ne-00020q-Od; Thu, 12 Dec 2013 08:39:14 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vr1nc-0005Zf-75; Thu, 12 Dec 2013 08:39:12 +0000 Received: from mail-pb0-f41.google.com ([209.85.160.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vr1nY-0005Yo-Pp for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2013 08:39:09 +0000 Received: by mail-pb0-f41.google.com with SMTP id jt11so126284pbb.0 for ; Thu, 12 Dec 2013 00:38:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fidSyncsQnUsBlffdyTGS2CdXKpvKuruIjBv+ElcLKw=; b=d+PXwNVsnp/+EX4py2HjUG/k5MWUhcDHVP5LdWMw9rngtiXn/UD87KhRZW5LuzwGLf sYdoDSzEDEzv30FDzpLrtpeTwRcmi9UUk7T8JmHL7dyTteMJ7QeUfdYAN1H9aSzH9Pkp QxzbreqTAGF5zs0PVlCFP3NjZVSyQzLSbU1HeFPGSBzH2r67y4/JHc/E3Nqi71K0ZLU5 h5kg6Ks8m3wB4bAMLSTqq6aZ+vacxRCI+oSqF0o7TPyZNAwTu3I3oRG7jSZcQkipQGZt 8JLyK1gR2SIOIfPTMJxAItOLpoOTOtOIuN1Yb7Ucvz064sjiPHEDa7K3HvpMBSiYLtdE aczQ== X-Gm-Message-State: ALoCoQmHXCAsAUb/xDLwqm0Oknws817mQMivvLIvLUVzaFW5zgBUamrEbrLISXqTwMBO1+iTBfr3 X-Received: by 10.68.198.68 with SMTP id ja4mr9834619pbc.24.1386837526537; Thu, 12 Dec 2013 00:38:46 -0800 (PST) Received: from brutus.lixom.net (173-13-129-225-sfba.hfc.comcastbusiness.net. [173.13.129.225]) by mx.google.com with ESMTPSA id hw10sm38329500pbc.24.2013.12.12.00.38.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2013 00:38:45 -0800 (PST) From: Olof Johansson To: davem@davemloft.net Subject: [PATCH] net: eth: 8390: remove section warning in etherh.c Date: Thu, 12 Dec 2013 00:39:37 -0800 Message-Id: <1386837577-15130-1-git-send-email-olof@lixom.net> X-Mailer: git-send-email 1.7.10.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131212_033908_938103_93E0006F X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) Cc: linux@arm.linux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tedheadster@gmail.com, Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit c45f812f0280 ('8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature') ended up moving the printout of version[] from something that will be compiled out due to defines, to something that is now evaluated at runtime. That means that what always used to be an access to an __initdata string from non-__init code started showing up as a section mismatch when it didn't before. All other 8390 versions skip __initdata on the version string, and starting to annotate the whole chain of callers with __init seems like more churn than it's worth on this driver, so remove it from etherh.c as well. Fixes: c45f812f0280 ('8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature') Signed-off-by: Olof Johansson --- drivers/net/ethernet/8390/etherh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/etherh.c b/drivers/net/ethernet/8390/etherh.c index b15e482a..b36ee9e 100644 --- a/drivers/net/ethernet/8390/etherh.c +++ b/drivers/net/ethernet/8390/etherh.c @@ -59,7 +59,7 @@ #define DRV_NAME "etherh" #define DRV_VERSION "1.11" -static char version[] __initdata = +static char version[] = "EtherH/EtherM Driver (c) 2002-2004 Russell King " DRV_VERSION "\n"; #include "lib8390.c"