diff mbox

[v3,6/6] ARM: dts: exynos4: Add missing unit-address of sysreg node

Message ID 1386864738-19829-7-git-send-email-t.figa@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tomasz Figa Dec. 12, 2013, 4:12 p.m. UTC
The node contains reg property, so unit-address suffix should be present
in its name.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kim Kukjin Dec. 18, 2013, 6:23 p.m. UTC | #1
On 12/13/13 01:12, Tomasz Figa wrote:
> The node contains reg property, so unit-address suffix should be present
> in its name.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Acked-by: Kyungmin Park<kyungmin.park@samsung.com>
> Reviewed-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
> ---
>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 4fed2ad..ee173fe 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -99,7 +99,7 @@
>   		reg =<0x10440000 0x1000>;
>   	};
>
> -	sys_reg: sysreg {
> +	sys_reg: sysreg@10010000 {
>   		compatible = "samsung,exynos4-sysreg", "syscon";
>   		reg =<0x10010000 0x400>;
>   	};

Tomasz, I already Sachin's patch for similar changing of sys_reg 
property with your reviewed tag.

ARM: dts: Fix sysreg node name in exynos4.dtsi

I've applied whole this series except this one.
If any problems, please kindly let me know.

Thanks,
Kukjin
Tomasz Figa Dec. 18, 2013, 6:36 p.m. UTC | #2
Hi Kukjin,

2013/12/18 Kukjin Kim <kgene.kim@samsung.com>:
> On 12/13/13 01:12, Tomasz Figa wrote:
>>
>> The node contains reg property, so unit-address suffix should be present
>> in its name.
>>
>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>> Acked-by: Kyungmin Park<kyungmin.park@samsung.com>
>> Reviewed-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi
>> b/arch/arm/boot/dts/exynos4.dtsi
>> index 4fed2ad..ee173fe 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -99,7 +99,7 @@
>>                 reg =<0x10440000 0x1000>;
>>         };
>>
>> -       sys_reg: sysreg {
>> +       sys_reg: sysreg@10010000 {
>>                 compatible = "samsung,exynos4-sysreg", "syscon";
>>                 reg =<0x10010000 0x400>;
>>         };
>
>
> Tomasz, I already Sachin's patch for similar changing of sys_reg property
> with your reviewed tag.
>
> ARM: dts: Fix sysreg node name in exynos4.dtsi
>
> I've applied whole this series except this one.
> If any problems, please kindly let me know.

Oh, I checked if this isn't already fixed when posting this series and
I couldn't
find any related patch. I guess it was posted quite a while ago.

Anyway, it's fine for me, thanks.

Best regards,
Tomasz
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 4fed2ad..ee173fe 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -99,7 +99,7 @@ 
 		reg = <0x10440000 0x1000>;
 	};
 
-	sys_reg: sysreg {
+	sys_reg: sysreg@10010000 {
 		compatible = "samsung,exynos4-sysreg", "syscon";
 		reg = <0x10010000 0x400>;
 	};