diff mbox

[v6,04/15] usb: doc: phy-mxs: update binding for adding anatop phandle

Message ID 1386897825-6130-5-git-send-email-peter.chen@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Chen Dec. 13, 2013, 1:23 a.m. UTC
Add anatop phandle which is used to access anatop registers to
control PHY's power and other USB operations.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 Documentation/devicetree/bindings/usb/mxs-phy.txt |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Felipe Balbi Dec. 13, 2013, 4:25 a.m. UTC | #1
On Fri, Dec 13, 2013 at 09:23:34AM +0800, Peter Chen wrote:
> Add anatop phandle which is used to access anatop registers to
> control PHY's power and other USB operations.

no related to this patch, but this feels like OMAP's System Control
Module (a rather simplistic IP which control power for a few other IPs).

We're starting to see a pattern here, eventually we will need a more
generic approach to such types of modules. For now, don't worry :-)
Peter Chen Dec. 13, 2013, 6 a.m. UTC | #2
On Fri, Dec 13, 2013 at 12:25 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, Dec 13, 2013 at 09:23:34AM +0800, Peter Chen wrote:
>> Add anatop phandle which is used to access anatop registers to
>> control PHY's power and other USB operations.
>
> no related to this patch, but this feels like OMAP's System Control
> Module (a rather simplistic IP which control power for a few other IPs).
>
> We're starting to see a pattern here, eventually we will need a more
> generic approach to such types of modules. For now, don't worry :-)
>

We use syscon (system controller) driver (drivers/mfd/syscon.c)
to handle it, syscon uses regmap to visit register which can keep
register access exclusively.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt
index d850e55..059536c 100644
--- a/Documentation/devicetree/bindings/usb/mxs-phy.txt
+++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt
@@ -5,10 +5,12 @@  Required properties:
 for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl
 - reg: Should contain registers location and length
 - interrupts: Should contain phy interrupt
+- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series
 
 Example:
 usbphy1: usbphy@020c9000 {
 	compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy";
 	reg = <0x020c9000 0x1000>;
 	interrupts = <0 44 0x04>;
+	fsl,anatop = <&anatop>;
 };