diff mbox

[Resend,1/1] clk: exynos5250: Add CLK_SET_RATE_PARENT flag to mout_apll

Message ID 1387442019-2445-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Dec. 19, 2013, 8:33 a.m. UTC
Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
clock rate in the cpufreq driver.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/clk/samsung/clk-exynos5250.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mike Turquette Dec. 19, 2013, 7:37 p.m. UTC | #1
Quoting Sachin Kamat (2013-12-19 00:33:39)
> Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
> clock rate in the cpufreq driver.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Ack.

Regards,
Mike

> ---
>  drivers/clk/samsung/clk-exynos5250.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
> index 80f652053cb5..11178b1ad735 100644
> --- a/drivers/clk/samsung/clk-exynos5250.c
> +++ b/drivers/clk/samsung/clk-exynos5250.c
> @@ -303,7 +303,8 @@ static struct samsung_mux_clock exynos5250_mux_clks[] __initdata = {
>         /*
>          * CMU_CPU
>          */
> -       MUX_A(none, "mout_apll", mout_apll_p, SRC_CPU, 0, 1, "mout_apll"),
> +       MUX_FA(none, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
> +                                       CLK_SET_RATE_PARENT, 0, "mout_apll"),
>         MUX_A(none, "mout_cpu", mout_cpu_p, SRC_CPU, 16, 1, "mout_cpu"),
>  
>         /*
> -- 
> 1.7.9.5
>
Tomasz Figa Dec. 30, 2013, 5:51 p.m. UTC | #2
On Thursday 19 of December 2013 11:37:08 Mike Turquette wrote:
> Quoting Sachin Kamat (2013-12-19 00:33:39)
> > Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
> > clock rate in the cpufreq driver.
> > 
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Ack.

Applied onto next branch.

Best regards,
Tomasz
Sachin Kamat Dec. 31, 2013, 2:54 a.m. UTC | #3
On 30 December 2013 23:21, Tomasz Figa <t.figa@samsung.com> wrote:
> On Thursday 19 of December 2013 11:37:08 Mike Turquette wrote:
>> Quoting Sachin Kamat (2013-12-19 00:33:39)
>> > Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
>> > clock rate in the cpufreq driver.
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Ack.
>
> Applied onto next branch.

Thanks Tomasz. But did not find this branch in your tree [1].
Also, please consider adding your tree to linux-next.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tfiga/samsung-clk.git

---
With warm regards,
Sachin
Tomasz Figa Jan. 2, 2014, 3:24 p.m. UTC | #4
Hi Sachin,

On Tuesday 31 of December 2013 08:24:02 Sachin Kamat wrote:
> On 30 December 2013 23:21, Tomasz Figa <t.figa@samsung.com> wrote:
> > On Thursday 19 of December 2013 11:37:08 Mike Turquette wrote:
> >> Quoting Sachin Kamat (2013-12-19 00:33:39)
> >> > Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
> >> > clock rate in the cpufreq driver.
> >> >
> >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >>
> >> Ack.
> >
> > Applied onto next branch.
> 
> Thanks Tomasz. But did not find this branch in your tree [1].

I haven't pushed the branches yet, as I'm yet to collect some patches
and acks

> Also, please consider adding your tree to linux-next.

Hmm, I would consider this tree only as a staging to send pull requests
for Mike, so patches should be hitting clk-next tree quickly after getting
there. I don't think this makes a need to add this tree to linux-next.

Best regards,
Tomasz
Sachin Kamat Jan. 3, 2014, 3:25 a.m. UTC | #5
Hi Tomasz,

On 2 January 2014 20:54, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Sachin,
>
> On Tuesday 31 of December 2013 08:24:02 Sachin Kamat wrote:
>> On 30 December 2013 23:21, Tomasz Figa <t.figa@samsung.com> wrote:
>> > On Thursday 19 of December 2013 11:37:08 Mike Turquette wrote:
>> >> Quoting Sachin Kamat (2013-12-19 00:33:39)
>> >> > Add CLK_SET_RATE_PARENT flag to mout_apll clock. This will let us set the
>> >> > clock rate in the cpufreq driver.
>> >> >
>> >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >>
>> >> Ack.
>> >
>> > Applied onto next branch.
>>
>> Thanks Tomasz. But did not find this branch in your tree [1].
>
> I haven't pushed the branches yet, as I'm yet to collect some patches
> and acks
>
>> Also, please consider adding your tree to linux-next.
>
> Hmm, I would consider this tree only as a staging to send pull requests
> for Mike, so patches should be hitting clk-next tree quickly after getting
> there. I don't think this makes a need to add this tree to linux-next.

Yes, if the window period between the patches landing into your tree
and Mike's tree
is relatively small, then there is no need. Else it would be good to
avoid merge conflicts
and ease further development and testing.
diff mbox

Patch

diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
index 80f652053cb5..11178b1ad735 100644
--- a/drivers/clk/samsung/clk-exynos5250.c
+++ b/drivers/clk/samsung/clk-exynos5250.c
@@ -303,7 +303,8 @@  static struct samsung_mux_clock exynos5250_mux_clks[] __initdata = {
 	/*
 	 * CMU_CPU
 	 */
-	MUX_A(none, "mout_apll", mout_apll_p, SRC_CPU, 0, 1, "mout_apll"),
+	MUX_FA(none, "mout_apll", mout_apll_p, SRC_CPU, 0, 1,
+					CLK_SET_RATE_PARENT, 0, "mout_apll"),
 	MUX_A(none, "mout_cpu", mout_cpu_p, SRC_CPU, 16, 1, "mout_cpu"),
 
 	/*