| Message ID | 1389658764-39199-8-git-send-email-s-anna@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: > HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC > device families as well. The IPs are identical to that of > OMAP4/OMAP5, except for the number of locks. > > Add a depends on to the above family of SoCs to enable the > build support for OMAP hwspinlock driver for any of the above > SoC configs. > > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > drivers/hwspinlock/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig > index 70637d2..3612cb5 100644 > --- a/drivers/hwspinlock/Kconfig > +++ b/drivers/hwspinlock/Kconfig > @@ -10,7 +10,7 @@ menu "Hardware Spinlock drivers" > > config HWSPINLOCK_OMAP > tristate "OMAP Hardware Spinlock device" > - depends on ARCH_OMAP4 || SOC_OMAP5 > + depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX how about just using ARCH_OMAP2PLUS ?
Felipe, On 01/14/2014 07:12 AM, Felipe Balbi wrote: > On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: >> HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC >> device families as well. The IPs are identical to that of >> OMAP4/OMAP5, except for the number of locks. >> >> Add a depends on to the above family of SoCs to enable the >> build support for OMAP hwspinlock driver for any of the above >> SoC configs. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> --- >> drivers/hwspinlock/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig >> index 70637d2..3612cb5 100644 >> --- a/drivers/hwspinlock/Kconfig >> +++ b/drivers/hwspinlock/Kconfig >> @@ -10,7 +10,7 @@ menu "Hardware Spinlock drivers" >> >> config HWSPINLOCK_OMAP >> tristate "OMAP Hardware Spinlock device" >> - depends on ARCH_OMAP4 || SOC_OMAP5 >> + depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX > > how about just using ARCH_OMAP2PLUS ? We do not want the driver to build in OMAP2-only and/or OMAP3-only configurations, on which the hwspinlock IP is not even present. regards Suman
On Tue, Jan 14, 2014 at 10:51:31AM -0600, Anna, Suman wrote: > Felipe, > > On 01/14/2014 07:12 AM, Felipe Balbi wrote: > >On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: > >>HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC > >>device families as well. The IPs are identical to that of > >>OMAP4/OMAP5, except for the number of locks. > >> > >>Add a depends on to the above family of SoCs to enable the > >>build support for OMAP hwspinlock driver for any of the above > >>SoC configs. > >> > >>Signed-off-by: Suman Anna <s-anna@ti.com> > >>--- > >> drivers/hwspinlock/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig > >>index 70637d2..3612cb5 100644 > >>--- a/drivers/hwspinlock/Kconfig > >>+++ b/drivers/hwspinlock/Kconfig > >>@@ -10,7 +10,7 @@ menu "Hardware Spinlock drivers" > >> > >> config HWSPINLOCK_OMAP > >> tristate "OMAP Hardware Spinlock device" > >>- depends on ARCH_OMAP4 || SOC_OMAP5 > >>+ depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX > > > >how about just using ARCH_OMAP2PLUS ? > > We do not want the driver to build in OMAP2-only and/or OMAP3-only > configurations, on which the hwspinlock IP is not even present. It won't be enabled by default, will it ? You're just saying that it _can_ be enabled. In fact, I would go one step further and use: depends on ARCH_OMAP2PLUS || COMPILE_TEST your choice though ;-)
On 01/14/2014 11:29 AM, Felipe Balbi wrote: > On Tue, Jan 14, 2014 at 10:51:31AM -0600, Anna, Suman wrote: >> Felipe, >> >> On 01/14/2014 07:12 AM, Felipe Balbi wrote: >>> On Mon, Jan 13, 2014 at 06:19:24PM -0600, Suman Anna wrote: >>>> HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC >>>> device families as well. The IPs are identical to that of >>>> OMAP4/OMAP5, except for the number of locks. >>>> >>>> Add a depends on to the above family of SoCs to enable the >>>> build support for OMAP hwspinlock driver for any of the above >>>> SoC configs. >>>> >>>> Signed-off-by: Suman Anna <s-anna@ti.com> >>>> --- >>>> drivers/hwspinlock/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig >>>> index 70637d2..3612cb5 100644 >>>> --- a/drivers/hwspinlock/Kconfig >>>> +++ b/drivers/hwspinlock/Kconfig >>>> @@ -10,7 +10,7 @@ menu "Hardware Spinlock drivers" >>>> >>>> config HWSPINLOCK_OMAP >>>> tristate "OMAP Hardware Spinlock device" >>>> - depends on ARCH_OMAP4 || SOC_OMAP5 >>>> + depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX >>> >>> how about just using ARCH_OMAP2PLUS ? >> >> We do not want the driver to build in OMAP2-only and/or OMAP3-only >> configurations, on which the hwspinlock IP is not even present. > > It won't be enabled by default, will it ? You're just saying that it > _can_ be enabled. > Yes, that's correct. The menuconfig will not even show this driver at present on OMAP2-only and/or OMAP3-only configs. I would prefer to keep it that way. regards Suman
diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig index 70637d2..3612cb5 100644 --- a/drivers/hwspinlock/Kconfig +++ b/drivers/hwspinlock/Kconfig @@ -10,7 +10,7 @@ menu "Hardware Spinlock drivers" config HWSPINLOCK_OMAP tristate "OMAP Hardware Spinlock device" - depends on ARCH_OMAP4 || SOC_OMAP5 + depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX select HWSPINLOCK help Say y here to support the OMAP Hardware Spinlock device (firstly
HwSpinlocks are supported on AM33xx, AM43xx and DRA7xx SoC device families as well. The IPs are identical to that of OMAP4/OMAP5, except for the number of locks. Add a depends on to the above family of SoCs to enable the build support for OMAP hwspinlock driver for any of the above SoC configs. Signed-off-by: Suman Anna <s-anna@ti.com> --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)