| Message ID | 1389669956-2304-4-git-send-email-voice.shen@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11:25 Tue 14 Jan , Bo Shen wrote: > Add the option to choose clock output on which pin connect to SSC. > Default is on TK pin to SSC, add clk_from_rk_pin option, the clock > is on RK pin to SSC. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > --- > > Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > index 8bbe50c..68a5c1a 100644 > --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > @@ -33,6 +33,8 @@ Required properties: > > Optional properties: > - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt > + - clk_from_rk_pin: according to hardware design, clk privide on rk pin provide ?? no example? > + to ssc device > > Example: > sound { > -- > 1.8.5.2 >
On 14/01/2014 04:25, Bo Shen : > Add the option to choose clock output on which pin connect to SSC. > Default is on TK pin to SSC, add clk_from_rk_pin option, the clock Please do not use "_" in DT properties. It is a common pattern to use "-" instead. > is on RK pin to SSC. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > --- > > Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > index 8bbe50c..68a5c1a 100644 > --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > @@ -33,6 +33,8 @@ Required properties: > > Optional properties: > - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt > + - clk_from_rk_pin: according to hardware design, clk privide on rk pin typo + more description is needed: Please tell that it is a boolean property, that by default it is using the TK pin (like in the commit message in fact). Bye, > + to ssc device > > Example: > sound { >
Hi J, On 01/15/2014 07:54 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:25 Tue 14 Jan , Bo Shen wrote: >> Add the option to choose clock output on which pin connect to SSC. >> Default is on TK pin to SSC, add clk_from_rk_pin option, the clock >> is on RK pin to SSC. >> >> Signed-off-by: Bo Shen <voice.shen@atmel.com> >> --- >> >> Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> index 8bbe50c..68a5c1a 100644 >> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> @@ -33,6 +33,8 @@ Required properties: >> >> Optional properties: >> - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt >> + - clk_from_rk_pin: according to hardware design, clk privide on rk pin > provide > > ?? no example? If this patch set is acceptable. The sama5 audio will use it (I will send patch after this patch set). Do I still need to put the example in the binding document? >> + to ssc device >> >> Example: >> sound { >> -- >> 1.8.5.2 >> Best Regards, Bo Shen
Hi Nicolas, On 01/16/2014 01:17 AM, Nicolas Ferre wrote: > On 14/01/2014 04:25, Bo Shen : >> Add the option to choose clock output on which pin connect to SSC. >> Default is on TK pin to SSC, add clk_from_rk_pin option, the clock > > Please do not use "_" in DT properties. It is a common pattern to use > "-" instead. OK, I will use "-" instead in next version. >> is on RK pin to SSC. >> >> Signed-off-by: Bo Shen <voice.shen@atmel.com> >> --- >> >> Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> index 8bbe50c..68a5c1a 100644 >> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt >> @@ -33,6 +33,8 @@ Required properties: >> >> Optional properties: >> - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt >> + - clk_from_rk_pin: according to hardware design, clk privide on rk pin > > typo + more description is needed: > Please tell that it is a boolean property, that by default it is using > the TK pin (like in the commit message in fact). OK, I will add more description for it. Thanks > Bye, > >> + to ssc device >> >> Example: >> sound { >> > > Best Regards, Bo Shen
On Thu, Jan 16, 2014 at 09:33:20AM +0800, Bo Shen wrote: > On 01/15/2014 07:54 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> Optional properties: > >> - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt > >>+ - clk_from_rk_pin: according to hardware design, clk privide on rk pin > > provide > > ?? no example? > If this patch set is acceptable. The sama5 audio will use it (I will > send patch after this patch set). Do I still need to put the example > in the binding document? It doesn't seem terribly worthwhile to have the example include every boolean property, it's not like people should find it hard to work out how to use them.
diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt index 8bbe50c..68a5c1a 100644 --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt @@ -33,6 +33,8 @@ Required properties: Optional properties: - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt + - clk_from_rk_pin: according to hardware design, clk privide on rk pin + to ssc device Example: sound {
Add the option to choose clock output on which pin connect to SSC. Default is on TK pin to SSC, add clk_from_rk_pin option, the clock is on RK pin to SSC. Signed-off-by: Bo Shen <voice.shen@atmel.com> --- Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ 1 file changed, 2 insertions(+)