| Message ID | 1389912312-16285-1-git-send-email-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14-01-16 02:45 PM, Linus Walleij wrote: > As this driver is using pinconf_generic_dt_node_to_map_pin() it > needs to depend on OF so as not to cause build problems on > archs that do not support OF. > > Cc: Sherman Yin <syin@broadcom.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/pinctrl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index f1dda4d9de13..be361b7cd30f 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 > > config PINCTRL_CAPRI > bool "Broadcom Capri pinctrl driver" > + depends on OF > select PINMUX > select PINCONF > select GENERIC_PINCONF > Thanks for the fix, Linus. While we're visiting this config, should we add "depends on MACH_BCM_MOBILE" as well? Thanks, Sherman
On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > Thanks for the fix, Linus. While we're visiting this config, should we add > "depends on MACH_BCM_MOBILE" as well? No, it's nice to get the compile coverage. Yours, Linus Walleij
On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > >> Thanks for the fix, Linus. While we're visiting this config, should we add >> "depends on MACH_BCM_MOBILE" as well? > > No, it's nice to get the compile coverage. But maybe you can experiment with that special option that only turns on the driver on other platforms to do compile test. Yours, Linus Walleij
On 01/17/2014 04:13 PM, Linus Walleij wrote: > On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >> >>> Thanks for the fix, Linus. While we're visiting this config, should we add >>> "depends on MACH_BCM_MOBILE" as well? >> >> No, it's nice to get the compile coverage. > > But maybe you can experiment with that special option that only > turns on the driver on other platforms to do compile test. a/k/a depends on XXX || COMPILE_TEST
On Sat, Jan 18, 2014 at 12:27 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 01/17/2014 04:13 PM, Linus Walleij wrote: >> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij >> <linus.walleij@linaro.org> wrote: >>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >>> >>>> Thanks for the fix, Linus. While we're visiting this config, should we add >>>> "depends on MACH_BCM_MOBILE" as well? >>> >>> No, it's nice to get the compile coverage. >> >> But maybe you can experiment with that special option that only >> turns on the driver on other platforms to do compile test. > > a/k/a > depends on XXX || COMPILE_TEST Yep, thanks Stephen :-) Linus Walleij
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index f1dda4d9de13..be361b7cd30f 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 config PINCTRL_CAPRI bool "Broadcom Capri pinctrl driver" + depends on OF select PINMUX select PINCONF select GENERIC_PINCONF
As this driver is using pinconf_generic_dt_node_to_map_pin() it needs to depend on OF so as not to cause build problems on archs that do not support OF. Cc: Sherman Yin <syin@broadcom.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)