| Message ID | 1390911522-28209-6-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I would like to drop this patch. It does not make sense as "max14577_dt_match" is always compiled and of_match_ptr was removed on purpose by Sachin Kamat (ae679c12e8; mfd: max14577: Remove redundant of_match_ptr helper). Best regards, Krzysztof Kozlowski On Tue, 2014-01-28 at 13:18 +0100, Krzysztof Kozlowski wrote: > Use of_match_ptr() in assignment of i2c_driver.of_match_table. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/mfd/max14577.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c > index 2ac2f2d7cea6..75b37082a3fe 100644 > --- a/drivers/mfd/max14577.c > +++ b/drivers/mfd/max14577.c > @@ -224,7 +224,7 @@ static struct i2c_driver max14577_i2c_driver = { > .name = "max14577", > .owner = THIS_MODULE, > .pm = &max14577_pm, > - .of_match_table = max14577_dt_match, > + .of_match_table = of_match_ptr(max14577_dt_match), > }, > .probe = max14577_i2c_probe, > .remove = max14577_i2c_remove,
> Use of_match_ptr() in assignment of i2c_driver.of_match_table. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/mfd/max14577.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c > index 2ac2f2d7cea6..75b37082a3fe 100644 > --- a/drivers/mfd/max14577.c > +++ b/drivers/mfd/max14577.c > @@ -224,7 +224,7 @@ static struct i2c_driver max14577_i2c_driver = { > .name = "max14577", > .owner = THIS_MODULE, > .pm = &max14577_pm, > - .of_match_table = max14577_dt_match, > + .of_match_table = of_match_ptr(max14577_dt_match), Are you sure this is required? > }, > .probe = max14577_i2c_probe, > .remove = max14577_i2c_remove,
On Mon, 2014-02-03 at 09:30 +0000, Lee Jones wrote: > > Use of_match_ptr() in assignment of i2c_driver.of_match_table. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Cc: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > drivers/mfd/max14577.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c > > index 2ac2f2d7cea6..75b37082a3fe 100644 > > --- a/drivers/mfd/max14577.c > > +++ b/drivers/mfd/max14577.c > > @@ -224,7 +224,7 @@ static struct i2c_driver max14577_i2c_driver = { > > .name = "max14577", > > .owner = THIS_MODULE, > > .pm = &max14577_pm, > > - .of_match_table = max14577_dt_match, > > + .of_match_table = of_match_ptr(max14577_dt_match), > > Are you sure this is required? No, it was my mistake. Please ignore this patch. Krzysztof
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 2ac2f2d7cea6..75b37082a3fe 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -224,7 +224,7 @@ static struct i2c_driver max14577_i2c_driver = { .name = "max14577", .owner = THIS_MODULE, .pm = &max14577_pm, - .of_match_table = max14577_dt_match, + .of_match_table = of_match_ptr(max14577_dt_match), }, .probe = max14577_i2c_probe, .remove = max14577_i2c_remove,
Use of_match_ptr() in assignment of i2c_driver.of_match_table. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/mfd/max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)