| Message ID | 1391205990-22506-1-git-send-email-robherring2@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jan 31, 2014 at 04:06:30PM -0600, Rob Herring wrote: > From: Rob Herring <robh@kernel.org> > > SMP is a user configurable option, not a hardware feature and should not > be selected. > > Signed-off-by: Rob Herring <robh@kernel.org> Yep, you're right. applied to fixes. -Olof
On Fri, Jan 31, 2014 at 4:51 PM, Olof Johansson <olof@lixom.net> wrote: > On Fri, Jan 31, 2014 at 04:06:30PM -0600, Rob Herring wrote: >> From: Rob Herring <robh@kernel.org> >> >> SMP is a user configurable option, not a hardware feature and should not >> be selected. >> >> Signed-off-by: Rob Herring <robh@kernel.org> > > Yep, you're right. applied to fixes. After doing some randconfig builds I found HAVE_ARM_TWD and HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and SH-Mobile are still using LOCAL_TIMER which has been gone for a year. I guess everyone tests with other platforms enabled or don't notice they are using broadcast timer. Patch is coming. Rob
On Sat, Feb 1, 2014 at 7:52 AM, Rob Herring <robherring2@gmail.com> wrote: > On Fri, Jan 31, 2014 at 4:51 PM, Olof Johansson <olof@lixom.net> wrote: >> On Fri, Jan 31, 2014 at 04:06:30PM -0600, Rob Herring wrote: >>> From: Rob Herring <robh@kernel.org> >>> >>> SMP is a user configurable option, not a hardware feature and should not >>> be selected. >>> >>> Signed-off-by: Rob Herring <robh@kernel.org> >> >> Yep, you're right. applied to fixes. > > After doing some randconfig builds I found HAVE_ARM_TWD and > HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and > SH-Mobile are still using LOCAL_TIMER which has been gone for a year. > I guess everyone tests with other platforms enabled or don't notice > they are using broadcast timer. Patch is coming. Yep, I noticed the same yesterday but please send the patch over and I'll apply it before sending up the current batch. The OMAP platform that uses LOCAL_TIMER is OMAP5, and 5 isn't functional in mainline yet -- I can guarantee you that nobody is testing it. :( -Olof
On Sat, Feb 1, 2014 at 10:43 AM, Olof Johansson <olof@lixom.net> wrote: > On Sat, Feb 1, 2014 at 7:52 AM, Rob Herring <robherring2@gmail.com> wrote: >> On Fri, Jan 31, 2014 at 4:51 PM, Olof Johansson <olof@lixom.net> wrote: >>> On Fri, Jan 31, 2014 at 04:06:30PM -0600, Rob Herring wrote: >>>> From: Rob Herring <robh@kernel.org> >>>> >>>> SMP is a user configurable option, not a hardware feature and should not >>>> be selected. >>>> >>>> Signed-off-by: Rob Herring <robh@kernel.org> >>> >>> Yep, you're right. applied to fixes. >> >> After doing some randconfig builds I found HAVE_ARM_TWD and >> HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and >> SH-Mobile are still using LOCAL_TIMER which has been gone for a year. >> I guess everyone tests with other platforms enabled or don't notice >> they are using broadcast timer. Patch is coming. > > Yep, I noticed the same yesterday but please send the patch over and > I'll apply it before sending up the current batch. > > The OMAP platform that uses LOCAL_TIMER is OMAP5, and 5 isn't > functional in mainline yet -- I can guarantee you that nobody is > testing it. :( Actually that is needed for OMAP4 as ARM_TWD is the Cortex-A9 timers. Rob
diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig index 018ad67..8f4649b 100644 --- a/arch/arm/mach-hisi/Kconfig +++ b/arch/arm/mach-hisi/Kconfig @@ -12,6 +12,5 @@ config ARCH_HI3xxx select HAVE_SMP select PINCTRL select PINCTRL_SINGLE - select SMP help Support for Hisilicon Hi36xx/Hi37xx processor family