From patchwork Tue Feb 4 12:30:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 3575931 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DAA0D9F382 for ; Tue, 4 Feb 2014 12:51:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1375420166 for ; Tue, 4 Feb 2014 12:51:03 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28D6620163 for ; Tue, 4 Feb 2014 12:51:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAf9k-0007AZ-Ny; Tue, 04 Feb 2014 12:31:14 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAf9G-0006hb-AK; Tue, 04 Feb 2014 12:30:42 +0000 Received: from mail-we0-f178.google.com ([74.125.82.178]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAf9D-0006fr-Qn for linux-arm-kernel@lists.infradead.org; Tue, 04 Feb 2014 12:30:40 +0000 Received: by mail-we0-f178.google.com with SMTP id q59so4072573wes.9 for ; Tue, 04 Feb 2014 04:30:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=6UQ5yz4V1sYQsxpSBfTbyWv7uxVvGRPEFiLUG0DaKvY=; b=JMPxHIZcAcAAUO1mOd7Ac/I7W+lDvDKdtbbkZm26rRszz6o2ggvQ/9+BmEW4Bgvme7 NYabcLn+k5HKrc/snsiaMbrniIjrSucGOTtxlGsSq7tGEpIfdC7WmYdmCoSvpR3H890G QP8zcrEzKDroOkAfrh/KLvafvaXq7onm0DXaS5gzKg6dOGKOIg1Y/hnEMIsi4PadA1k+ JJM1Fcc4kjY487ZbFju0F00KtdvH047USnkL0glcUBuL88n6jhs4YeG8zykiyP8gHzro 11S+jMKdThSZLtEiKflCt0lscLKPrhBTR7cFfAalToN7H+Nck50oMpBXeE1LXrNi9Xo+ nNKg== X-Gm-Message-State: ALoCoQmYVSWjjCloWOWTUzJmoZFwXgTqsXD7DEkRDi8wq8ob1AV8Xj9EedVd3yg7dGzr5V8+OPHC X-Received: by 10.180.101.40 with SMTP id fd8mr7517926wib.1.1391517013506; Tue, 04 Feb 2014 04:30:13 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id h9sm35912097wjz.16.2014.02.04.04.30.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2014 04:30:11 -0800 (PST) From: Linus Walleij To: arm@kernel.org Subject: [PATCH] ARM: pxa: fix compilation problem on AM300EPD board Date: Tue, 4 Feb 2014 13:30:05 +0100 Message-Id: <1391517005-12004-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.5.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140204_073039_970951_DB02D213 X-CRM114-Status: GOOD ( 11.00 ) X-Spam-Score: -2.6 (--) Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This board fails compilation like this: arch/arm/mach-pxa/am300epd.c: In function ‘am300_cleanup’: arch/arm/mach-pxa/am300epd.c:179:2: error: implicit declaration of function ‘PXA_GPIO_TO_IRQ’ [-Werror=implicit-function-declaration] free_irq(PXA_GPIO_TO_IRQ(RDY_GPIO_PIN), par); This was caused by commit 88f718e3fa4d67f3a8dbe79a2f97d722323e4051 "ARM: pxa: delete the custom GPIO header" This is because it was previously getting the macro PXA_GPIO_TO_IRQ implicitly from which in turn implicitly included which in turn included . Add the missing include so that the board compiles again. Reported-by: Arnd Bergmann Signed-off-by: Linus Walleij --- Hi ARM SoC folks: please apply this patch directly to the ARM SoC tree fixes branch if you are happy with it. --- arch/arm/mach-pxa/am300epd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-pxa/am300epd.c b/arch/arm/mach-pxa/am300epd.c index c9f309ae88c5..8b90c4f2d430 100644 --- a/arch/arm/mach-pxa/am300epd.c +++ b/arch/arm/mach-pxa/am300epd.c @@ -30,6 +30,7 @@ #include #include +#include #include #include "generic.h"