From patchwork Fri Feb 7 14:59:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 3605851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DFA5B9F344 for ; Fri, 7 Feb 2014 15:08:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB13320154 for ; Fri, 7 Feb 2014 15:08:35 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD64200F4 for ; Fri, 7 Feb 2014 15:08:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBn0W-0003Ql-Kk; Fri, 07 Feb 2014 15:06:21 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBmvc-0004I2-9o; Fri, 07 Feb 2014 15:01:16 +0000 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBmv0-0004DA-NM for linux-arm-kernel@lists.infradead.org; Fri, 07 Feb 2014 15:00:48 +0000 Received: by mail-wg0-f50.google.com with SMTP id l18so2367910wgh.29 for ; Fri, 07 Feb 2014 07:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Qi+ZQt2bPQQfcEhNvNzjw9642bt5eN82L7hlojGSg4Y=; b=T55tikB/MAZBTsfTAsIxAsY4Is7PPjWUYaQE9u572JDfPjxUu2b5dy3dmDx95Fcnpn jjUhztVY6GnqXYqMoUw5GG2gqSsO6sZ8dk1ZISq8IwqcO8Hn/MJFP+NdNwemCo4Raf9w pbLZBbuoQ6nE5LwJ9lj/OkXe/tEWDdy5uiIkDSl/10JNnpQK729Z/qVVNEmQIagZAYKM inU9rbi6JaCwzVWnLpa2zkUg6lU0Pc3bavYSlqZdU2cWrIC4kF4ButB/9afVQAFbTneg 6N//0KJFNKqu7Hvv+eqQ0pvBtAH+OQm1NLbZ2y0rZzFBI3eQzqdkr0/z9XH4wQk212xM V4yA== X-Received: by 10.194.86.200 with SMTP id r8mr6611518wjz.49.1391785221233; Fri, 07 Feb 2014 07:00:21 -0800 (PST) Received: from lnx-rg.pr (lyon.paratronic.fr. [213.41.177.106]) by mx.google.com with ESMTPSA id ha1sm11330842wjc.23.2014.02.07.07.00.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2014 07:00:20 -0800 (PST) From: Richard Genoud To: Greg Kroah-Hartman Subject: [PATCH 5/8] tty/serial: at91: add dtr control via gpio Date: Fri, 7 Feb 2014 15:59:12 +0100 Message-Id: <1391785155-18525-6-git-send-email-richard.genoud@gmail.com> X-Mailer: git-send-email 1.8.5 In-Reply-To: <1391785155-18525-1-git-send-email-richard.genoud@gmail.com> References: <1391785155-18525-1-git-send-email-richard.genoud@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140207_100039_222227_87ABDC99 X-CRM114-Status: GOOD ( 16.79 ) X-Spam-Score: -2.0 (--) Cc: Richard Genoud , Linus Walleij , Nicolas Ferre , linux-serial@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On sam9x5, the USART controller doesn't handle DTR/DSR/DCD/RI signals, so we have to control them via GPIO. This patch permits to use a GPIO to control the DTR signal. Signed-off-by: Richard Genoud --- Documentation/devicetree/bindings/serial/atmel-usart.txt | 3 +++ arch/arm/mach-at91/at91rm9200_devices.c | 5 +++++ arch/arm/mach-at91/at91sam9260_devices.c | 7 +++++++ arch/arm/mach-at91/at91sam9261_devices.c | 4 ++++ arch/arm/mach-at91/at91sam9263_devices.c | 4 ++++ arch/arm/mach-at91/at91sam9g45_devices.c | 5 +++++ arch/arm/mach-at91/at91sam9rl_devices.c | 5 +++++ drivers/tty/serial/atmel_serial.c | 13 +++++++++++++ include/linux/platform_data/atmel.h | 1 + 9 files changed, 47 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/atmel-usart.txt b/Documentation/devicetree/bindings/serial/atmel-usart.txt index 6c0898e4b58e..77d45c88b494 100644 --- a/Documentation/devicetree/bindings/serial/atmel-usart.txt +++ b/Documentation/devicetree/bindings/serial/atmel-usart.txt @@ -17,6 +17,8 @@ Optional properties: function pin for the USART RTS feature. If unsure, don't specify this property. - cts-gpios: specify a GPIO for CTS line. It will use specified PIO instead of the peripheral function pin for the USART CTS feature. If unsure, don't specify this property. +- dtr-gpios: specify a GPIO for DTR line. It will use specified PIO instead of the peripheral + function pin for the USART DTR feature. If unsure, don't specify this property. - add dma bindings for dma transfer: - dmas: DMA specifier, consisting of a phandle to DMA controller node, memory peripheral interface and USART DMA channel ID, FIFO configuration. @@ -39,6 +41,7 @@ Example: atmel,use-dma-tx; rts-gpios = <&pioD 15 0>; cts-gpios = <&pioD 16 0>; + dtr-gpios = <&pioD 17 0>; }; - use DMA: diff --git a/arch/arm/mach-at91/at91rm9200_devices.c b/arch/arm/mach-at91/at91rm9200_devices.c index 4688a85cabc4..d8523cc05157 100644 --- a/arch/arm/mach-at91/at91rm9200_devices.c +++ b/arch/arm/mach-at91/at91rm9200_devices.c @@ -924,6 +924,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, /* DBGU not capable of receive DMA */ .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -964,6 +965,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -1016,6 +1018,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -1069,6 +1072,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); @@ -1114,6 +1118,7 @@ static struct atmel_uart_data uart3_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart3_dmamask = DMA_BIT_MASK(32); diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c index 5e8f0d1add1d..b8e325b00e1a 100644 --- a/arch/arm/mach-at91/at91sam9260_devices.c +++ b/arch/arm/mach-at91/at91sam9260_devices.c @@ -821,6 +821,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, /* DBGU not capable of receive DMA */ .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -861,6 +862,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -914,6 +916,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -959,6 +962,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); @@ -1004,6 +1008,7 @@ static struct atmel_uart_data uart3_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart3_dmamask = DMA_BIT_MASK(32); @@ -1049,6 +1054,7 @@ static struct atmel_uart_data uart4_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart4_dmamask = DMA_BIT_MASK(32); @@ -1089,6 +1095,7 @@ static struct atmel_uart_data uart5_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart5_dmamask = DMA_BIT_MASK(32); diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c index f0ccc835e331..3a05d9f09b0d 100644 --- a/arch/arm/mach-at91/at91sam9261_devices.c +++ b/arch/arm/mach-at91/at91sam9261_devices.c @@ -882,6 +882,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, /* DBGU not capable of receive DMA */ .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -922,6 +923,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -967,6 +969,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -1012,6 +1015,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c index 1e696ceacfaf..d26255ba3907 100644 --- a/arch/arm/mach-at91/at91sam9263_devices.c +++ b/arch/arm/mach-at91/at91sam9263_devices.c @@ -1326,6 +1326,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, /* DBGU not capable of receive DMA */ .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -1366,6 +1367,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -1411,6 +1413,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -1456,6 +1459,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c index b75eb826b803..67e9f7f259e1 100644 --- a/arch/arm/mach-at91/at91sam9g45_devices.c +++ b/arch/arm/mach-at91/at91sam9g45_devices.c @@ -1589,6 +1589,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -1629,6 +1630,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -1674,6 +1676,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -1719,6 +1722,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); @@ -1764,6 +1768,7 @@ static struct atmel_uart_data uart3_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart3_dmamask = DMA_BIT_MASK(32); diff --git a/arch/arm/mach-at91/at91sam9rl_devices.c b/arch/arm/mach-at91/at91sam9rl_devices.c index 67bf5811b38f..94fecc40dbba 100644 --- a/arch/arm/mach-at91/at91sam9rl_devices.c +++ b/arch/arm/mach-at91/at91sam9rl_devices.c @@ -958,6 +958,7 @@ static struct atmel_uart_data dbgu_data = { .use_dma_rx = 0, /* DBGU not capable of receive DMA */ .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 dbgu_dmamask = DMA_BIT_MASK(32); @@ -998,6 +999,7 @@ static struct atmel_uart_data uart0_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart0_dmamask = DMA_BIT_MASK(32); @@ -1051,6 +1053,7 @@ static struct atmel_uart_data uart1_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart1_dmamask = DMA_BIT_MASK(32); @@ -1096,6 +1099,7 @@ static struct atmel_uart_data uart2_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart2_dmamask = DMA_BIT_MASK(32); @@ -1141,6 +1145,7 @@ static struct atmel_uart_data uart3_data = { .use_dma_rx = 1, .rts_gpio = -EINVAL, .cts_gpio = -EINVAL, + .dtr_gpio = -EINVAL, }; static u64 uart3_dmamask = DMA_BIT_MASK(32); diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 7a6b0506c050..f5bdb84aed53 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -133,6 +133,7 @@ struct gpio_lines { int rts; /* optional RTS GPIO */ int cts; /* optional CTS GPIO */ int cts_irq; + int dtr; /* optional DTR GPIO */ }; /* @@ -339,6 +340,13 @@ static void atmel_set_mctrl(struct uart_port *port, u_int mctrl) else control |= ATMEL_US_RTSDIS; + if (gpio_is_valid(atmel_port->gpio.dtr)) { + if (mctrl & TIOCM_DTR) + gpio_set_value(atmel_port->gpio.dtr, 0); + else + gpio_set_value(atmel_port->gpio.dtr, 1); + } + if (mctrl & TIOCM_DTR) control |= ATMEL_US_DTREN; else @@ -2454,6 +2462,8 @@ static int atmel_init_gpios(struct atmel_uart_port *atmel_port, "RTS", NULL); ret += atmel_request_gpio(&pdev->dev, atmel_port->gpio.cts, "CTS", &atmel_port->gpio.cts_irq); + ret += atmel_request_gpio(&pdev->dev, atmel_port->gpio.dtr, + "DTR", NULL); return ret; } @@ -2494,13 +2504,16 @@ static int atmel_serial_probe(struct platform_device *pdev) port->uart.line = ret; port->gpio.rts = -EINVAL; /* Invalid, zero could be valid */ port->gpio.cts = -EINVAL; + port->gpio.dtr = -EINVAL; port->gpio.cts_irq = INVALID_IRQ; if (pdata) { port->gpio.rts = pdata->rts_gpio; port->gpio.cts = pdata->cts_gpio; + port->gpio.dtr = pdata->dtr_gpio; } else if (np) { port->gpio.rts = of_get_named_gpio(np, "rts-gpios", 0); port->gpio.cts = of_get_named_gpio(np, "cts-gpios", 0); + port->gpio.dtr = of_get_named_gpio(np, "dtr-gpios", 0); } ret = atmel_init_gpios(port, pdev); diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h index 166a99ca911f..8472b6f3c618 100644 --- a/include/linux/platform_data/atmel.h +++ b/include/linux/platform_data/atmel.h @@ -86,6 +86,7 @@ struct atmel_uart_data { struct serial_rs485 rs485; /* rs485 settings */ int rts_gpio; /* optional RTS GPIO */ int cts_gpio; /* optional CTS GPIO */ + int dtr_gpio; /* optional DTR GPIO */ }; /* Touchscreen Controller */