From patchwork Thu Feb 20 00:12:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 3683591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4E707BF13A for ; Thu, 20 Feb 2014 00:14:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 891B3201D5 for ; Thu, 20 Feb 2014 00:14:23 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA0E620166 for ; Thu, 20 Feb 2014 00:14:22 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WGHH1-0000bR-6Q; Thu, 20 Feb 2014 00:13:55 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WGHGs-0004zd-Le; Thu, 20 Feb 2014 00:13:46 +0000 Received: from mail-ig0-f171.google.com ([209.85.213.171]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WGHGW-0004uZ-TI for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2014 00:13:25 +0000 Received: by mail-ig0-f171.google.com with SMTP id uy17so10574986igb.4 for ; Wed, 19 Feb 2014 16:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AeaCqLM46+XzTiHLLOZRusM5KwXvz4vzTGEDyCp/Kvs=; b=gmqRVHr0GOAZzczlwrMUfcSWVO1EUlvgjKXM17wkyH46VbwEgDKbkAJrLauz/3RWX+ R4N0ODdZeb+9CsKlwozlZ5LUcVt/6/wzhgT9TbzpKiC5i8OAw0h4nqn015KJ0xSMiBQP gx8fU/s5JeDHE78FbPvdGwtYCXMvqcEQ+cmbpzIOALQdwZhBqMykN2tynV8XaaB+ZX0i zcacoXxhiDKscYJ3EUWGecmUir8AZU0L39bJzuJUKVXApY4bbXKVPSUh2UdlMwM7EcDo YMUVvCdQALyjDt//q32in0JtM1ro9VJWAYGT0xX7t+UjrLu7/0dyyyvAnayVJieuVwge gE2Q== X-Gm-Message-State: ALoCoQm91+FX9Yo2QgsDNvVCLJy7kf/r3OELO6VS4tvi29QR5Ij8UdMpmJqJXF8vOo7o0hF2jTyZ X-Received: by 10.43.61.206 with SMTP id wx14mr13287388icb.43.1392855183495; Wed, 19 Feb 2014 16:13:03 -0800 (PST) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id gd5sm5623419igd.5.2014.02.19.16.13.02 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Feb 2014 16:13:03 -0800 (PST) From: Alex Elder To: mturquette@linaro.org, bcm@fixthebug.org, mporter@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk Subject: [PATCH 01/12] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Wed, 19 Feb 2014 18:12:51 -0600 Message-Id: <1392855182-21155-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1392855182-21155-1-git-send-email-elder@linaro.org> References: <1392855182-21155-1-git-send-email-elder@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140219_191324_990304_57E3975B X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.3 (/) Cc: devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index e3d339e..c01d810 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }