| Message ID | 1392990146-18916-1-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 21, 2014 at 2:42 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > This change makes it easier to configure a kernel for a real machine by > not showing the option to enable it at all if COMPILE_TEST is off. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Markus: can you ACK this patch? Yours, Linus Walleij
On 14-02-27 01:16 AM, Linus Walleij wrote: > On Fri, Feb 21, 2014 at 2:42 PM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > >> This change makes it easier to configure a kernel for a real machine by >> not showing the option to enable it at all if COMPILE_TEST is off. >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Markus: can you ACK this patch? Acked-by: Markus Mayer <mmayer@broadcom.com>
On 21 February 2014 05:42, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > I'm not sure if and how "Kona" fits into the bcm281xx namespace, but > reading through the commit logs of the changes touching > drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd > consider it a good idea to mention "bcm281xx" in the help text of > GPIO_BCM_KONA. Naming these components has been quite a challenge for our upstreaming effort. Some things are not very obvious unless you know he chip or were involved in those discussions. "Kona" can be thought of as an architecture or a family of chips. bcm281xx is one member of that family. There are others. I submitted bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses gpio-bcm-kona.c. Mentioning the SoCs in the help text is a good idea, but we'll likely have to come up with a central location where all supported members of the Kona family are listed, so they aren't scattered all over different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If we don't have a central location, we'll be certain to forget updating one of the help texts eventually, and it would become inconsistent. Regards, -Markus
Hello Markus, On Thu, Feb 27, 2014 at 02:20:17PM -0800, Markus Mayer wrote: > On 21 February 2014 05:42, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > I'm not sure if and how "Kona" fits into the bcm281xx namespace, but > > reading through the commit logs of the changes touching > > drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd > > consider it a good idea to mention "bcm281xx" in the help text of > > GPIO_BCM_KONA. > > Naming these components has been quite a challenge for our upstreaming > effort. Some things are not very obvious unless you know he chip or > were involved in those discussions. > > "Kona" can be thought of as an architecture or a family of chips. > bcm281xx is one member of that family. There are others. I submitted > bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses > gpio-bcm-kona.c. > > Mentioning the SoCs in the help text is a good idea, but we'll likely > have to come up with a central location where all supported members of > the Kona family are listed, so they aren't scattered all over > different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If > we don't have a central location, we'll be certain to forget updating > one of the help texts eventually, and it would become inconsistent. Fine for me, but note that this was only a side node and is orthogonal to the patch I sent. So if you want to ack it ... Best regards Uwe
Hello, On Fri, Feb 28, 2014 at 11:27:46AM +0100, Uwe Kleine-König wrote: > Fine for me, but note that this was only a side node and is orthogonal > to the patch I sent. So if you want to ack it ... Oh, you sent an ack already, I didn't say anything. Uwe
On Thu, Feb 27, 2014 at 02:11:20PM -0800, Markus Mayer wrote: > On 14-02-27 01:16 AM, Linus Walleij wrote: > >On Fri, Feb 21, 2014 at 2:42 PM, Uwe Kleine-König > ><u.kleine-koenig@pengutronix.de> wrote: > > > >>This change makes it easier to configure a kernel for a real machine by > >>not showing the option to enable it at all if COMPILE_TEST is off. > >> > >>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > >Markus: can you ACK this patch? > > Acked-by: Markus Mayer <mmayer@broadcom.com> ping! Uwe
On Wed, Sep 24, 2014 at 10:06 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Thu, Feb 27, 2014 at 02:11:20PM -0800, Markus Mayer wrote: >> On 14-02-27 01:16 AM, Linus Walleij wrote: >> >On Fri, Feb 21, 2014 at 2:42 PM, Uwe Kleine-König >> ><u.kleine-koenig@pengutronix.de> wrote: >> > >> >>This change makes it easier to configure a kernel for a real machine by >> >>not showing the option to enable it at all if COMPILE_TEST is off. >> >> >> >>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> > >> >Markus: can you ACK this patch? >> >> Acked-by: Markus Mayer <mmayer@broadcom.com> > ping! Patch applied with Markus' ACK! Yours, Linus Walleij
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 903f24d28ba0..7cc68d26320c 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -817,7 +817,7 @@ config GPIO_MSIC config GPIO_BCM_KONA bool "Broadcom Kona GPIO" - depends on OF_GPIO + depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST) help Turn on GPIO support for Broadcom "Kona" chips.
This change makes it easier to configure a kernel for a real machine by not showing the option to enable it at all if COMPILE_TEST is off. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, I'm not sure if and how "Kona" fits into the bcm281xx namespace, but reading through the commit logs of the changes touching drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd consider it a good idea to mention "bcm281xx" in the help text of GPIO_BCM_KONA. Best regards Uwe drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)