diff mbox

[1/4] ARM: Kirkwood: Add audio node to kirkwood.dtsi

Message ID 1393175982-18516-2-git-send-email-andrew@lunn.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Lunn Feb. 23, 2014, 5:19 p.m. UTC
The binding has existed for a while, so add the missing node so it can
be used by devices.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/boot/dts/kirkwood.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Thomas Petazzoni Feb. 23, 2014, 5:31 p.m. UTC | #1
Dear Andrew Lunn,

On Sun, 23 Feb 2014 18:19:39 +0100, Andrew Lunn wrote:
> The binding has existed for a while, so add the missing node so it can
> be used by devices.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  arch/arm/boot/dts/kirkwood.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> index 7b921b30cfcb..841ca3affbf5 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -310,5 +310,14 @@
>  			#phy-cells = <0>;
>  			status = "ok";
>  		};
> +
> +                audio0: audio-controller@a0000 {
> +			compatible = "marvell,kirkwood-audio";
> +                        reg = <0xa0000 0x2210>;
> +                        interrupts = <24>;
> +                        clocks = <&gate_clk 9>;
> +                        clock-names = "internal";
> +                        status = "disabled";

Bad indentation for all properties except the first one.

Thomas
Sergei Shtylyov Feb. 23, 2014, 5:34 p.m. UTC | #2
Hello.

On 23-02-2014 21:19, Andrew Lunn wrote:

> The binding has existed for a while, so add the missing node so it can
> be used by devices.

> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>   arch/arm/boot/dts/kirkwood.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)

> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> index 7b921b30cfcb..841ca3affbf5 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -310,5 +310,14 @@
>   			#phy-cells = <0>;
>   			status = "ok";
>   		};
> +
> +                audio0: audio-controller@a0000 {
> +			compatible = "marvell,kirkwood-audio";
> +                        reg = <0xa0000 0x2210>;
> +                        interrupts = <24>;
> +                        clocks = <&gate_clk 9>;
> +                        clock-names = "internal";
> +                        status = "disabled";
> +                };

     Could you uniformly indent the node with tabs (like at least the one 
above it)?

WBR, Sergei
diff mbox

Patch

diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
index 7b921b30cfcb..841ca3affbf5 100644
--- a/arch/arm/boot/dts/kirkwood.dtsi
+++ b/arch/arm/boot/dts/kirkwood.dtsi
@@ -310,5 +310,14 @@ 
 			#phy-cells = <0>;
 			status = "ok";
 		};
+
+                audio0: audio-controller@a0000 {
+			compatible = "marvell,kirkwood-audio";
+                        reg = <0xa0000 0x2210>;
+                        interrupts = <24>;
+                        clocks = <&gate_clk 9>;
+                        clock-names = "internal";
+                        status = "disabled";
+                };
 	};
 };