| Message ID | 1393588721-8598-1-git-send-email-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) > patch-in the MAC address for FEC using this alias. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Shawn Guo <shawn.guo@linaro.org> Bump ? Best regards, Marek Vasut
On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) > > patch-in the MAC address for FEC using this alias. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Shawn Guo <shawn.guo@linaro.org> > > Bump ? Sorry. I had actually applied the patch but forgot replying. Shawn
On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) > > > patch-in the MAC address for FEC using this alias. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > Bump ? > > Sorry. I had actually applied the patch but forgot replying. Uh, no, apology is on my end for not checking first. Sorry! Thank you! Best regards, Marek Vasut
On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) > > > patch-in the MAC address for FEC using this alias. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > Bump ? > > Sorry. I had actually applied the patch but forgot replying. Hello Shawn, I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ? Best regards, Marek Vasut
On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote: > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) > > > > patch-in the MAC address for FEC using this alias. > > > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > > > Bump ? > > > > Sorry. I had actually applied the patch but forgot replying. > > Hello Shawn, > > I'd like to apply this patch for 3.14-stable , are you OK with this please ? > Shall I submit it ? I do not see why this is a stable material. But you do not need my approval to send patch for stable kernel. The person you need to convince is Greg. Shawn
On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote: > On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote: > > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like > > > > > U-Boot) patch-in the MAC address for FEC using this alias. > > > > > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > > > > > Bump ? > > > > > > Sorry. I had actually applied the patch but forgot replying. > > > > Hello Shawn, > > > > I'd like to apply this patch for 3.14-stable , are you OK with this > > please ? Shall I submit it ? > > I do not see why this is a stable material. But you do not need my > approval to send patch for stable kernel. The person you need to > convince is Greg. Without this patch, you will not get a mac address patched into the DT by the bootloader. Therefore, your device will use a random mac address on the network which is different on every boot. This is not a good thing, don't you agree? Best regards, Marek Vasut
On Tue, Jul 22, 2014 at 07:00:48AM +0200, Marek Vasut wrote: > On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote: > > On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote: > > > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > > > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like > > > > > > U-Boot) patch-in the MAC address for FEC using this alias. > > > > > > > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > > > > > > > Bump ? > > > > > > > > Sorry. I had actually applied the patch but forgot replying. > > > > > > Hello Shawn, > > > > > > I'd like to apply this patch for 3.14-stable , are you OK with this > > > please ? Shall I submit it ? > > > > I do not see why this is a stable material. But you do not need my > > approval to send patch for stable kernel. The person you need to > > convince is Greg. > > Without this patch, you will not get a mac address patched into the DT by the > bootloader. Therefore, your device will use a random mac address on the network > which is different on every boot. This is not a good thing, don't you agree? I agree this is not a good thing. But it's neither a regression nor a critical issue as defined by stable_kernel_rules.txt. Shawn
On Tuesday, July 22, 2014 at 07:20:48 AM, Shawn Guo wrote: > On Tue, Jul 22, 2014 at 07:00:48AM +0200, Marek Vasut wrote: > > On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote: > > > On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote: > > > > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote: > > > > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote: > > > > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote: > > > > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like > > > > > > > U-Boot) patch-in the MAC address for FEC using this alias. > > > > > > > > > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > > > > > > > > > Bump ? > > > > > > > > > > Sorry. I had actually applied the patch but forgot replying. > > > > > > > > Hello Shawn, > > > > > > > > I'd like to apply this patch for 3.14-stable , are you OK with this > > > > please ? Shall I submit it ? > > > > > > I do not see why this is a stable material. But you do not need my > > > approval to send patch for stable kernel. The person you need to > > > convince is Greg. > > > > Without this patch, you will not get a mac address patched into the DT by > > the bootloader. Therefore, your device will use a random mac address on > > the network which is different on every boot. This is not a good thing, > > don't you agree? > > I agree this is not a good thing. But it's neither a regression nor a > critical issue as defined by stable_kernel_rules.txt. If I cannot even properly boot from an NFS root with v3.14.y , it seems to me to be problem enough. Also, MAC address should be a unique identifier, if the FEC picks a random MAC, it will wreak havoc on the network (in the better case). Best regards, Marek Vasut
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 32f760e..77bb743 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -14,6 +14,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 6279e0b..83a8247 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -16,6 +16,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 88b218f..e59ccb4 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -13,6 +13,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 0c75fe3..c249064 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -17,6 +17,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index e4b07d1..e508e6f 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -19,6 +19,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index 80615df..5f382ea 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -18,6 +18,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3; diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index a2d5c49..d63df59 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -14,6 +14,7 @@ / { aliases { + ethernet0 = &fec; can0 = &can1; can1 = &can2; gpio0 = &gpio1; diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 3cb4941..6477447 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -14,6 +14,7 @@ / { aliases { + ethernet0 = &fec; gpio0 = &gpio1; gpio1 = &gpio2; gpio2 = &gpio3;
Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Shawn Guo <shawn.guo@linaro.org> --- arch/arm/boot/dts/imx25.dtsi | 1 + arch/arm/boot/dts/imx27.dtsi | 1 + arch/arm/boot/dts/imx35.dtsi | 1 + arch/arm/boot/dts/imx50.dtsi | 1 + arch/arm/boot/dts/imx51.dtsi | 1 + arch/arm/boot/dts/imx53.dtsi | 1 + arch/arm/boot/dts/imx6qdl.dtsi | 1 + arch/arm/boot/dts/imx6sl.dtsi | 1 + 8 files changed, 8 insertions(+)