From patchwork Wed Mar 5 00:03:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Hesselbarth X-Patchwork-Id: 3769301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9203F9F376 for ; Wed, 5 Mar 2014 00:04:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BC0D320240 for ; Wed, 5 Mar 2014 00:04:04 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 901472023F for ; Wed, 5 Mar 2014 00:04:03 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKzJP-000459-8X; Wed, 05 Mar 2014 00:03:51 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKzJM-0000zL-PS; Wed, 05 Mar 2014 00:03:48 +0000 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKzJI-0000xs-Ti for linux-arm-kernel@lists.infradead.org; Wed, 05 Mar 2014 00:03:46 +0000 Received: by mail-ee0-f41.google.com with SMTP id t10so100047eei.28 for ; Tue, 04 Mar 2014 16:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+QHH52Yf5CWCRjTBp6Ox+1jdhjWQzPpvyaaNKvuGjDI=; b=IS6Pek9AFi1dahmyX6HOneSLzdeO6D1n0g/aWnTzvi2pc69Hk9Z/MaxXbzFr+YHASV S0ko1BMjw2ucCdIS/rviBt5v4K/AsM9IxZmyLQ/RC03pXQhxsIw9QlEyXtMVf1M+mAY3 ki3I+ZSq02kUDjipTKXmVg7I55NRH2eOhqKCcePAYRNN8nxi6ijwbHLXlDyxoPiH4kBB TkrHpb65USXQtdBp5sYaM2w3wohKzen93hVyEqpOTzs6kcfrVD5O5nBx25LTLyc+PP7F qeNPCrLTkSrF04KmeuCi+UVY1OHNb0/oUBKYUvskOD4H+5ccLvSGHul5CFdOifJ59poS xiiQ== X-Received: by 10.14.175.2 with SMTP id y2mr2091383eel.75.1393977803259; Tue, 04 Mar 2014 16:03:23 -0800 (PST) Received: from topkick.lan (dslc-082-083-251-183.pools.arcor-ip.net. [82.83.251.183]) by mx.google.com with ESMTPSA id 46sm1952523ees.4.2014.03.04.16.03.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Mar 2014 16:03:22 -0800 (PST) From: Sebastian Hesselbarth To: Sebastian Hesselbarth Subject: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn Date: Wed, 5 Mar 2014 01:03:10 +0100 Message-Id: <1393977790-29110-4-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1393977790-29110-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1393977790-29110-1-git-send-email-sebastian.hesselbarth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140304_190345_127941_CE9BE01B X-CRM114-Status: GOOD ( 10.83 ) X-Spam-Score: -2.0 (--) Cc: Andrew Lunn , Russell King , Jason Cooper , devicetree@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Gregory Clement , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Pinctrl will WARN on missing DT resources, which is a little bit too noisy. Use dev_warn with FW_BUG instead. Signed-off-by: Sebastian Hesselbarth --- Cc: Russell King Cc: Jason Cooper Cc: Andrew Lunn Cc: Gregory Clement Cc: Linus Walleij Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 9e7ff651c018..3b022178a566 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c @@ -832,7 +832,8 @@ static int dove_pinctrl_probe(struct platform_device *pdev) } /* Warn on any missing DT resource */ - WARN(fb_res.start, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n"); + if (fb_res.start) + dev_warn(&pdev->dev, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n"); return mvebu_pinctrl_probe(pdev); }