| Message ID | 1394203251-25361-4-git-send-email-maxime.coquelin@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/03/14 14:40, Maxime COQUELIN wrote: > From: Giuseppe Cavallaro <peppe.cavallaro@st.com> > > This patch adds the initial support for pinctrl based on H407 SoC. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > --- Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> From: Giuseppe Cavallaro <peppe.cavallaro@st.com> > > This patch adds the initial support for pinctrl based on H407 SoC. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> SOBs should be in order of submission flow and author's should only be kept if the patch is unchanged. If it's been adapted you will require a re-review and they Acked-by or Reviewed-by tag. > --- > drivers/pinctrl/pinctrl-st.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 1721611..d1886b4 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -390,6 +390,19 @@ static const struct st_pctl_data stih416_data = { > .alt = 0, .oe = 40, .pu = 50, .od = 60, .rt = 100, > }; > > +static const struct st_pctl_data stih407_flashdata = { Nit: Double space. > + .rt_style = st_retime_style_none, > + .input_delays = stih416_delays, > + .ninput_delays = 14, ARRAY_SIZE(stih416_delays) > + .output_delays = stih416_delays, > + .noutput_delays = 14, ARRAY_SIZE(stih416_delays) > + .alt = 0, > + .oe = -1, /* Not Available */ > + .pu = -1, /* Not Available */ > + .od = 60, > + .rt = 100, > +}; > + > /* Low level functions.. */ > static inline int st_gpio_bank(int gpio) > { > @@ -1596,6 +1609,10 @@ static struct of_device_id st_pctl_of_match[] = { > { .compatible = "st,stih416-rear-pinctrl", .data = &stih416_data}, > { .compatible = "st,stih416-fvdp-fe-pinctrl", .data = &stih416_data}, > { .compatible = "st,stih416-fvdp-lite-pinctrl", .data = &stih416_data}, > + { .compatible = "st,stih407-sbc-pinctrl", .data = &stih416_data}, > + { .compatible = "st,stih407-front-pinctrl", .data = &stih416_data}, > + { .compatible = "st,stih407-rear-pinctrl", .data = &stih416_data}, > + { .compatible = "st,stih407-flash-pinctrl", .data = &stih407_flashdata}, > { /* sentinel */ } > }; After the small changes above, feel free to add my: Acked-by: Lee Jones <lee.jones@linaro.org>
On 03/10/2014 03:44 PM, Lee Jones wrote: >> From: Giuseppe Cavallaro <peppe.cavallaro@st.com> >> >> This patch adds the initial support for pinctrl based on H407 SoC. >> >> Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com> >> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > > SOBs should be in order of submission flow and author's should only be > kept if the patch is unchanged. If it's been adapted you will require > a re-review and they Acked-by or Reviewed-by tag. > >> --- >> drivers/pinctrl/pinctrl-st.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c >> index 1721611..d1886b4 100644 >> --- a/drivers/pinctrl/pinctrl-st.c >> +++ b/drivers/pinctrl/pinctrl-st.c >> @@ -390,6 +390,19 @@ static const struct st_pctl_data stih416_data = { >> .alt = 0, .oe = 40, .pu = 50, .od = 60, .rt = 100, >> }; >> >> +static const struct st_pctl_data stih407_flashdata = { > > Nit: Double space. Fixed in upcoming v4. > >> + .rt_style = st_retime_style_none, >> + .input_delays = stih416_delays, >> + .ninput_delays = 14, > > ARRAY_SIZE(stih416_delays) > >> + .output_delays = stih416_delays, >> + .noutput_delays = 14, > > ARRAY_SIZE(stih416_delays) Fixed too. V4 will contain one more patch to fix this also in stih416_data. > >> + .alt = 0, >> + .oe = -1, /* Not Available */ >> + .pu = -1, /* Not Available */ >> + .od = 60, >> + .rt = 100, >> +}; >> + >> /* Low level functions.. */ >> static inline int st_gpio_bank(int gpio) >> { >> @@ -1596,6 +1609,10 @@ static struct of_device_id st_pctl_of_match[] = { >> { .compatible = "st,stih416-rear-pinctrl", .data = &stih416_data}, >> { .compatible = "st,stih416-fvdp-fe-pinctrl", .data = &stih416_data}, >> { .compatible = "st,stih416-fvdp-lite-pinctrl", .data = &stih416_data}, >> + { .compatible = "st,stih407-sbc-pinctrl", .data = &stih416_data}, >> + { .compatible = "st,stih407-front-pinctrl", .data = &stih416_data}, >> + { .compatible = "st,stih407-rear-pinctrl", .data = &stih416_data}, >> + { .compatible = "st,stih407-flash-pinctrl", .data = &stih407_flashdata}, >> { /* sentinel */ } >> }; > > After the small changes above, feel free to add my: > Acked-by: Lee Jones <lee.jones@linaro.org> Added. Thanks, Maxime >
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 1721611..d1886b4 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -390,6 +390,19 @@ static const struct st_pctl_data stih416_data = { .alt = 0, .oe = 40, .pu = 50, .od = 60, .rt = 100, }; +static const struct st_pctl_data stih407_flashdata = { + .rt_style = st_retime_style_none, + .input_delays = stih416_delays, + .ninput_delays = 14, + .output_delays = stih416_delays, + .noutput_delays = 14, + .alt = 0, + .oe = -1, /* Not Available */ + .pu = -1, /* Not Available */ + .od = 60, + .rt = 100, +}; + /* Low level functions.. */ static inline int st_gpio_bank(int gpio) { @@ -1596,6 +1609,10 @@ static struct of_device_id st_pctl_of_match[] = { { .compatible = "st,stih416-rear-pinctrl", .data = &stih416_data}, { .compatible = "st,stih416-fvdp-fe-pinctrl", .data = &stih416_data}, { .compatible = "st,stih416-fvdp-lite-pinctrl", .data = &stih416_data}, + { .compatible = "st,stih407-sbc-pinctrl", .data = &stih416_data}, + { .compatible = "st,stih407-front-pinctrl", .data = &stih416_data}, + { .compatible = "st,stih407-rear-pinctrl", .data = &stih416_data}, + { .compatible = "st,stih407-flash-pinctrl", .data = &stih407_flashdata}, { /* sentinel */ } };