| Message ID | 1395250522-30031-1-git-send-email-cov@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote: > On an LPAE system, the physical addresses used by VirtIO-MMIO may > be larger than 32 bits, even if the header and configuration space > addresses fit into 32 bits. For example with the Versatile Express > memory map using 4G memory, the following error occured when trying > to use a VirtIO-MMIO block device. > > EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: : > unaligned directory entry - offset=0, inode=3755990991, rec_len=57311, > name_len=223 > > To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and > VIRTIO_MMIO are selected. > > Signed-off-by: Christopher Covington <cov@codeaurora.org> > --- > arch/arm/mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index 1f8fed9..a62bcc9 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -617,6 +617,7 @@ config ARM_LPAE > bool "Support for the Large Physical Address Extension" > depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \ > !CPU_32v4 && !CPU_32v3 > + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a platform with >32-bit physical address space? If yes, it should be selected there.
Hi Catalin, On 03/21/2014 12:27 PM, Catalin Marinas wrote: > On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote: >> On an LPAE system, the physical addresses used by VirtIO-MMIO may >> be larger than 32 bits, even if the header and configuration space >> addresses fit into 32 bits. For example with the Versatile Express >> memory map using 4G memory, the following error occured when trying >> to use a VirtIO-MMIO block device. >> >> EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: : >> unaligned directory entry - offset=0, inode=3755990991, rec_len=57311, >> name_len=223 >> >> To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and >> VIRTIO_MMIO are selected. >> >> Signed-off-by: Christopher Covington <cov@codeaurora.org> >> --- >> arch/arm/mm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig >> index 1f8fed9..a62bcc9 100644 >> --- a/arch/arm/mm/Kconfig >> +++ b/arch/arm/mm/Kconfig >> @@ -617,6 +617,7 @@ config ARM_LPAE >> bool "Support for the Large Physical Address Extension" >> depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \ >> !CPU_32v4 && !CPU_32v3 >> + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO > > That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a > platform with >32-bit physical address space? If yes, it should be > selected there. The platforms I'm currently using are models like the Versatile Express RTSM/FVP. I can respin with changes to ARCH_VEXPRESS and ARCH_VIRT instead. Thanks, Christopher
On 21 Mar 2014, at 19:44, Christopher Covington <cov@codeaurora.org> wrote: > On 03/21/2014 12:27 PM, Catalin Marinas wrote: >> On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote: >>> On an LPAE system, the physical addresses used by VirtIO-MMIO may >>> be larger than 32 bits, even if the header and configuration space >>> addresses fit into 32 bits. For example with the Versatile Express >>> memory map using 4G memory, the following error occured when trying >>> to use a VirtIO-MMIO block device. >>> >>> EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: : >>> unaligned directory entry - offset=0, inode=3755990991, rec_len=57311, >>> name_len=223 >>> >>> To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and >>> VIRTIO_MMIO are selected. >>> >>> Signed-off-by: Christopher Covington <cov@codeaurora.org> >>> --- >>> arch/arm/mm/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig >>> index 1f8fed9..a62bcc9 100644 >>> --- a/arch/arm/mm/Kconfig >>> +++ b/arch/arm/mm/Kconfig >>> @@ -617,6 +617,7 @@ config ARM_LPAE >>> bool "Support for the Large Physical Address Extension" >>> depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \ >>> !CPU_32v4 && !CPU_32v3 >>> + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO >> >> That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a >> platform with >32-bit physical address space? If yes, it should be >> selected there. > > The platforms I'm currently using are models like the Versatile Express > RTSM/FVP. I can respin with changes to ARCH_VEXPRESS and ARCH_VIRT instead. But do you use RAM beyond 32-bit on such models? Catalin
On 03/21/2014 07:27 PM, Catalin Marinas wrote: > On 21 Mar 2014, at 19:44, Christopher Covington <cov@codeaurora.org> wrote: >> On 03/21/2014 12:27 PM, Catalin Marinas wrote: >>> On Wed, Mar 19, 2014 at 05:35:19PM +0000, Christopher Covington wrote: >>>> On an LPAE system, the physical addresses used by VirtIO-MMIO may >>>> be larger than 32 bits, even if the header and configuration space >>>> addresses fit into 32 bits. For example with the Versatile Express >>>> memory map using 4G memory, the following error occured when trying >>>> to use a VirtIO-MMIO block device. >>>> >>>> EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: : >>>> unaligned directory entry - offset=0, inode=3755990991, rec_len=57311, >>>> name_len=223 >>>> >>>> To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and >>>> VIRTIO_MMIO are selected. >>>> >>>> Signed-off-by: Christopher Covington <cov@codeaurora.org> >>>> --- >>>> arch/arm/mm/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig >>>> index 1f8fed9..a62bcc9 100644 >>>> --- a/arch/arm/mm/Kconfig >>>> +++ b/arch/arm/mm/Kconfig >>>> @@ -617,6 +617,7 @@ config ARM_LPAE >>>> bool "Support for the Large Physical Address Extension" >>>> depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \ >>>> !CPU_32v4 && !CPU_32v3 >>>> + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO >>> >>> That's the wrong place to enable ARCH_DMA_ADDR_T_64BIT. Do you have a >>> platform with >32-bit physical address space? If yes, it should be >>> selected there. >> >> The platforms I'm currently using are models like the Versatile Express >> RTSM/FVP. I can respin with changes to ARCH_VEXPRESS and ARCH_VIRT instead. > > But do you use RAM beyond 32-bit on such models? Yes. On the Versatile Express memory map only 2G RAM is 32-bit accessible, and I'm using 4G as I tried to note in the commit message. http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0575h/Bbajihec.html (For reference, the device tree I'm passing the A32 kernel is arch/arm64/boot/dts/rtsm_ve-aemv8a.dts.) Christopher
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 1f8fed9..a62bcc9 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -617,6 +617,7 @@ config ARM_LPAE bool "Support for the Large Physical Address Extension" depends on MMU && CPU_32v7 && !CPU_32v6 && !CPU_32v5 && \ !CPU_32v4 && !CPU_32v3 + select ARCH_DMA_ADDR_T_64BIT if VIRTIO_MMIO help Say Y if you have an ARMv7 processor supporting the LPAE page table format and you would like to access memory beyond the
On an LPAE system, the physical addresses used by VirtIO-MMIO may be larger than 32 bits, even if the header and configuration space addresses fit into 32 bits. For example with the Versatile Express memory map using 4G memory, the following error occured when trying to use a VirtIO-MMIO block device. EXT2-fs (vda): error: ext2_check_page: bad entry in directory #2: : unaligned directory entry - offset=0, inode=3755990991, rec_len=57311, name_len=223 To fix this, select ARCH_DMA_ADDR_T_64BIT when both LPAE and VIRTIO_MMIO are selected. Signed-off-by: Christopher Covington <cov@codeaurora.org> --- arch/arm/mm/Kconfig | 1 + 1 file changed, 1 insertion(+)