From patchwork Wed Mar 19 19:29:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 3861451 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1146B9F334 for ; Wed, 19 Mar 2014 21:18:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4630A20203 for ; Wed, 19 Mar 2014 21:18:51 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2144201EF for ; Wed, 19 Mar 2014 21:18:49 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQMMw-0005rd-QQ; Wed, 19 Mar 2014 19:41:45 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQMM6-0006NH-To; Wed, 19 Mar 2014 19:40:50 +0000 Received: from moutng.kundenserver.de ([212.227.17.13]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQMHX-0005zx-JG for linux-arm-kernel@lists.infradead.org; Wed, 19 Mar 2014 19:36:09 +0000 Received: from wuerfel.lan (HSI-KBW-134-3-135-108.hsi14.kabel-badenwuerttemberg.de [134.3.135.108]) by mrelayeu.kundenserver.de (node=mreue105) with ESMTP (Nemesis) id 0Lb2eP-1Wo7Jo22uX-00kjWB; Wed, 19 Mar 2014 20:35:45 +0100 From: Arnd Bergmann To: arm@kernel.org Subject: [PATCH 55/62] ARM: samsung: select CRC32 for SAMSUNG_PM_CHECK Date: Wed, 19 Mar 2014 20:29:52 +0100 Message-Id: <1395257399-359545-56-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1395257399-359545-1-git-send-email-arnd@arndb.de> References: <1395257399-359545-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:0ohfdcuJi1yp3GLNyWO3epVmcNYq15O+Sgca7AS12dn xTyJNrY37LLZOJnhILe3qN90gFZg2wrSj6buevCAdijUYKZhun oxQi0Pk4EIuJojrOhG27plIj3JjORklK6e1A+LnpTCcB3b5bo+ IttuN7naFd4BuFhc+TStn+Kw1JMxCNse3T4MNDePlbjaTQcUA+ bBLNlO8vi1G3Y3ylb+H0ic0riGl617fKyI8Aql6mq4DSxM6Bpx VlAgvxFCOTNZRPAK28nM3qvaTIhjxZ0au3d0NcLC1hhJnE5DX5 XzhQP2WLatdI7eGUVInUuW8ygc1jKDQf/vNlBoRrIeuBrXwrNx a2DWrHRRV6o5gFJ3LdggFzjeuPF7Q7ae/RzSvS7+h X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140319_153607_917310_7D044098 X-CRM114-Status: GOOD ( 11.17 ) X-Spam-Score: -1.9 (-) Cc: Kukjin Kim , Ben Dooks , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Tomasz Figa X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Samsung pm_check code uses the crc32 library code, which can be built as a loadable module, in which case we get a link error building the kernel. A better solution is to use 'select CRC32', which is what all other users of this code do, as it ensures it is always built-in. Signed-off-by: Arnd Bergmann Cc: Tomasz Figa Cc: Kukjin Kim Cc: Ben Dooks Acked-by: Kukjin Kim --- arch/arm/plat-samsung/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index c72d612..98f223c 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -445,7 +445,8 @@ config S3C_PM_DEBUG_LED_SMDK config SAMSUNG_PM_CHECK bool "S3C2410 PM Suspend Memory CRC" - depends on PM && CRC32 + depends on PM + select CRC32 help Enable the PM code's memory area checksum over sleep. This option will generate CRCs of all blocks of memory, and store them before