| Message ID | 1396023951-32383-1-git-send-email-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > From: Tim Harvey <tharvey@gateworks.com> > > When using interrupt-maps, the size of a map entry is #address-cells + Plus what? You mean ", and "? > address-cells should be 0 as this is not used. > > As #address-cells = <0> is the same as not specifying the > property, simply remove it. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Did this get applied? I can't seem to find patch 2. Rob
On Thu, Apr 10, 2014 at 10:21:35AM -0500, Rob Herring wrote: > On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > From: Tim Harvey <tharvey@gateworks.com> > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > Plus what? You mean ", and "? > > > address-cells should be 0 as this is not used. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Did this get applied? I can't seem to find patch 2. No. We expect this patch to be applied on DT tree, while the patch #2 [1] is going through IMX tree. Shawn [1] http://www.spinics.net/lists/arm-kernel/msg318810.html
Hi Rob, Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: > On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > From: Tim Harvey <tharvey@gateworks.com> > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > Plus what? You mean ", and "? > Urgh, I obviously messed this up while editing the commit message in the last minute. It should have been something along the lines of: When using interrupt-maps, the size of a map entry is #address-cells + #interrupt-cells. address-cells should be 0 as this offset is not used in the GIC. As #address-cells = <0> is the same as not specifying the property, simply remove it. Can you edit this while applying, or should I send a new patch? > > address-cells should be 0 as this is not used. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Did this get applied? I can't seem to find patch 2. > As Shawn pointed out patch 2 got applied through the imx tree as it fixes a real bug there. Regards, Lucas
On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Hi Rob, > > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> > From: Tim Harvey <tharvey@gateworks.com> >> > >> > When using interrupt-maps, the size of a map entry is #address-cells + >> >> Plus what? You mean ", and "? >> > Urgh, I obviously messed this up while editing the commit message in the > last minute. It should have been something along the lines of: > > When using interrupt-maps, the size of a map entry is #address-cells + > #interrupt-cells. address-cells should be 0 as this offset is not used > in the GIC. > > As #address-cells = <0> is the same as not specifying the > property, simply remove it. > > Can you edit this while applying, or should I send a new patch? I'll fix it up and apply. > >> > address-cells should be 0 as this is not used. >> > >> > As #address-cells = <0> is the same as not specifying the >> > property, simply remove it. >> > >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> >> >> Did this get applied? I can't seem to find patch 2. >> > As Shawn pointed out patch 2 got applied through the imx tree as it > fixes a real bug there. It was highlighted that other instances beyond iMX were wrong. Please fix those as well. Rob
Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring: > On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > Hi Rob, > > > > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: > >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > >> > From: Tim Harvey <tharvey@gateworks.com> > >> > > >> > When using interrupt-maps, the size of a map entry is #address-cells + > >> > >> Plus what? You mean ", and "? > >> > > Urgh, I obviously messed this up while editing the commit message in the > > last minute. It should have been something along the lines of: > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > #interrupt-cells. address-cells should be 0 as this offset is not used > > in the GIC. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Can you edit this while applying, or should I send a new patch? > > I'll fix it up and apply. > Thanks. > > > >> > address-cells should be 0 as this is not used. > >> > > >> > As #address-cells = <0> is the same as not specifying the > >> > property, simply remove it. > >> > > >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > >> > >> Did this get applied? I can't seem to find patch 2. > >> > > As Shawn pointed out patch 2 got applied through the imx tree as it > > fixes a real bug there. > > It was highlighted that other instances beyond iMX were wrong. Please > fix those as well. Oh, I wasn't aware of that. Will send patches. Regards, Lucas
On Fri, Apr 11, 2014 at 8:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring: >> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> > Hi Rob, >> > >> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: >> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> >> > From: Tim Harvey <tharvey@gateworks.com> >> >> > >> >> > When using interrupt-maps, the size of a map entry is #address-cells + >> >> >> >> Plus what? You mean ", and "? >> >> >> > Urgh, I obviously messed this up while editing the commit message in the >> > last minute. It should have been something along the lines of: >> > >> > When using interrupt-maps, the size of a map entry is #address-cells + >> > #interrupt-cells. address-cells should be 0 as this offset is not used >> > in the GIC. >> > >> > As #address-cells = <0> is the same as not specifying the >> > property, simply remove it. >> > >> > Can you edit this while applying, or should I send a new patch? >> >> I'll fix it up and apply. >> > Thanks. > >> > >> >> > address-cells should be 0 as this is not used. >> >> > >> >> > As #address-cells = <0> is the same as not specifying the >> >> > property, simply remove it. >> >> > >> >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> >> >> >> >> Did this get applied? I can't seem to find patch 2. >> >> >> > As Shawn pointed out patch 2 got applied through the imx tree as it >> > fixes a real bug there. >> >> It was highlighted that other instances beyond iMX were wrong. Please >> fix those as well. > > Oh, I wasn't aware of that. Will send patches. It was raised here: http://www.spinics.net/lists/linux-pci/msg29768.html Here's a somewhat accurate list: $ git grep -A8 'arm,.*gic' origin/master -- arch/arm/boot/dts | grep 'address.*1' origin/master:arch/arm/boot/dts/ecx-2000.dts- #address-cells = <1>; origin/master:arch/arm/boot/dts/highbank.dts- #address-cells = <1>; origin/master:arch/arm/boot/dts/imx6qdl.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/imx6sl.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/keystone.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/r8a7740.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/sh73a0.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/socfpga.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/ste-dbx5x0.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/vf610.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/zynq-7000.dtsi- #address-cells = <1>; Rob
diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt index bae0d87a38b2..42ab3b28a266 100644 --- a/Documentation/devicetree/bindings/arm/gic.txt +++ b/Documentation/devicetree/bindings/arm/gic.txt @@ -55,7 +55,6 @@ Example: intc: interrupt-controller@fff11000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; interrupt-controller; reg = <0xfff11000 0x1000>, <0xfff10100 0x100>;