diff mbox

ARM: bcm: Restrict ARCH_BCM selection to ARCH_MULTI_V6_V7

Message ID 1396340779-20550-1-git-send-email-shc_work@mail.ru (mailing list archive)
State New, archived
Headers show

Commit Message

Alexander Shiyan April 1, 2014, 8:26 a.m. UTC
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/mach-bcm/Kconfig | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Comments

Tim Kryger April 1, 2014, 4:31 p.m. UTC | #1
On Tue, Apr 1, 2014 at 1:26 AM, Alexander Shiyan <shc_work@mail.ru> wrote:

> -if ARCH_BCM
> +         This enables support for Broadcom ARM based SoC chips
>
>  menu "Broadcom SoC Selection"
> +       depends on ARCH_BCM
>
>  config ARCH_BCM_MOBILE
>         bool "Broadcom Mobile SoC" if ARCH_MULTI_V7
> @@ -71,5 +68,3 @@ config ARCH_BCM_5301X
>           network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
>
>  endmenu
> -
> -endif
> --
> 1.8.3.2

If applied on top of for-next of arm-soc, this won't do the right thing.

The if ARCH_BCM block will soon include config ARCH_BCM2835 and config
ARCH_BCM_5301X.

-Tim
Tim Kryger April 1, 2014, 4:34 p.m. UTC | #2
On Tue, Apr 1, 2014 at 9:31 AM, Tim Kryger <tim.kryger@linaro.org> wrote:

> If applied on top of for-next of arm-soc, this won't do the right thing.

Oops, I think I misspoke.  Sorry.

-Tim
Matt Porter April 25, 2014, 1:54 p.m. UTC | #3
On Tue, Apr 01, 2014 at 12:26:19PM +0400, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied to mach-bcm for-3.16/soc but I added a proper commit message.
Please always have some description so we know why a patch is needed
even when it seems trivial.

Thanks,
Matt

>  arch/arm/mach-bcm/Kconfig | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 21f97f7..1048ba1 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -1,13 +1,10 @@
>  config ARCH_BCM
> -	bool "Broadcom SoC Support"
> -	depends on ARCH_MULTIPLATFORM
> +	bool "Broadcom SoC Support" if ARCH_MULTI_V6_V7
>  	help
> -	  This enables support for Broadcom ARM based SoC
> -          chips
> -
> -if ARCH_BCM
> +	  This enables support for Broadcom ARM based SoC chips
>  
>  menu "Broadcom SoC Selection"
> +	depends on ARCH_BCM
>  
>  config ARCH_BCM_MOBILE
>  	bool "Broadcom Mobile SoC" if ARCH_MULTI_V7
> @@ -71,5 +68,3 @@ config ARCH_BCM_5301X
>  	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
>  
>  endmenu
> -
> -endif
> -- 
> 1.8.3.2
>
diff mbox

Patch

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 21f97f7..1048ba1 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -1,13 +1,10 @@ 
 config ARCH_BCM
-	bool "Broadcom SoC Support"
-	depends on ARCH_MULTIPLATFORM
+	bool "Broadcom SoC Support" if ARCH_MULTI_V6_V7
 	help
-	  This enables support for Broadcom ARM based SoC
-          chips
-
-if ARCH_BCM
+	  This enables support for Broadcom ARM based SoC chips
 
 menu "Broadcom SoC Selection"
+	depends on ARCH_BCM
 
 config ARCH_BCM_MOBILE
 	bool "Broadcom Mobile SoC" if ARCH_MULTI_V7
@@ -71,5 +68,3 @@  config ARCH_BCM_5301X
 	  network SoC using a MIPS CPU, they are supported by arch/mips/bcm47xx
 
 endmenu
-
-endif