From patchwork Tue Apr 8 14:40:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 3950431 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 81513BFF02 for ; Tue, 8 Apr 2014 18:20:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AF35220256 for ; Tue, 8 Apr 2014 18:20:03 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 414B52024D for ; Tue, 8 Apr 2014 18:20:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXXDi-0002ys-1g; Tue, 08 Apr 2014 14:41:50 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXXD2-00013p-29; Tue, 08 Apr 2014 14:41:08 +0000 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXXCy-000122-Se for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2014 14:41:05 +0000 Received: by mail-pd0-f172.google.com with SMTP id p10so1104686pdj.3 for ; Tue, 08 Apr 2014 07:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=NajypBW+9HbMXPzmqTts6Z+ZdYO9Lg+or5056Yx30jA=; b=oROvBvZQL5Ym3EtrdFWT2xxrRorYrKCUGI32j7PxQ+ZFULq2paOmD/f6ljPaHnzd3Z 9tSVy03ZMtMgUpAJXkN8t5y5a7KSTVPpGSv9pebyov8wEN7INyVJZm44GdWmyIyZ4iPY M9XpjI7VtBMEPOLopmhyr5VkN2WOQlW/cfk3CvHYSVaLNmbwFumYpzLmgHR5+Fo7M1TN vm1HqIScy+zXwwdVW9BPZqTrDEqXSs13JjTFh3t3Y2KdDNpBzSpeVJjfzP4ML1yL6Xsp kdGeAyWoTMdqIEq+OYkoNUlmxywzM2PyU0hjqbGdlEUwmod3x0cEfa/NPhypk9OP4H65 WSaA== X-Received: by 10.66.164.70 with SMTP id yo6mr5024972pab.85.1396968043719; Tue, 08 Apr 2014 07:40:43 -0700 (PDT) Received: from vivek-linuxpc.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id qh2sm11281184pab.13.2014.04.08.07.40.40 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 07:40:43 -0700 (PDT) From: Vivek Gautam To: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback Date: Tue, 8 Apr 2014 20:10:35 +0530 Message-Id: <1396968035-32286-1-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.10.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140408_104105_027257_232EB565 X-CRM114-Status: GOOD ( 10.13 ) X-Spam-Score: -1.6 (-) Cc: gregkh@linuxfoundation.org, kgene.kim@samsung.com, Alan Stern , Manjunath Goudar X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend has already removed 'ohci_hcd' settings from exynos glue layer as a part of streamlining the ohci controller's suspend. So we don't need the locks for 'ohci_hcd' anymore. Signed-off-by: Vivek Gautam Cc: Manjunath Goudar Cc: Alan Stern Acked-by: Jingoo Han --- drivers/usb/host/ohci-exynos.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 68588d8..9cf80cb 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -190,17 +190,13 @@ static int exynos_ohci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd); - struct ohci_hcd *ohci = hcd_to_ohci(hcd); struct platform_device *pdev = to_platform_device(dev); bool do_wakeup = device_may_wakeup(dev); - unsigned long flags; int rc = ohci_suspend(hcd, do_wakeup); if (rc) return rc; - spin_lock_irqsave(&ohci->lock, flags); - if (exynos_ohci->otg) exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self); @@ -208,8 +204,6 @@ static int exynos_ohci_suspend(struct device *dev) clk_disable_unprepare(exynos_ohci->clk); - spin_unlock_irqrestore(&ohci->lock, flags); - return 0; }