| Message ID | 1397122124-15690-3-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 10 April 2014 18:28:19 Chanwoo Choi wrote: > > The non-secure SYSRAM is used for secondary CPU bring-up. This patch add > IO mapping for non-scure SYSRAM. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> I really don't want to see any further static mappings here. We had the same discussion for the previous Exynos chip that was submitted, so please describe the SYSRAM in DT, and start thinking about the other static mappings that can be removed. Arnd
Hi Arnd, > -----Original Message----- > From: linux-arm-kernel [mailto:linux-arm-kernel- > bounces@lists.infradead.org] On Behalf Of Arnd Bergmann > Sent: Thursday, April 10, 2014 6:45 PM > To: linux-arm-kernel@lists.infradead.org > Cc: kgene.kim@samsung.com; t.figa@samsung.com; hyunhee.kim@samsung.com; > sw0312.kim@samsung.com; linux-kernel@vger.kernel.org; > yj44.cho@samsung.com; inki.dae@samsung.com; Chanwoo Choi; > kyungmin.park@samsung.com; linux-samsung-soc@vger.kernel.org > Subject: Re: [PATCH 02/27] ARM: EXYNOS: Add IO mapping for non-secure > SYSRAM of Exynos3250 > > On Thursday 10 April 2014 18:28:19 Chanwoo Choi wrote: > > > > The non-secure SYSRAM is used for secondary CPU bring-up. This patch > add > > IO mapping for non-scure SYSRAM. > > > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > I really don't want to see any further static mappings here. We had the > same discussion for the previous Exynos chip that was submitted, so > please > describe the SYSRAM in DT, and start thinking about the other static > mappings > that can be removed. Sachin already submitted the DT support[1] for SYSRAM area. [1] : http://www.spinics.net/lists/linux-samsung-soc/msg27647.html > > Arnd > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index b134868..cad3bfd 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -35,6 +35,15 @@ #define L2_AUX_VAL 0x7C470001 #define L2_AUX_MASK 0xC200ffff +static struct map_desc exynos3250_iodesc[] __initdata = { + { + .virtual = (unsigned long)S5P_VA_SYSRAM_NS, + .pfn = __phys_to_pfn(EXYNOS3_PA_SYSRAM_NS), + .length = SZ_4K, + .type = MT_DEVICE, + }, +}; + static struct map_desc exynos4_iodesc[] __initdata = { { .virtual = (unsigned long)S3C_VA_SYS, @@ -275,6 +284,9 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname, */ static void __init exynos_map_io(void) { + if (soc_is_exynos3250()) + iotable_init(exynos3250_iodesc, ARRAY_SIZE(exynos3250_iodesc)); + if (soc_is_exynos4()) iotable_init(exynos4_iodesc, ARRAY_SIZE(exynos4_iodesc)); diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index 7b046b5..a53981b 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -26,6 +26,7 @@ #define EXYNOS4_PA_SYSRAM0 0x02025000 #define EXYNOS4_PA_SYSRAM1 0x02020000 #define EXYNOS5_PA_SYSRAM 0x02020000 +#define EXYNOS3_PA_SYSRAM_NS 0x0205F000 #define EXYNOS4210_PA_SYSRAM_NS 0x0203F000 #define EXYNOS4x12_PA_SYSRAM_NS 0x0204F000 #define EXYNOS5250_PA_SYSRAM_NS 0x0204F000