diff mbox

[3/5] arm: omap2: skip device build from platform code for dt.

Message ID 1397651532-31456-4-git-send-email-sourav.poddar@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Poddar, Sourav April 16, 2014, 12:32 p.m. UTC
For SOCs with dt enabled, device should be build through device tree.
Prevent device build call from platform code, if device tree is
enabled.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/mach-omap2/hdq1w.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Paul Walmsley April 28, 2014, 6:28 p.m. UTC | #1
On Wed, 16 Apr 2014, Sourav Poddar wrote:

> For SOCs with dt enabled, device should be build through device tree.
> Prevent device build call from platform code, if device tree is
> enabled.
> 
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>

Isn't OMAP2+ only supporting DT device enumeration now?


- Paul
Felipe Balbi April 28, 2014, 6:39 p.m. UTC | #2
On Mon, Apr 28, 2014 at 06:28:45PM +0000, Paul Walmsley wrote:
> On Wed, 16 Apr 2014, Sourav Poddar wrote:
> 
> > For SOCs with dt enabled, device should be build through device tree.
> > Prevent device build call from platform code, if device tree is
> > enabled.
> > 
> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> 
> Isn't OMAP2+ only supporting DT device enumeration now?

At least OMAP3 still isn't Dt-only.
Poddar, Sourav April 29, 2014, 8:51 a.m. UTC | #3
On Tuesday 29 April 2014 12:09 AM, Felipe Balbi wrote:
> On Mon, Apr 28, 2014 at 06:28:45PM +0000, Paul Walmsley wrote:
>> On Wed, 16 Apr 2014, Sourav Poddar wrote:
>>
>>> For SOCs with dt enabled, device should be build through device tree.
>>> Prevent device build call from platform code, if device tree is
>>> enabled.
>>>
>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> Isn't OMAP2+ only supporting DT device enumeration now?
> At least OMAP3 still isn't Dt-only.
>
Yes, for omap3 boards only, I have kept a #ifndef. Else we could
have remove this code.
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/hdq1w.c b/arch/arm/mach-omap2/hdq1w.c
index cbc8e3c..f78b4a1 100644
--- a/arch/arm/mach-omap2/hdq1w.c
+++ b/arch/arm/mach-omap2/hdq1w.c
@@ -76,6 +76,7 @@  int omap_hdq1w_reset(struct omap_hwmod *oh)
 	return 0;
 }
 
+#ifndef CONFIG_OF
 static int __init omap_init_hdq(void)
 {
 	int id = -1;
@@ -95,3 +96,4 @@  static int __init omap_init_hdq(void)
 	return 0;
 }
 omap_arch_initcall(omap_init_hdq);
+#endif