From patchwork Wed Apr 16 17:17:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Yanovich X-Patchwork-Id: 4003361 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 698F19F2CC for ; Wed, 16 Apr 2014 17:26:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F55720375 for ; Wed, 16 Apr 2014 17:26:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E32F2027D for ; Wed, 16 Apr 2014 17:26:45 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WaTWr-00040U-OT; Wed, 16 Apr 2014 17:21:45 +0000 Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WaTVJ-0007qB-Ho for linux-arm-kernel@lists.infradead.org; Wed, 16 Apr 2014 17:20:10 +0000 Received: by mail-la0-f44.google.com with SMTP id c6so8435328lan.31 for ; Wed, 16 Apr 2014 10:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=z+vlgQdGcjy/EQeLdEBubePzGXr+3Zo94j3Lm42PLh0=; b=S0Y30q57vAGr92l0vlY2mw4/h9USvf8xTEk1bcciWw4BOCV1AXdulq4IYs3C+cNW1E oJkYY4powdxqG0jJ+reBRyxiEALXKw/sJYU8s2IpdPNs5TzmaHNYlWXegRw8SVQDw7mG okBiH5PLLxtRHMi5HlBT0hreGajrcmt2zdbIuCPwUWAbcXPIBNxWHFBkmd7+2O4aXrK1 jZm95Dhyvl+dT6CqtoKsuVzUICLfEUSyFbs366aMvdaKUU1F24EZ0vAWJQHtW4BS3+GY vFKIOvpVdnGsS66GLOw9rM1D/nthNYFP1M/8KirFw/YPPGVArLXHS3GVissfej3AUo+N SfDQ== X-Received: by 10.112.128.131 with SMTP id no3mr1942682lbb.57.1397668790389; Wed, 16 Apr 2014 10:19:50 -0700 (PDT) Received: from host5.omatika.ru (0893675324.static.corbina.ru. [95.31.1.192]) by mx.google.com with ESMTPSA id q4sm21186297lbh.20.2014.04.16.10.19.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Apr 2014 10:19:49 -0700 (PDT) From: Sergei Ianovich To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 19/21] misc: support for I-8041 in LP-8x4x Date: Wed, 16 Apr 2014 21:17:24 +0400 Message-Id: <1397668667-27328-13-git-send-email-ynvich@gmail.com> X-Mailer: git-send-email 1.9.2 In-Reply-To: <1397668667-27328-1-git-send-email-ynvich@gmail.com> References: <1397668411-27162-7-git-send-email-ynvich@gmail.com> <1397668667-27328-1-git-send-email-ynvich@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140416_102010_023192_6B672BA4 X-CRM114-Status: GOOD ( 18.45 ) X-Spam-Score: -0.1 (/) Cc: Sergei Ianovich , Greg Kroah-Hartman , Randy Dunlap , Arnd Bergmann , "open list:DOCUMENTATION" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Status of I-8041 32 digital output channels can be managed via sysfs now. http://www.icpdas.com/products/Remote_IO/i-8ke/i-8041w.htm Signed-off-by: Sergei Ianovich --- v3..v4 v2..v3 v0..v2 * no changes (except number 14/16 -> 19/21) Documentation/misc-devices/lp8x4x_bus.txt | 4 ++ drivers/misc/lp8x4x_bus.c | 67 ++++++++++++++++++++++++++++++- 2 files changed, 69 insertions(+), 2 deletions(-) diff --git a/Documentation/misc-devices/lp8x4x_bus.txt b/Documentation/misc-devices/lp8x4x_bus.txt index 09380fd..68fefde 100644 --- a/Documentation/misc-devices/lp8x4x_bus.txt +++ b/Documentation/misc-devices/lp8x4x_bus.txt @@ -58,3 +58,7 @@ slot_count model RO - shows expansion module model number + +output_status + RW - set status of digital output channels on the module in + the expansion slot. Value can be read back. diff --git a/drivers/misc/lp8x4x_bus.c b/drivers/misc/lp8x4x_bus.c index 59dc767..5af788d 100644 --- a/drivers/misc/lp8x4x_bus.c +++ b/drivers/misc/lp8x4x_bus.c @@ -26,6 +26,9 @@ MODULE_DESCRIPTION("ICP DAS LP-8x4x parallel bus driver"); struct lp8x4x_slot { void *data_addr; unsigned int model; + struct mutex lock; + unsigned int DO_len; + u32 DO; struct device dev; }; @@ -91,6 +94,45 @@ static void lp8x4x_slot_release(struct device *dev) { } +static void lp8x4x_slot_set_DO(struct lp8x4x_slot *s) +{ + int i; + mutex_lock(&s->lock); + for (i = 0; i < s->DO_len; i++) + iowrite8((s->DO >> (i * 8)) & 0xff, s->data_addr + 2 * i); + mutex_unlock(&s->lock); +} + +static ssize_t output_status_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct lp8x4x_slot *s = container_of(dev, struct lp8x4x_slot, dev); + + return sprintf(buf, "0x%08x\n", s->DO); +} + +static ssize_t output_status_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) +{ + struct lp8x4x_slot *s = container_of(dev, struct lp8x4x_slot, dev); + + if (!buf) + return count; + if (0 == count) + return count; + + if (kstrtouint(buf, 16, &s->DO) != 0) { + dev_err(dev, "bad input\n"); + return count; + } + + lp8x4x_slot_set_DO(s); + + return count; +} + +static DEVICE_ATTR_RW(output_status); + static ssize_t model_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -107,6 +149,13 @@ static struct attribute *slot_dev_attrs[] = { }; ATTRIBUTE_GROUPS(slot_dev); +static struct attribute *do_slot_dev_attrs[] = { + &dev_attr_model.attr, + &dev_attr_output_status.attr, + NULL, +}; +ATTRIBUTE_GROUPS(do_slot_dev); + static void lp8x4x_master_release(struct device *dev) { struct lp8x4x_master *m = container_of(dev, struct lp8x4x_master, dev); @@ -242,8 +291,10 @@ static void devm_lp8x4x_bus_release(struct device *dev, void *res) dev_dbg(dev, "releasing devices\n"); for (i = 0; i < LP8X4X_MAX_SLOT_COUNT; i++) { s = &m->slot[i]; - if (s->model) + if (s->model) { device_unregister(&s->dev); + mutex_destroy(&s->lock); + } } device_unregister(&m->dev); bus_unregister(&lp8x4x_bus_type); @@ -261,13 +312,25 @@ static void __init lp8x4x_bus_probe_slot(struct lp8x4x_master *m, int i, dev_set_name(&s->dev, "slot%02i", i + 1); s->dev.parent = &m->dev; s->dev.release = lp8x4x_slot_release; - s->dev.groups = slot_dev_groups; s->model = model; + mutex_init(&s->lock); + + switch (model) { + case 41: + s->DO_len = 4; + lp8x4x_slot_set_DO(s); + s->dev.groups = do_slot_dev_groups; + break; + default: + s->dev.groups = slot_dev_groups; + break; + }; err = device_register(&s->dev); if (err < 0) { dev_err(&s->dev, "failed to register device\n"); s->model = 0; + mutex_destroy(&s->lock); return; } }