From patchwork Wed Apr 16 17:17:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Yanovich X-Patchwork-Id: 4003401 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E6BA29F2CC for ; Wed, 16 Apr 2014 17:29:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 080A420377 for ; Wed, 16 Apr 2014 17:29:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F183201DE for ; Wed, 16 Apr 2014 17:29:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WaTXi-0005p8-8m; Wed, 16 Apr 2014 17:22:38 +0000 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WaTVQ-0007uX-QE for linux-arm-kernel@lists.infradead.org; Wed, 16 Apr 2014 17:20:17 +0000 Received: by mail-lb0-f180.google.com with SMTP id 10so8240429lbg.39 for ; Wed, 16 Apr 2014 10:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Uxj9oqUx/nI2N6LKDH8/z8BN/9n8T8UfAzwLyPZ49D0=; b=iwS+iIEvuIl8BeE1mrW4G2fAHf4QoQHk3dKJ6W0ogOyxP+7rVbrXcdsinqfKJ4+m2j jIFlB8tvzH8Xk2TSrFGJvAT9t23qYxldgXPhN8QiZE+Kt8BDAdBS7aohEyK2WWYSBuK3 f9CvPwaSuKcbdZ7rSI1lUVOkhYf0+NTXtb/MlDyLiqzjmZwpnhYc/cblDgQSCIg5q28S t8PVGz00XRtAtdg518G/flxui3KPPKhTikjUB5nN0mXRCMQtCnNGgk5quganskHAyuyo guzSgXRwoW1w4H/nBDFxo+l3zpytf54STWznmrD3yl5O/esov85BVerJZTbWRqHvXIli wUuQ== X-Received: by 10.112.126.7 with SMTP id mu7mr3581536lbb.17.1397668793456; Wed, 16 Apr 2014 10:19:53 -0700 (PDT) Received: from host5.omatika.ru (0893675324.static.corbina.ru. [95.31.1.192]) by mx.google.com with ESMTPSA id q4sm21186297lbh.20.2014.04.16.10.19.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Apr 2014 10:19:52 -0700 (PDT) From: Sergei Ianovich To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 20/21] misc: support for I-8042 in LP-8x4x Date: Wed, 16 Apr 2014 21:17:25 +0400 Message-Id: <1397668667-27328-14-git-send-email-ynvich@gmail.com> X-Mailer: git-send-email 1.9.2 In-Reply-To: <1397668667-27328-1-git-send-email-ynvich@gmail.com> References: <1397668411-27162-7-git-send-email-ynvich@gmail.com> <1397668667-27328-1-git-send-email-ynvich@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140416_102017_057392_98C90AFF X-CRM114-Status: GOOD ( 19.88 ) X-Spam-Score: -0.1 (/) Cc: Sergei Ianovich , Greg Kroah-Hartman , Randy Dunlap , Arnd Bergmann , "open list:DOCUMENTATION" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Status of I-8042 16 digital output channels can be managed via sysfs. Status of I-8042 16 digital input channels can be read via sysfs. http://www.icpdas.com/products/Remote_IO/i-8ke/i-8042w.htm Signed-off-by: Sergei Ianovich --- v3..v4 v2..v3 v0..v2 * no changes (except number 15/16 -> 20/21) Documentation/misc-devices/lp8x4x_bus.txt | 4 ++ drivers/misc/lp8x4x_bus.c | 76 ++++++++++++++++++++++++++++++- 2 files changed, 78 insertions(+), 2 deletions(-) diff --git a/Documentation/misc-devices/lp8x4x_bus.txt b/Documentation/misc-devices/lp8x4x_bus.txt index 68fefde..3ea257d 100644 --- a/Documentation/misc-devices/lp8x4x_bus.txt +++ b/Documentation/misc-devices/lp8x4x_bus.txt @@ -59,6 +59,10 @@ slot_count model RO - shows expansion module model number +input_status + RO - get status of digital input channels on the module in + the expansion slot. + output_status RW - set status of digital output channels on the module in the expansion slot. Value can be read back. diff --git a/drivers/misc/lp8x4x_bus.c b/drivers/misc/lp8x4x_bus.c index 5af788d..3fb227d 100644 --- a/drivers/misc/lp8x4x_bus.c +++ b/drivers/misc/lp8x4x_bus.c @@ -29,6 +29,8 @@ struct lp8x4x_slot { struct mutex lock; unsigned int DO_len; u32 DO; + unsigned int DI_len; + u32 DI; struct device dev; }; @@ -94,6 +96,21 @@ static void lp8x4x_slot_release(struct device *dev) { } +static void lp8x4x_slot_get_DI(struct lp8x4x_slot *s) +{ + int i; + u32 b; + + mutex_lock(&s->lock); + s->DI = 0; + for (i = 0; i < s->DI_len; i++) { + b = ioread8(s->data_addr + 2 * (i + 1)); + b ^= 0xff; + s->DI += b << (i * 8); + } + mutex_unlock(&s->lock); +} + static void lp8x4x_slot_set_DO(struct lp8x4x_slot *s) { int i; @@ -103,29 +120,70 @@ static void lp8x4x_slot_set_DO(struct lp8x4x_slot *s) mutex_unlock(&s->lock); } +static ssize_t input_status_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct lp8x4x_slot *s = container_of(dev, struct lp8x4x_slot, dev); + + lp8x4x_slot_get_DI(s); + switch (s->DI_len) { + case 4: + return sprintf(buf, "0x%08x\n", s->DI); + case 2: + return sprintf(buf, "0x%04x\n", s->DI); + case 1: + return sprintf(buf, "0x%02x\n", s->DI); + default: + break; + } + return sprintf(buf, "0x%x\n", s->DI); +} + +static DEVICE_ATTR_RO(input_status); + static ssize_t output_status_show(struct device *dev, struct device_attribute *attr, char *buf) { struct lp8x4x_slot *s = container_of(dev, struct lp8x4x_slot, dev); - return sprintf(buf, "0x%08x\n", s->DO); + switch (s->DO_len) { + case 4: + return sprintf(buf, "0x%08x\n", s->DO); + case 2: + return sprintf(buf, "0x%04x\n", s->DO); + case 1: + return sprintf(buf, "0x%02x\n", s->DO); + default: + break; + } + return sprintf(buf, "0x%x\n", s->DO); } static ssize_t output_status_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { struct lp8x4x_slot *s = container_of(dev, struct lp8x4x_slot, dev); + u32 DO; + u8 *b = (void *) &DO; + int i; if (!buf) return count; if (0 == count) return count; - if (kstrtouint(buf, 16, &s->DO) != 0) { + if (kstrtouint(buf, 16, &DO) != 0) { dev_err(dev, "bad input\n"); return count; } + for (i = 4; i > s->DO_len; i--) + if (b[i - 1] != 0) { + dev_err(dev, "bad input\n"); + return count; + } + + s->DO = DO; lp8x4x_slot_set_DO(s); return count; @@ -156,6 +214,14 @@ static struct attribute *do_slot_dev_attrs[] = { }; ATTRIBUTE_GROUPS(do_slot_dev); +static struct attribute *dio_slot_dev_attrs[] = { + &dev_attr_model.attr, + &dev_attr_output_status.attr, + &dev_attr_input_status.attr, + NULL, +}; +ATTRIBUTE_GROUPS(dio_slot_dev); + static void lp8x4x_master_release(struct device *dev) { struct lp8x4x_master *m = container_of(dev, struct lp8x4x_master, dev); @@ -321,6 +387,12 @@ static void __init lp8x4x_bus_probe_slot(struct lp8x4x_master *m, int i, lp8x4x_slot_set_DO(s); s->dev.groups = do_slot_dev_groups; break; + case 42: + s->DI_len = 2; + s->DO_len = 2; + lp8x4x_slot_set_DO(s); + s->dev.groups = dio_slot_dev_groups; + break; default: s->dev.groups = slot_dev_groups; break;