From patchwork Fri Apr 18 02:20:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 4012751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A19CABFF02 for ; Fri, 18 Apr 2014 02:24:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDF4820328 for ; Fri, 18 Apr 2014 02:24:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC1E8202EB for ; Fri, 18 Apr 2014 02:24:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WayQF-00031m-2p; Fri, 18 Apr 2014 02:20:59 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WayQB-00030P-Qf for linux-arm-kernel@lists.infradead.org; Fri, 18 Apr 2014 02:20:57 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N47003VXFU8LB10@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 18 Apr 2014 11:20:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.112]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id D1.E7.14803.0FB80535; Fri, 18 Apr 2014 11:20:32 +0900 (KST) X-AuditID: cbfee691-b7efc6d0000039d3-46-53508bf0dc9a Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A1.89.29263.0FB80535; Fri, 18 Apr 2014 11:20:32 +0900 (KST) Received: from chan.10.32.193.11 ([10.252.81.195]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4700JRSFU7YK20@mmp1.samsung.com>; Fri, 18 Apr 2014 11:20:32 +0900 (KST) From: Chanwoo Choi To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH 1/2] cpufreq: exynos: Use dev_err/info function instead of pr_err/info Date: Fri, 18 Apr 2014 11:20:33 +0900 Message-id: <1397787634-9334-2-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1397787634-9334-1-git-send-email-cw00.choi@samsung.com> References: <1397787634-9334-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42JZI2JSoPuhOyDYYNVKS4unTT/YLa5/ec5q 0bvgKpvF2aY37BabHl9jtbi8aw6bxefeI4wWM87vY7I4c/oSq8XGrx4OXB53ru1h89i8pN5j y9V2Fo++LasYPT5vkgtgjeKySUnNySxLLdK3S+DKmHHiHGPBVJmKG5dvMjcw/hDrYuTkkBAw kZg//Q8rhC0mceHeerYuRi4OIYGljBLLz69mgym6cGU+K0RiEaPEm/Zd7BBOE5PEqomHWECq 2AS0JPa/uAHUwcEhIqAn8fdzLUgNs8AvRonJfXPAVggLREjc2twHVs8ioCpxf/I+MJtXwEWi d/lrqDPkJD7secQOYnMKuEqcanvFDGILAdW8P7KSEaJmE7vEhO44iDkCEt8mg9zAARSXldh0 gBmiRFLi4IobLBMYhRcwMqxiFE0tSC4oTkovMtUrTswtLs1L10vOz93ECIyA0/+eTdzBeP+A 9SHGZKBxE5mlRJPzgRGUVxJvaGxmZGFqYmpsZG5pRpqwkjhv+qOkICGB9MSS1OzU1ILUovii 0pzU4kOMTBycUg2M+vyhggK7N29xyw581fmuMf7W5rj1GZMkcz/fK+9wqff6U7Cz8fkUGRNJ xSmFlz/vOnyMPe1Gvfj0378evNo3sezwtw5fnlm594M+7wjpyFOfzK19am363O9yD38x2Uw4 Zl4mm3toxr+AzgmcjU8tTJjcWJ9NybYxT+pRaJiWd9/I4XEYX5CoEktxRqKhFnNRcSIAawV0 spYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAd0P3QHBBs3/9S2eNv1gt7j+5Tmr Re+Cq2wWZ5vesFtsenyN1eLyrjlsFp97jzBazDi/j8nizOlLrBYbv3o4cHncubaHzWPzknqP LVfbWTz6tqxi9Pi8SS6ANaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEv MTfVVsnFJ0DXLTMH6CglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8aM E+cYC6bKVNy4fJO5gfGHWBcjJ4eEgInEhSvzWSFsMYkL99azdTFycQgJLGKUeNO+ix3CaWKS WDXxEAtIFZuAlsT+FzeAqjg4RAT0JP5+rgWpYRb4xSgxuW8O2CRhgQiJW5v7wOpZBFQl7k/e B2bzCrhI9C5/DbVNTuLDnkfsIDangKvEqbZXzCC2EFDN+yMrGScw8i5gZFjFKJpakFxQnJSe a6hXnJhbXJqXrpecn7uJERxhz6R2MK5ssDjEKMDBqMTDK6AXECzEmlhWXJl7iFGCg1lJhFe5 FCjEm5JYWZValB9fVJqTWnyIMRnoqonMUqLJ+cDozyuJNzQ2MTOyNDI3tDAyNidNWEmc90Cr daCQQHpiSWp2ampBahHMFiYOTqkGRjVf2zvTls3OEE7cyNM899TyN7eS6+qyGxzmXLo/L+Db zcVzDrutWzjvkNuzzI26dxeWqTGc656SWVroe/7nf6viXG3t2twIq+B1NZMY1JevEf8TxqWz w7rGmdNVeemrp4KvHL5VnTR+N4lLN2u59MkwxRWqc75vDA2oeHj5mUvTSdH61efSriixFGck GmoxFxUnAgD6BJ5g9AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140417_192056_028804_1BD7BA5C X-CRM114-Status: GOOD ( 13.77 ) X-Spam-Score: -5.7 (-----) Cc: kgene.kim@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch uses dev_err/info function to show accurate log message with device name instead of pr_err/info function. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Acked-by: Viresh Kumar --- drivers/cpufreq/exynos-cpufreq.c | 21 ++++++++++++--------- drivers/cpufreq/exynos-cpufreq.h | 1 + 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index f99cfe2..8b4bb4a 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -49,6 +49,7 @@ static int exynos_cpufreq_scale(unsigned int target_freq) struct cpufreq_policy *policy = cpufreq_cpu_get(0); unsigned int arm_volt, safe_arm_volt = 0; unsigned int mpll_freq_khz = exynos_info->mpll_freq_khz; + struct device *dev = exynos_info->dev; unsigned int old_freq; int index, old_index; int ret = 0; @@ -90,8 +91,8 @@ static int exynos_cpufreq_scale(unsigned int target_freq) /* Firstly, voltage up to increase frequency */ ret = regulator_set_voltage(arm_regulator, arm_volt, arm_volt); if (ret) { - pr_err("%s: failed to set cpu voltage to %d\n", - __func__, arm_volt); + dev_err(dev, "failed to set cpu voltage to %d\n", + arm_volt); return ret; } } @@ -100,8 +101,8 @@ static int exynos_cpufreq_scale(unsigned int target_freq) ret = regulator_set_voltage(arm_regulator, safe_arm_volt, safe_arm_volt); if (ret) { - pr_err("%s: failed to set cpu voltage to %d\n", - __func__, safe_arm_volt); + dev_err(dev, "failed to set cpu voltage to %d\n", + safe_arm_volt); return ret; } } @@ -115,8 +116,8 @@ static int exynos_cpufreq_scale(unsigned int target_freq) ret = regulator_set_voltage(arm_regulator, arm_volt, arm_volt); if (ret) { - pr_err("%s: failed to set cpu voltage to %d\n", - __func__, arm_volt); + dev_err(dev, "failed to set cpu voltage to %d\n", + arm_volt); goto out; } } @@ -163,6 +164,8 @@ static int exynos_cpufreq_probe(struct platform_device *pdev) if (!exynos_info) return -ENOMEM; + exynos_info->dev = &pdev->dev; + if (soc_is_exynos4210()) ret = exynos4210_cpufreq_init(exynos_info); else if (soc_is_exynos4212() || soc_is_exynos4412()) @@ -176,13 +179,13 @@ static int exynos_cpufreq_probe(struct platform_device *pdev) goto err_vdd_arm; if (exynos_info->set_freq == NULL) { - pr_err("%s: No set_freq function (ERR)\n", __func__); + dev_err(&pdev->dev, "No set_freq function (ERR)\n"); goto err_vdd_arm; } arm_regulator = regulator_get(NULL, "vdd_arm"); if (IS_ERR(arm_regulator)) { - pr_err("%s: failed to get resource vdd_arm\n", __func__); + dev_err(&pdev->dev, "failed to get resource vdd_arm\n"); goto err_vdd_arm; } @@ -192,7 +195,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev) if (!cpufreq_register_driver(&exynos_driver)) return 0; - pr_err("%s: failed to register cpufreq driver\n", __func__); + dev_err(&pdev->dev, "failed to register cpufreq driver\n"); regulator_put(arm_regulator); err_vdd_arm: kfree(exynos_info); diff --git a/drivers/cpufreq/exynos-cpufreq.h b/drivers/cpufreq/exynos-cpufreq.h index 3ddade8..b72ff10 100644 --- a/drivers/cpufreq/exynos-cpufreq.h +++ b/drivers/cpufreq/exynos-cpufreq.h @@ -34,6 +34,7 @@ struct apll_freq { }; struct exynos_dvfs_info { + struct device *dev; unsigned long mpll_freq_khz; unsigned int pll_safe_idx; struct clk *cpu_clk;