Message ID | 1399374094-32451-1-git-send-email-s.hauer@pengutronix.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi, Sascha Hauer wrote: > The IPU register space is 128MB, not 2GB. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm/boot/dts/imx53.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > index 9c2bff2..6a1bf4f 100644 > --- a/arch/arm/boot/dts/imx53.dtsi > +++ b/arch/arm/boot/dts/imx53.dtsi > @@ -115,7 +115,7 @@ > #address-cells = <1>; > #size-cells = <0>; > compatible = "fsl,imx53-ipu"; > - reg = <0x18000000 0x080000000>; > + reg = <0x18000000 0x08000000>; > IMO this should be either 0x00800000 or 0x800000 while I prefer the first notation. Lothar Waßmann
On Tue, May 06, 2014 at 01:49:43PM +0200, Lothar Waßmann wrote: > Hi, > > Sascha Hauer wrote: > > The IPU register space is 128MB, not 2GB. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > arch/arm/boot/dts/imx53.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > > index 9c2bff2..6a1bf4f 100644 > > --- a/arch/arm/boot/dts/imx53.dtsi > > +++ b/arch/arm/boot/dts/imx53.dtsi > > @@ -115,7 +115,7 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > compatible = "fsl,imx53-ipu"; > > - reg = <0x18000000 0x080000000>; > > + reg = <0x18000000 0x08000000>; > > > IMO this should be either 0x00800000 or 0x800000 > while I prefer the first notation. Look again, the original size is 9 digits wide: 0x0_8000_0000. I changed this to 0x_08000_0000 which is 8 digits wide. Sascha
On Tue, May 06, 2014 at 02:00:02PM +0200, Sascha Hauer wrote: > On Tue, May 06, 2014 at 01:49:43PM +0200, Lothar Waßmann wrote: > > Hi, > > > > Sascha Hauer wrote: > > > The IPU register space is 128MB, not 2GB. > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > --- > > > arch/arm/boot/dts/imx53.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > > > index 9c2bff2..6a1bf4f 100644 > > > --- a/arch/arm/boot/dts/imx53.dtsi > > > +++ b/arch/arm/boot/dts/imx53.dtsi > > > @@ -115,7 +115,7 @@ > > > #address-cells = <1>; > > > #size-cells = <0>; > > > compatible = "fsl,imx53-ipu"; > > > - reg = <0x18000000 0x080000000>; > > > + reg = <0x18000000 0x08000000>; > > > > > IMO this should be either 0x00800000 or 0x800000 > > while I prefer the first notation. > > Look again, the original size is 9 digits wide: 0x0_8000_0000. I > changed this to 0x_08000_0000 which is 8 digits wide. Argh. I meant 0x_0800_0000 Sascha
On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote: > The IPU register space is 128MB, not 2GB. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Acked-by: Shawn Guo <shawn.guo@freescale.com> Arnd, Olof, Please apply this fix for 3.15, and copy stable. Thanks. Cc: <stable@vger.kernel.org> Shawn > --- > arch/arm/boot/dts/imx53.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > index 9c2bff2..6a1bf4f 100644 > --- a/arch/arm/boot/dts/imx53.dtsi > +++ b/arch/arm/boot/dts/imx53.dtsi > @@ -115,7 +115,7 @@ > #address-cells = <1>; > #size-cells = <0>; > compatible = "fsl,imx53-ipu"; > - reg = <0x18000000 0x080000000>; > + reg = <0x18000000 0x08000000>; > interrupts = <11 10>; > clocks = <&clks IMX5_CLK_IPU_GATE>, > <&clks IMX5_CLK_IPU_DI0_GATE>, > -- > 2.0.0.rc0 >
On Tue, May 06, 2014 at 08:58:04PM +0800, Shawn Guo wrote: > On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote: > > The IPU register space is 128MB, not 2GB. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Acked-by: Shawn Guo <shawn.guo@freescale.com> > > Arnd, Olof, > > Please apply this fix for 3.15, and copy stable. Thanks. > > Cc: <stable@vger.kernel.org> > Applied, but in the future please resend the whole patch since we just get this acked-by email in the arm@kernel.org mailboxes and have to hunt around for the original patch. Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch subject>' would be useful, so that stable knows how far to backport. I added it this time as well, feel free to do it yourself next time :) -Olof
On Sat, May 10, 2014 at 08:20:39PM -0700, Olof Johansson wrote: > On Tue, May 06, 2014 at 08:58:04PM +0800, Shawn Guo wrote: > > On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote: > > > The IPU register space is 128MB, not 2GB. > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > Acked-by: Shawn Guo <shawn.guo@freescale.com> > > > > Arnd, Olof, > > > > Please apply this fix for 3.15, and copy stable. Thanks. > > > > Cc: <stable@vger.kernel.org> > > > > Applied, but in the future please resend the whole patch since we just > get this acked-by email in the arm@kernel.org mailboxes and have to hunt > around for the original patch. > > Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch > subject>' would be useful, so that stable knows how far to backport. I added it > this time as well, feel free to do it yourself next time :) Noted. Thanks, Olof. Shawn
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index 9c2bff2..6a1bf4f 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -115,7 +115,7 @@ #address-cells = <1>; #size-cells = <0>; compatible = "fsl,imx53-ipu"; - reg = <0x18000000 0x080000000>; + reg = <0x18000000 0x08000000>; interrupts = <11 10>; clocks = <&clks IMX5_CLK_IPU_GATE>, <&clks IMX5_CLK_IPU_DI0_GATE>,
The IPU register space is 128MB, not 2GB. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- arch/arm/boot/dts/imx53.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)