diff mbox

[1/6] ARM: dts: i.MX25: Add mmc aliases

Message ID 1399469489-22788-2-git-send-email-s.hauer@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Sascha Hauer May 7, 2014, 1:31 p.m. UTC 
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/boot/dts/imx25.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Fabio Estevam May 7, 2014, 2:46 p.m. UTC | #1 
On Wed, May 7, 2014 at 10:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx25.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index ea323f0..680486a 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -21,6 +21,8 @@
>                 i2c0 = &i2c1;
>                 i2c1 = &i2c2;
>                 i2c2 = &i2c3;
> +               mmc0 = &esdhc1;
> +               mmc2 = &esdhc2;

Shouldn't this be:
                   mmc1 = &esdhc2;

instead?
Sascha Hauer May 8, 2014, 8:04 a.m. UTC | #2 
On Wed, May 07, 2014 at 11:46:19AM -0300, Fabio Estevam wrote:
> On Wed, May 7, 2014 at 10:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx25.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> > index ea323f0..680486a 100644
> > --- a/arch/arm/boot/dts/imx25.dtsi
> > +++ b/arch/arm/boot/dts/imx25.dtsi
> > @@ -21,6 +21,8 @@
> >                 i2c0 = &i2c1;
> >                 i2c1 = &i2c2;
> >                 i2c2 = &i2c3;
> > +               mmc0 = &esdhc1;
> > +               mmc2 = &esdhc2;
> 
> Shouldn't this be:
>                    mmc1 = &esdhc2;
> 
> instead?

Yes, sure.

Shawn, Lothar, is this series otherwise ok?

Sascha
Shawn Guo May 8, 2014, 8:24 a.m. UTC | #3 
On Thu, May 08, 2014 at 10:04:02AM +0200, Sascha Hauer wrote:
> On Wed, May 07, 2014 at 11:46:19AM -0300, Fabio Estevam wrote:
> > On Wed, May 7, 2014 at 10:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > >  arch/arm/boot/dts/imx25.dtsi | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> > > index ea323f0..680486a 100644
> > > --- a/arch/arm/boot/dts/imx25.dtsi
> > > +++ b/arch/arm/boot/dts/imx25.dtsi
> > > @@ -21,6 +21,8 @@
> > >                 i2c0 = &i2c1;
> > >                 i2c1 = &i2c2;
> > >                 i2c2 = &i2c3;
> > > +               mmc0 = &esdhc1;
> > > +               mmc2 = &esdhc2;
> > 
> > Shouldn't this be:
> >                    mmc1 = &esdhc2;
> > 
> > instead?
> 
> Yes, sure.
> 
> Shawn, Lothar, is this series otherwise ok?

I'm fine with the series, and can fix above typo, if this is the only
comment from people.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index ea323f0..680486a 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -21,6 +21,8 @@ 
 		i2c0 = &i2c1;
 		i2c1 = &i2c2;
 		i2c2 = &i2c3;
+		mmc0 = &esdhc1;
+		mmc2 = &esdhc2;
 		serial0 = &uart1;
 		serial1 = &uart2;
 		serial2 = &uart3;