| Message ID | 1399469489-22788-6-git-send-email-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > arch/arm/boot/dts/imx25-karo-tx25.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25-karo-tx25.dts b/arch/arm/boot/dts/imx25-karo-tx25.dts > index aeb1fce..ea7dddc 100644 > --- a/arch/arm/boot/dts/imx25-karo-tx25.dts > +++ b/arch/arm/boot/dts/imx25-karo-tx25.dts > @@ -16,6 +16,21 @@ > model = "Ka-Ro TX25"; > compatible = "karo,imx25-tx25", "fsl,imx25"; > > + regulators { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg_fec_phy: regulator@0 { > + compatible = "regulator-fixed"; > + reg = <0>; > + regulator-name = "fec-phy"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio4 9 0>; > enable-active-high; missing here. > + }; > + }; > + > memory { > reg = <0x80000000 0x02000000 0x90000000 0x02000000>; > }; > @@ -77,7 +92,9 @@ > &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_fec>; > + phy-reset-gpios = <&gpio4 7 0>; > This must be: <&gpio3 7 0>; Lothar Waßmann
Hi Lothar, On Thu, May 08, 2014 at 02:27:42PM +0200, Lothar Waßmann wrote: > Hi, > > Sascha Hauer wrote: > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > arch/arm/boot/dts/imx25-karo-tx25.dts | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx25-karo-tx25.dts b/arch/arm/boot/dts/imx25-karo-tx25.dts > > index aeb1fce..ea7dddc 100644 > > --- a/arch/arm/boot/dts/imx25-karo-tx25.dts > > +++ b/arch/arm/boot/dts/imx25-karo-tx25.dts > > @@ -16,6 +16,21 @@ > > model = "Ka-Ro TX25"; > > compatible = "karo,imx25-tx25", "fsl,imx25"; > > > > + regulators { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reg_fec_phy: regulator@0 { > > + compatible = "regulator-fixed"; > > + reg = <0>; > > + regulator-name = "fec-phy"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio4 9 0>; > > > enable-active-high; > missing here. > > > + }; > > + }; > > + > > memory { > > reg = <0x80000000 0x02000000 0x90000000 0x02000000>; > > }; > > @@ -77,7 +92,9 @@ > > &fec { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_fec>; > > + phy-reset-gpios = <&gpio4 7 0>; > > > This must be: <&gpio3 7 0>; Thanks for reviewing. The second round is out. Sascha
diff --git a/arch/arm/boot/dts/imx25-karo-tx25.dts b/arch/arm/boot/dts/imx25-karo-tx25.dts index aeb1fce..ea7dddc 100644 --- a/arch/arm/boot/dts/imx25-karo-tx25.dts +++ b/arch/arm/boot/dts/imx25-karo-tx25.dts @@ -16,6 +16,21 @@ model = "Ka-Ro TX25"; compatible = "karo,imx25-tx25", "fsl,imx25"; + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + reg_fec_phy: regulator@0 { + compatible = "regulator-fixed"; + reg = <0>; + regulator-name = "fec-phy"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio4 9 0>; + }; + }; + memory { reg = <0x80000000 0x02000000 0x90000000 0x02000000>; }; @@ -77,7 +92,9 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec>; + phy-reset-gpios = <&gpio4 7 0>; phy-mode = "rmii"; + phy-supply = <®_fec_phy>; status = "okay"; };
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- arch/arm/boot/dts/imx25-karo-tx25.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)