| Message ID | 1399560990-1402858-8-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 08, 2014 at 04:56:19PM +0200, Arnd Bergmann wrote: > All three iop variants we support in Linux (iop32x, iop33x and > iop13xx) seem to have support for the watchdog hardware, but this > driver fails to build for the first two of these because it > uses the IOP13XX_WDTCR_IB_RESET macro that is only defined for > iop13xx. > > This clarifies the dependency in Kconfig to avoid randconfig > build errors. It is unlikely that anyone will ever miss support > for this driver on the ancient iop3xx platforms, so we don't > need to bother trying to fix it properly. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Wim Van Sebroeck <wim@iguana.be> > Cc: linux-watchdog@vger.kernel.org Reviewed-by: Guenter Roeck <linux@roeck-us.net>
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 2b4c1fc..e244548 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -272,7 +272,7 @@ config PNX4008_WATCHDOG config IOP_WATCHDOG tristate "IOP Watchdog" - depends on PLAT_IOP + depends on ARCH_IOP13XX select WATCHDOG_NOWAYOUT if (ARCH_IOP32X || ARCH_IOP33X) help Say Y here if to include support for the watchdog timer
All three iop variants we support in Linux (iop32x, iop33x and iop13xx) seem to have support for the watchdog hardware, but this driver fails to build for the first two of these because it uses the IOP13XX_WDTCR_IB_RESET macro that is only defined for iop13xx. This clarifies the dependency in Kconfig to avoid randconfig build errors. It is unlikely that anyone will ever miss support for this driver on the ancient iop3xx platforms, so we don't need to bother trying to fix it properly. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Wim Van Sebroeck <wim@iguana.be> Cc: linux-watchdog@vger.kernel.org --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)