From patchwork Tue May 13 00:29:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 4161851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 20A89C0ACC for ; Tue, 13 May 2014 00:39:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 527FD202B4 for ; Tue, 13 May 2014 00:39:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5231D202FF for ; Tue, 13 May 2014 00:39:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wk0j7-0000wI-1L; Tue, 13 May 2014 00:37:49 +0000 Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wk0j3-0007sl-Qk for linux-arm-kernel@lists.infradead.org; Tue, 13 May 2014 00:37:46 +0000 Received: by mail-oa0-f51.google.com with SMTP id n16so9215673oag.10 for ; Mon, 12 May 2014 17:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1O7uyIptpMSLYy69nLe2uhEi2cG+63I15bjQlGCc1fs=; b=XZfSOI1PclnXkgxYekwcaBtLFjQyQ/39LUEhL0gtSRdv33+SKWtQ0MAkRb2oWbhP0d eh4ytSoRcSAmjLYOP5oz3RmGsnvptIQTQLJ9lmBTDBjdib8qy/GU5MtJ1bdnsZ9hp4i/ UyBKkAwmFnNwSa0+op+MZR8Qo8MkJ15xcLaLkSd7OGENZrCPK4ZmKT5GjLtRiKrc0gre dGfz2Ae6qehVww/Dg5qJLXDUUAfetexChkjHCG55NvWbVdSnkTPDzAYQi12iHj/j6wA1 T7gjSTVs7RmrGkIZ97hg6gH3aO7JasXkbf082fp9QN0oVVCHhSHfRsFJ4RL0Vy39wANJ fCxg== X-Received: by 10.60.37.199 with SMTP id a7mr38672220oek.41.1399941017684; Mon, 12 May 2014 17:30:17 -0700 (PDT) Received: from localhost.localdomain (72-48-77-163.dyn.grandenetworks.net. [72.48.77.163]) by mx.google.com with ESMTPSA id ml9sm54101053oeb.2.2014.05.12.17.30.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 May 2014 17:30:16 -0700 (PDT) From: Rob Herring To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/7] irqchip: mxs: fix function type for IRQCHIP_OF_DECLARE Date: Mon, 12 May 2014 19:29:52 -0500 Message-Id: <1399940993-1773-7-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399940993-1773-1-git-send-email-robherring2@gmail.com> References: <1399940993-1773-1-git-send-email-robherring2@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140512_173745_946751_1EC8D21C X-CRM114-Status: GOOD ( 11.59 ) X-Spam-Score: 0.1 (/) Cc: Rob Herring , Thomas Gleixner X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rob Herring Adding function type checking to IRQCHIP_OF_DECLARE found a type mismatch with icoll_of_init. The function should return an error code or 0 on success. Signed-off-by: Rob Herring Cc: Thomas Gleixner --- drivers/irqchip/irq-mxs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c index 63b3d4e..4044ff2 100644 --- a/drivers/irqchip/irq-mxs.c +++ b/drivers/irqchip/irq-mxs.c @@ -96,7 +96,7 @@ static struct irq_domain_ops icoll_irq_domain_ops = { .xlate = irq_domain_xlate_onecell, }; -static void __init icoll_of_init(struct device_node *np, +static int __init icoll_of_init(struct device_node *np, struct device_node *interrupt_parent) { icoll_base = of_iomap(np, 0); @@ -110,6 +110,6 @@ static void __init icoll_of_init(struct device_node *np, icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS, &icoll_irq_domain_ops, NULL); - WARN_ON(!icoll_domain); + return icoll_domain ? 0 : -ENODEV; } IRQCHIP_DECLARE(mxs, "fsl,icoll", icoll_of_init);