diff mbox

[RFC,08/10] ARM: tegra124: Bind CAR to syscon device

Message ID 1400113986-339-9-git-send-email-abrestic@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Bresticker May 15, 2014, 12:33 a.m. UTC
The XUSB PHY driver will be accessing the CAR registers through the
syscon interface.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
 arch/arm/boot/dts/tegra124.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Warren May 15, 2014, 7:25 p.m. UTC | #1
On 05/14/2014 06:33 PM, Andrew Bresticker wrote:
> The XUSB PHY driver will be accessing the CAR registers through the
> syscon interface.

I very strongly don't want to use the syscon concept on Tegra. Instead,
I want only the CAR driver touching the CAR registers. If other drivers
need some CAR registers manipulated, that should happen by that other
driver calling some explicit semantic API in the CAR driver to do so.
Take a look at how the Tegra SMMU and Tegra AHB driver communicate for
an example.
Andrew Bresticker May 15, 2014, 8:22 p.m. UTC | #2
On Thu, May 15, 2014 at 12:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 05/14/2014 06:33 PM, Andrew Bresticker wrote:
>> The XUSB PHY driver will be accessing the CAR registers through the
>> syscon interface.
>
> I very strongly don't want to use the syscon concept on Tegra. Instead,
> I want only the CAR driver touching the CAR registers. If other drivers
> need some CAR registers manipulated, that should happen by that other
> driver calling some explicit semantic API in the CAR driver to do so.
> Take a look at how the Tegra SMMU and Tegra AHB driver communicate for
> an example.

Understood.  I'll fix that up for the next spin.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 197e848..47fb61c 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -115,7 +115,7 @@ 
 	};
 
 	tegra_car: clock@0,60006000 {
-		compatible = "nvidia,tegra124-car";
+		compatible = "nvidia,tegra124-car", "syscon";
 		reg = <0x0 0x60006000 0x0 0x1000>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;