From patchwork Fri May 16 12:29:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 4190891 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EC08EBFF02 for ; Fri, 16 May 2014 12:31:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2A3C7201F7 for ; Fri, 16 May 2014 12:31:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A058201BC for ; Fri, 16 May 2014 12:31:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WlHGe-0002MO-G7; Fri, 16 May 2014 12:29:40 +0000 Received: from cpsmtpb-ews08.kpnxchange.com ([213.75.39.13]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WlHGb-0002Hn-Ok for linux-arm-kernel@lists.infradead.org; Fri, 16 May 2014 12:29:38 +0000 Received: from cpsps-ews28.kpnxchange.com ([10.94.84.194]) by cpsmtpb-ews08.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Fri, 16 May 2014 14:29:16 +0200 Received: from CPSMTPM-TLF104.kpnxchange.com ([195.121.3.7]) by cpsps-ews28.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Fri, 16 May 2014 14:29:16 +0200 Received: from [192.168.10.106] ([195.240.213.44]) by CPSMTPM-TLF104.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Fri, 16 May 2014 14:29:15 +0200 Message-ID: <1400243355.20342.43.camel@x220> Subject: [PATCH] ARM: S3C24XX: check for 'CONFIG_SND_SOC_SAMSUNG_SMDK2443_WM9710' From: Paul Bolle To: Ben Dooks , Kukjin Kim , Russell King Date: Fri, 16 May 2014 14:29:15 +0200 X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 X-OriginalArrivalTime: 16 May 2014 12:29:16.0021 (UTC) FILETIME=[73976A50:01CF7102] X-RcptDomain: lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140516_052937_966993_F48B7086 X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since v2.6.34 there are two checks for CONFIG_SND_SOC_SMDK2443_WM9710. But a Kconfig symbol SND_SOC_SMDK2443_WM9710 has never been part of the tree. However, in v2.6.38 a symbol SND_SOC_SAMSUNG_SMDK2443_WM9710 was added, so it seems these checks should be for its macro. But the second check is a guard for s3c24xx_ac97_setup_gpio(S3C24XX_AC97_GPE0); And since neither s3c24xx_ac97_setup_gpio nor S3C24XX_AC97_GPE0 are defined anywhere, that second check can be dropped entirely. Signed-off-by: Paul Bolle --- Tested with git grep. Needs further testing, obviously. arch/arm/mach-s3c24xx/mach-smdk2443.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-smdk2443.c b/arch/arm/mach-s3c24xx/mach-smdk2443.c index 06c4d77de3a5..ce842189bc64 100644 --- a/arch/arm/mach-s3c24xx/mach-smdk2443.c +++ b/arch/arm/mach-s3c24xx/mach-smdk2443.c @@ -112,7 +112,7 @@ static struct platform_device *smdk2443_devices[] __initdata = { &s3c_device_wdt, &s3c_device_i2c0, &s3c_device_hsmmc1, -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710 +#ifdef CONFIG_SND_SOC_SAMSUNG_SMDK2443_WM9710 &s3c_device_ac97, #endif &s3c2443_device_dma, @@ -130,10 +130,6 @@ static void __init smdk2443_machine_init(void) { s3c_i2c0_set_platdata(NULL); -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710 - s3c24xx_ac97_setup_gpio(S3C24XX_AC97_GPE0); -#endif - platform_add_devices(smdk2443_devices, ARRAY_SIZE(smdk2443_devices)); smdk_machine_init(); }