diff mbox

[04/10] irqchip: versatile-fpga: add DT init

Message ID 1400620176-7239-5-git-send-email-robherring2@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rob Herring May 20, 2014, 9:09 p.m. UTC 
From: Rob Herring <robh@kernel.org>

Add IRQCHIP_DECLARE call for the versatile-fpga interrupt controller so
that initialization from DT will work.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
---
 drivers/irqchip/irq-versatile-fpga.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Linus Walleij May 23, 2014, 12:58 p.m. UTC | #1 
On Tue, May 20, 2014 at 11:09 PM, Rob Herring <robherring2@gmail.com> wrote:

> From: Rob Herring <robh@kernel.org>
>
> Add IRQCHIP_DECLARE call for the versatile-fpga interrupt controller so
> that initialization from DT will work.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>

If the different compatible string indicated that the hardware
is different that string must be used to augment the runpath,
right?

It seems to me that the special routing register will be used
whenever the DT has this special passthrough property set,
but that should be *refused* on all other variants, as that
regiser has a different meaning on the integrator (used for
FIQ).

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/irqchip/irq-versatile-fpga.c b/drivers/irqchip/irq-versatile-fpga.c
index 328440b..11ab10d 100644
--- a/drivers/irqchip/irq-versatile-fpga.c
+++ b/drivers/irqchip/irq-versatile-fpga.c
@@ -14,6 +14,8 @@ 
 #include <asm/exception.h>
 #include <asm/mach/irq.h>
 
+#include "irqchip.h"
+
 #define IRQ_STATUS		0x00
 #define IRQ_RAW_STATUS		0x04
 #define IRQ_ENABLE_SET		0x08
@@ -217,4 +219,5 @@  int __init fpga_irq_of_init(struct device_node *node,
 
 	return 0;
 }
+IRQCHIP_DECLARE(arm_fpga, "arm,versatile-sic", fpga_irq_of_init);
 #endif