diff mbox

[07/10] dt/bindings: arm-boards: add binding for Versatile core module

Message ID 1400620176-7239-8-git-send-email-robherring2@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rob Herring May 20, 2014, 9:09 p.m. UTC 
From: Rob Herring <robh@kernel.org>

Add binding for the core module found on ARM versatile AB and PB boards.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>
---
 Documentation/devicetree/bindings/arm/arm-boards | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Arnd Bergmann May 21, 2014, 8:24 a.m. UTC | #1 
On Tuesday 20 May 2014 16:09:33 Rob Herring wrote:
> diff --git a/Documentation/devicetree/bindings/arm/arm-boards b/Documentation/devicetree/bindings/arm/arm-boards
> index 3509707..3a950d9 100644
> --- a/Documentation/devicetree/bindings/arm/arm-boards
> +++ b/Documentation/devicetree/bindings/arm/arm-boards
> @@ -86,3 +86,9 @@ Interrupt controllers:
>         compatible = "arm,versatile-sic";
>         interrupt-controller;
>         #interrupt-cells = <1>;
> +
> +Required nodes:
> +
> +- core-module: the root node to the Versatile platforms must have
> +  a core-module with regs and the compatible string
> +  "arm,core-module-versatile"
> 


Should we mark this compatible="syscon" as well, so we can move
the accesses into syscon references later if we want to?

	ARnd
Rob Herring May 21, 2014, 3:34 p.m. UTC | #2 
On Wed, May 21, 2014 at 3:24 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 20 May 2014 16:09:33 Rob Herring wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/arm-boards b/Documentation/devicetree/bindings/arm/arm-boards
>> index 3509707..3a950d9 100644
>> --- a/Documentation/devicetree/bindings/arm/arm-boards
>> +++ b/Documentation/devicetree/bindings/arm/arm-boards
>> @@ -86,3 +86,9 @@ Interrupt controllers:
>>         compatible = "arm,versatile-sic";
>>         interrupt-controller;
>>         #interrupt-cells = <1>;
>> +
>> +Required nodes:
>> +
>> +- core-module: the root node to the Versatile platforms must have
>> +  a core-module with regs and the compatible string
>> +  "arm,core-module-versatile"
>>
>
>
> Should we mark this compatible="syscon" as well, so we can move
> the accesses into syscon references later if we want to?

Yes, probably so. That should be done on Integrator and Realview as
well if not already.

Rob
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/arm-boards b/Documentation/devicetree/bindings/arm/arm-boards
index 3509707..3a950d9 100644
--- a/Documentation/devicetree/bindings/arm/arm-boards
+++ b/Documentation/devicetree/bindings/arm/arm-boards
@@ -86,3 +86,9 @@  Interrupt controllers:
 	compatible = "arm,versatile-sic";
 	interrupt-controller;
 	#interrupt-cells = <1>;
+
+Required nodes:
+
+- core-module: the root node to the Versatile platforms must have
+  a core-module with regs and the compatible string
+  "arm,core-module-versatile"