| Message ID | 1400761997-13512-3-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, Thank you for the patch. On Thursday 22 May 2014 14:33:17 Geert Uytterhoeven wrote: > <dt-bindings/interrupt-controller/irq.h> is already included by > r8a7779.dtsi. Isn't it better, like with C code, to explicitly include headers that provide the macros you need, instead of relying on implicit #include's that could change later ? OK, in this specific case, it's very unlikely that r8a7779.dtsi would stop including <dt-bindings/interrupt-controller/irq.h>, but in the general case I believe explicit includes to be good practice. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/arm/boot/dts/r8a7779-marzen.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts > b/arch/arm/boot/dts/r8a7779-marzen.dts index 321290828eee..649129906d6f > 100644 > --- a/arch/arm/boot/dts/r8a7779-marzen.dts > +++ b/arch/arm/boot/dts/r8a7779-marzen.dts > @@ -12,7 +12,6 @@ > /dts-v1/; > #include "r8a7779.dtsi" > #include <dt-bindings/gpio/gpio.h> > -#include <dt-bindings/interrupt-controller/irq.h> > > / { > model = "marzen";
On Thu, May 22, 2014 at 2:50 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thursday 22 May 2014 14:33:17 Geert Uytterhoeven wrote: >> <dt-bindings/interrupt-controller/irq.h> is already included by >> r8a7779.dtsi. > > Isn't it better, like with C code, to explicitly include headers that provide > the macros you need, instead of relying on implicit #include's that could > change later ? OK, in this specific case, it's very unlikely that r8a7779.dtsi > would stop including <dt-bindings/interrupt-controller/irq.h>, but in the > general case I believe explicit includes to be good practice. You're right. I was a bit overzealous. Simon, please drop this. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, May 22, 2014 at 02:58:57PM +0200, Geert Uytterhoeven wrote: > On Thu, May 22, 2014 at 2:50 PM, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > On Thursday 22 May 2014 14:33:17 Geert Uytterhoeven wrote: > >> <dt-bindings/interrupt-controller/irq.h> is already included by > >> r8a7779.dtsi. > > > > Isn't it better, like with C code, to explicitly include headers that provide > > the macros you need, instead of relying on implicit #include's that could > > change later ? OK, in this specific case, it's very unlikely that r8a7779.dtsi > > would stop including <dt-bindings/interrupt-controller/irq.h>, but in the > > general case I believe explicit includes to be good practice. > > You're right. I was a bit overzealous. > > Simon, please drop this. Done.
diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts b/arch/arm/boot/dts/r8a7779-marzen.dts index 321290828eee..649129906d6f 100644 --- a/arch/arm/boot/dts/r8a7779-marzen.dts +++ b/arch/arm/boot/dts/r8a7779-marzen.dts @@ -12,7 +12,6 @@ /dts-v1/; #include "r8a7779.dtsi" #include <dt-bindings/gpio/gpio.h> -#include <dt-bindings/interrupt-controller/irq.h> / { model = "marzen";
<dt-bindings/interrupt-controller/irq.h> is already included by r8a7779.dtsi. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/boot/dts/r8a7779-marzen.dts | 1 - 1 file changed, 1 deletion(-)