Message ID | 1400763964-19369-1-git-send-email-s.trumtrar@pengutronix.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Steffen, On 5/22/14 8:06 AM, Steffen Trumtrar wrote: > The SoCFPGA has two watchdog timers. Add them to the dtsi. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index 56fc214..7bcd458 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -549,6 +549,22 @@ > reg = <0xffd05000 0x1000>; > }; > > + watchdog0: watchdog@ffd02000 { > + compatible = "snps,dw-wdt"; > + reg = <0xffd02000 0x1000>; > + interrupts = <0 171 0>; This should be IRQ_TYPE_LEVEL_HIGH. > + clocks = <&osc1>; > + status = "disabled"; > + }; > + > + watchdog1: watchdog@ffd03000 { > + compatible = "snps,dw-wdt"; > + reg = <0xffd03000 0x1000>; > + interrupts = <0 172 0>; Same here.. > + clocks = <&osc1>; > + status = "disabled"; > + }; > + > sysmgr: sysmgr@ffd08000 { > compatible = "altr,sys-mgr", "syscon"; > reg = <0xffd08000 0x4000>; No need to resend a patch, I'll apply with those changes. Dinh
Hi Dinh! On Thu, May 22, 2014 at 09:35:19AM -0500, Dinh Nguyen wrote: > Hi Steffen, > > On 5/22/14 8:06 AM, Steffen Trumtrar wrote: > > The SoCFPGA has two watchdog timers. Add them to the dtsi. > > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > --- > > arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > > index 56fc214..7bcd458 100644 > > --- a/arch/arm/boot/dts/socfpga.dtsi > > +++ b/arch/arm/boot/dts/socfpga.dtsi > > @@ -549,6 +549,22 @@ > > reg = <0xffd05000 0x1000>; > > }; > > > > + watchdog0: watchdog@ffd02000 { > > + compatible = "snps,dw-wdt"; > > + reg = <0xffd02000 0x1000>; > > + interrupts = <0 171 0>; > This should be IRQ_TYPE_LEVEL_HIGH. > > + clocks = <&osc1>; > > + status = "disabled"; > > + }; > > + > > + watchdog1: watchdog@ffd03000 { > > + compatible = "snps,dw-wdt"; > > + reg = <0xffd03000 0x1000>; > > + interrupts = <0 172 0>; > Same here.. > > + clocks = <&osc1>; > > + status = "disabled"; > > + }; > > + > > sysmgr: sysmgr@ffd08000 { > > compatible = "altr,sys-mgr", "syscon"; > > reg = <0xffd08000 0x4000>; I wasn't aware that we started using the IRQ defines, but... > No need to resend a patch, I'll apply with those changes. > ...great. Thanks. Steffen
On 5/22/14 9:39 AM, Steffen Trumtrar wrote: > Hi Dinh! > > On Thu, May 22, 2014 at 09:35:19AM -0500, Dinh Nguyen wrote: >> Hi Steffen, >> >> On 5/22/14 8:06 AM, Steffen Trumtrar wrote: >>> The SoCFPGA has two watchdog timers. Add them to the dtsi. >>> >>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >>> --- >>> arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi >>> index 56fc214..7bcd458 100644 >>> --- a/arch/arm/boot/dts/socfpga.dtsi >>> +++ b/arch/arm/boot/dts/socfpga.dtsi >>> @@ -549,6 +549,22 @@ >>> reg = <0xffd05000 0x1000>; >>> }; >>> >>> + watchdog0: watchdog@ffd02000 { >>> + compatible = "snps,dw-wdt"; >>> + reg = <0xffd02000 0x1000>; >>> + interrupts = <0 171 0>; >> This should be IRQ_TYPE_LEVEL_HIGH. >>> + clocks = <&osc1>; >>> + status = "disabled"; >>> + }; >>> + >>> + watchdog1: watchdog@ffd03000 { >>> + compatible = "snps,dw-wdt"; >>> + reg = <0xffd03000 0x1000>; >>> + interrupts = <0 172 0>; >> Same here.. >>> + clocks = <&osc1>; >>> + status = "disabled"; >>> + }; >>> + >>> sysmgr: sysmgr@ffd08000 { >>> compatible = "altr,sys-mgr", "syscon"; >>> reg = <0xffd08000 0x4000>; > I wasn't aware that we started using the IRQ defines, but... You added the support to be able to do that ;). But what I really meant was you had the IRQ type set to 0(IRQ_TYPE_NONE), but it should be 4. Dinh > >> No need to resend a patch, I'll apply with those changes. >> > ...great. Thanks. > > Steffen >
diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index 56fc214..7bcd458 100644 --- a/arch/arm/boot/dts/socfpga.dtsi +++ b/arch/arm/boot/dts/socfpga.dtsi @@ -549,6 +549,22 @@ reg = <0xffd05000 0x1000>; }; + watchdog0: watchdog@ffd02000 { + compatible = "snps,dw-wdt"; + reg = <0xffd02000 0x1000>; + interrupts = <0 171 0>; + clocks = <&osc1>; + status = "disabled"; + }; + + watchdog1: watchdog@ffd03000 { + compatible = "snps,dw-wdt"; + reg = <0xffd03000 0x1000>; + interrupts = <0 172 0>; + clocks = <&osc1>; + status = "disabled"; + }; + sysmgr: sysmgr@ffd08000 { compatible = "altr,sys-mgr", "syscon"; reg = <0xffd08000 0x4000>;
The SoCFPGA has two watchdog timers. Add them to the dtsi. Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)