From patchwork Sun May 25 08:54:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 4238271 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CEE00BF90B for ; Sun, 25 May 2014 08:58:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0C3F220225 for ; Sun, 25 May 2014 08:58:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DCF320222 for ; Sun, 25 May 2014 08:58:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WoUDA-0002I5-Fb; Sun, 25 May 2014 08:55:20 +0000 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WoUD3-0001Es-Dm for linux-arm-kernel@lists.infradead.org; Sun, 25 May 2014 08:55:18 +0000 Received: by mail-pa0-f44.google.com with SMTP id ld10so6118298pab.31 for ; Sun, 25 May 2014 01:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=AKD1ADz0G/U3d/XnHOPvWveVvKWO+zYbgrdgjRfyY/4=; b=V7esV029F6lPD+w7dLFAyauJ4FsL9H6H4GcWOZVwpYOxKGUJOlV1MUujyfScOXBwHC pGaG+tO+/dbn7MWTjEslkMzKdw/CP4JUCsUGBsjobhIBTlw43J6iXLJHau3zs2nDgS0F IxH2nDd3J7ahho1mSBsB/eLEWAkkeXqQKNV3ss3M/yGgTGcK69aYJTphIuL3IVMbwyjr vb2R5S83IPszKQCD69cK58vju16046ya/LkY12JgUqVp7F9ISbQQv33iD7j69fPv6+ON QZ0x8wiCnvjk+GgEm2HiKfpSNBJKTibQe1jc9JfbP1n2k4ANMMXPqDVejuNzjAxHBS1u OVZw== X-Received: by 10.66.180.34 with SMTP id dl2mr19224969pac.124.1401008091074; Sun, 25 May 2014 01:54:51 -0700 (PDT) Received: from localhost.localdomain ([119.39.238.157]) by mx.google.com with ESMTPSA id vf9sm12634514pbc.94.2014.05.25.01.54.46 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 25 May 2014 01:54:50 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] pinctrl: sirf: fix typo for GPIO bank number Date: Sun, 25 May 2014 16:54:23 +0800 Message-Id: <1401008064-31819-1-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140525_015513_488666_2C608FA6 X-CRM114-Status: GOOD ( 13.41 ) X-Spam-Score: 2.5 (++) Cc: Dan Carpenter , workgroup.linux@csr.com, Barry Song X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_SBL, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Barry Song The patch 7420d2d09b12: "pinctrl: sirf: switch driver to use gpiolib irqchip helpers" from Apr 15, 2014, leads to the following static checker warning: drivers/pinctrl/sirf/pinctrl-sirf.c:578 sirfsoc_gpio_handle_irq() warn: buffer overflow 'sgpio_chip.sgpio_bank' 5 <= 31 Cc: Dan Carpenter Signed-off-by: Barry Song --- drivers/pinctrl/sirf/pinctrl-sirf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c b/drivers/pinctrl/sirf/pinctrl-sirf.c index c03dcc7..a4ea3f7 100644 --- a/drivers/pinctrl/sirf/pinctrl-sirf.c +++ b/drivers/pinctrl/sirf/pinctrl-sirf.c @@ -574,12 +574,12 @@ static void sirfsoc_gpio_handle_irq(unsigned int irq, struct irq_desc *desc) struct irq_chip *chip = irq_get_chip(irq); int i; - for (i = 0; i < SIRFSOC_GPIO_BANK_SIZE; i++) { + for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) { bank = &sgpio_chip.sgpio_bank[i]; if (bank->parent_irq == irq) break; } - BUG_ON (i == SIRFSOC_GPIO_BANK_SIZE); + BUG_ON(i == SIRFSOC_GPIO_NO_OF_BANKS); chained_irq_enter(chip, desc);