| Message ID | 1401116474-31221-1-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26/05/2014 17:01, Thomas Petazzoni wrote: > The armada_370_xp_pmsu_idle_prepare() function is only used internally > to pmsu.c, so there's no reason to not use the static qualifier. Indeed, it was exported in the 1st version of the series, and then I forgot to make it static later. Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > arch/arm/mach-mvebu/pmsu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > index 53a55c8..6e83d32 100644 > --- a/arch/arm/mach-mvebu/pmsu.c > +++ b/arch/arm/mach-mvebu/pmsu.c > @@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void) > } > > /* No locking is needed because we only access per-CPU registers */ > -void armada_370_xp_pmsu_idle_prepare(bool deepidle) > +static void armada_370_xp_pmsu_idle_prepare(bool deepidle) > { > unsigned int hw_cpu = cpu_logical_map(smp_processor_id()); > u32 reg; >
On Mon, May 26, 2014 at 05:01:14PM +0200, Thomas Petazzoni wrote: > The armada_370_xp_pmsu_idle_prepare() function is only used internally > to pmsu.c, so there's no reason to not use the static qualifier. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > arch/arm/mach-mvebu/pmsu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to mvebu/soc with Gregory's Ack. thx, Jason.
diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c index 53a55c8..6e83d32 100644 --- a/arch/arm/mach-mvebu/pmsu.c +++ b/arch/arm/mach-mvebu/pmsu.c @@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void) } /* No locking is needed because we only access per-CPU registers */ -void armada_370_xp_pmsu_idle_prepare(bool deepidle) +static void armada_370_xp_pmsu_idle_prepare(bool deepidle) { unsigned int hw_cpu = cpu_logical_map(smp_processor_id()); u32 reg;
The armada_370_xp_pmsu_idle_prepare() function is only used internally to pmsu.c, so there's no reason to not use the static qualifier. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/arm/mach-mvebu/pmsu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)