| Message ID | 1401826402-1079-1-git-send-email-galak@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: > WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in > reference from the variable msm_platform_driver to the function > .init.text:msm_serial_probe() > The variable msm_platform_driver references > the function __init msm_serial_probe() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere older or else? thanks, greg k-h
On Tue, Jun 3, 2014 at 1:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: >> WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in >> reference from the variable msm_platform_driver to the function >> .init.text:msm_serial_probe() >> The variable msm_platform_driver references >> the function __init msm_serial_probe() >> If the reference is valid then annotate the >> variable with __init* or __refdata (see linux/init.h) or name the variable: >> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere > older or else? Linus' next branch, it was merged through arm-soc. I didn't notice it in time to fix it before we sent to Linus. :( -Olof
On Tue, Jun 03, 2014 at 02:04:43PM -0700, Olof Johansson wrote: > On Tue, Jun 3, 2014 at 1:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: > >> WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in > >> reference from the variable msm_platform_driver to the function > >> .init.text:msm_serial_probe() > >> The variable msm_platform_driver references > >> the function __init msm_serial_probe() > >> If the reference is valid then annotate the > >> variable with __init* or __refdata (see linux/init.h) or name the variable: > >> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > > > Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere > > older or else? > > Linus' next branch, it was merged through arm-soc. I didn't notice it > in time to fix it before we sent to Linus. :( Ok, do you want to take this patch then? I don't mind taking it through my tree, but it will have to wait until after 3.16-rc1 is out. It's up to you. thanks, greg k-h
On Tue, Jun 3, 2014 at 2:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, Jun 03, 2014 at 02:04:43PM -0700, Olof Johansson wrote: >> On Tue, Jun 3, 2014 at 1:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: >> >> WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in >> >> reference from the variable msm_platform_driver to the function >> >> .init.text:msm_serial_probe() >> >> The variable msm_platform_driver references >> >> the function __init msm_serial_probe() >> >> If the reference is valid then annotate the >> >> variable with __init* or __refdata (see linux/init.h) or name the variable: >> >> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console >> > >> > Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere >> > older or else? >> >> Linus' next branch, it was merged through arm-soc. I didn't notice it >> in time to fix it before we sent to Linus. :( > > Ok, do you want to take this patch then? I don't mind taking it through > my tree, but it will have to wait until after 3.16-rc1 is out. It's up > to you. I've got a handful of fixes we're queueing for the second batch of merges, and I can add it to there. -Olof
On Jun 3, 2014, at 4:17 PM, Olof Johansson <olof@lixom.net> wrote: > On Tue, Jun 3, 2014 at 2:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> On Tue, Jun 03, 2014 at 02:04:43PM -0700, Olof Johansson wrote: >>> On Tue, Jun 3, 2014 at 1:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>>> On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: >>>>> WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in >>>>> reference from the variable msm_platform_driver to the function >>>>> .init.text:msm_serial_probe() >>>>> The variable msm_platform_driver references >>>>> the function __init msm_serial_probe() >>>>> If the reference is valid then annotate the >>>>> variable with __init* or __refdata (see linux/init.h) or name the variable: >>>>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console >>>> >>>> Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere >>>> older or else? >>> >>> Linus' next branch, it was merged through arm-soc. I didn't notice it >>> in time to fix it before we sent to Linus. :( >> >> Ok, do you want to take this patch then? I don't mind taking it through >> my tree, but it will have to wait until after 3.16-rc1 is out. It's up >> to you. > > I've got a handful of fixes we're queueing for the second batch of > merges, and I can add it to there. > > > -Olof Olof, Reminder to queue this up for fixes for 3.16 - k
On Tuesday 17 June 2014 14:53:44 Kumar Gala wrote: > > On Jun 3, 2014, at 4:17 PM, Olof Johansson <olof@lixom.net> wrote: > > > On Tue, Jun 3, 2014 at 2:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > >> On Tue, Jun 03, 2014 at 02:04:43PM -0700, Olof Johansson wrote: > >>> On Tue, Jun 3, 2014 at 1:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > >>>> On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: > >>>>> WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in > >>>>> reference from the variable msm_platform_driver to the function > >>>>> .init.text:msm_serial_probe() > >>>>> The variable msm_platform_driver references > >>>>> the function __init msm_serial_probe() > >>>>> If the reference is valid then annotate the > >>>>> variable with __init* or __refdata (see linux/init.h) or name the variable: > >>>>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > >>>> > >>>> Where is this mismatch showing up at? 3.15-rc8, 3.16-rc1? Somewhere > >>>> older or else? > >>> > >>> Linus' next branch, it was merged through arm-soc. I didn't notice it > >>> in time to fix it before we sent to Linus. :( > >> > >> Ok, do you want to take this patch then? I don't mind taking it through > >> my tree, but it will have to wait until after 3.16-rc1 is out. It's up > >> to you. > > > > I've got a handful of fixes we're queueing for the second batch of > > merges, and I can add it to there. > > > Reminder to queue this up for fixes for 3.16 I've applied it on top of the fixes branch now. I think I missed it when I picked up the other fixes as I was only looking for patches sent to arm@kernel.org. Thanks for the reminder! Arnd
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 778e376..24f3cdc 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -991,7 +991,7 @@ static const struct of_device_id msm_uartdm_table[] = { { } }; -static int __init msm_serial_probe(struct platform_device *pdev) +static int msm_serial_probe(struct platform_device *pdev) { struct msm_port *msm_port; struct resource *resource;
WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe() The variable msm_platform_driver references the function __init msm_serial_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Kumar Gala <galak@codeaurora.org> --- drivers/tty/serial/msm_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)