| Message ID | 1402035454-25676-1-git-send-email-george.cherian@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/06/2014 01:17 AM, George Cherian wrote: > AM437x EPOS evm use external clock for RMII interface. > Enable the same in DT. > > Signed-off-by: George Cherian <george.cherian@ti.com> > Reported-by: Nishanth Menon <nm@ti.com> > --- > arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts > index 19f1f7e..90098f9 100644 > --- a/arch/arm/boot/dts/am43x-epos-evm.dts > +++ b/arch/arm/boot/dts/am43x-epos-evm.dts > @@ -319,6 +319,10 @@ > phy-mode = "rmii"; > }; > > +&phy_sel { > + rmii-clock-ext; > +}; > + > &i2c0 { > status = "okay"; > pinctrl-names = "default"; > Where does this apply on? With linux-next next-20140506 tag, and this patch applied, I get the following error. LD kernel/trace/built-in.o LD kernel/built-in.o build fail, Error: Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path, 'phy_sel', not found FATAL ERROR: Syntax error parsing input tree make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [dtbs] Error 2 make: *** Waiting for unfinished jobs.... in the future, it is helpful if you can point out that this is a regression seen on next-20140603 and the patch needs to be applied on some specific branch. for the record: last working next tag: https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt first broken next tag: https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt
On 06/06/2014 01:53 AM, Nishanth Menon wrote: > On 06/06/2014 01:17 AM, George Cherian wrote: >> AM437x EPOS evm use external clock for RMII interface. >> Enable the same in DT. >> >> Signed-off-by: George Cherian <george.cherian@ti.com> >> Reported-by: Nishanth Menon <nm@ti.com> >> --- >> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts >> index 19f1f7e..90098f9 100644 >> --- a/arch/arm/boot/dts/am43x-epos-evm.dts >> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts >> @@ -319,6 +319,10 @@ >> phy-mode = "rmii"; >> }; >> >> +&phy_sel { >> + rmii-clock-ext; >> +}; >> + >> &i2c0 { >> status = "okay"; >> pinctrl-names = "default"; >> > Where does this apply on? > With linux-next next-20140506 tag, and this patch applied, I get the > following error. > > LD kernel/trace/built-in.o > LD kernel/built-in.o > build fail, Error: > Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path, > 'phy_sel', not found > FATAL ERROR: Syntax error parsing input tree > make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [dtbs] Error 2 > make: *** Waiting for unfinished jobs.... > > in the future, it is helpful if you can point out that this is a > regression seen on next-20140603 and the patch needs to be applied on > some specific branch. > > for the record: > last working next tag: > https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt > > first broken next tag: > https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt > > interestingly, i just re-tested today's tag without the patch (omap2plus_defconfig): http://slexy.org/raw/s205sRdFvy I wonder why the behavior change and what was being fixed here?
On 6/6/2014 12:23 PM, Nishanth Menon wrote: > On 06/06/2014 01:17 AM, George Cherian wrote: >> AM437x EPOS evm use external clock for RMII interface. >> Enable the same in DT. >> >> Signed-off-by: George Cherian <george.cherian@ti.com> >> Reported-by: Nishanth Menon <nm@ti.com> >> --- >> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts >> index 19f1f7e..90098f9 100644 >> --- a/arch/arm/boot/dts/am43x-epos-evm.dts >> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts >> @@ -319,6 +319,10 @@ >> phy-mode = "rmii"; >> }; >> >> +&phy_sel { >> + rmii-clock-ext; >> +}; >> + >> &i2c0 { >> status = "okay"; >> pinctrl-names = "default"; >> > Where does this apply on? > With linux-next next-20140506 tag, and this patch applied, I get the Is'nt next-20140506 a month old. I tried the patch on next-20140604. > following error. > > LD kernel/trace/built-in.o > LD kernel/built-in.o > build fail, Error: > Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path, > 'phy_sel', not found > FATAL ERROR: Syntax error parsing input tree > make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [dtbs] Error 2 > make: *** Waiting for unfinished jobs.... > > in the future, it is helpful if you can point out that this is a > regression seen on next-20140603 and the patch needs to be applied on > some specific branch. > > for the record: > last working next tag: > https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt > > first broken next tag: > https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt > >
On 6/6/2014 12:25 PM, Nishanth Menon wrote: > On 06/06/2014 01:53 AM, Nishanth Menon wrote: >> On 06/06/2014 01:17 AM, George Cherian wrote: >>> AM437x EPOS evm use external clock for RMII interface. >>> Enable the same in DT. >>> >>> Signed-off-by: George Cherian <george.cherian@ti.com> >>> Reported-by: Nishanth Menon <nm@ti.com> >>> --- >>> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts >>> index 19f1f7e..90098f9 100644 >>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts >>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts >>> @@ -319,6 +319,10 @@ >>> phy-mode = "rmii"; >>> }; >>> >>> +&phy_sel { >>> + rmii-clock-ext; >>> +}; >>> + >>> &i2c0 { >>> status = "okay"; >>> pinctrl-names = "default"; >>> >> Where does this apply on? >> With linux-next next-20140506 tag, and this patch applied, I get the >> following error. >> >> LD kernel/trace/built-in.o >> LD kernel/built-in.o >> build fail, Error: >> Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path, >> 'phy_sel', not found >> FATAL ERROR: Syntax error parsing input tree >> make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [dtbs] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> in the future, it is helpful if you can point out that this is a >> regression seen on next-20140603 and the patch needs to be applied on >> some specific branch. >> >> for the record: >> last working next tag: >> https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt >> >> first broken next tag: >> https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt >> >> > interestingly, i just re-tested today's tag without the patch > (omap2plus_defconfig): > http://slexy.org/raw/s205sRdFvy Lil old kernel from the above link. Linux version 3.15.0-rc4-next-20140506 (nmenon@kahuna) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #2 SMP Fri Jun 6 01:47:42 CDT 2014 > I wonder why the behavior change and what was being fixed here? This kernel should not have the dt entries for phy sel driver. Thats why it is working.
On 06/06/2014 04:52 AM, George Cherian wrote: > On 6/6/2014 12:23 PM, Nishanth Menon wrote: >> On 06/06/2014 01:17 AM, George Cherian wrote: >>> AM437x EPOS evm use external clock for RMII interface. >>> Enable the same in DT. >>> >>> Signed-off-by: George Cherian <george.cherian@ti.com> >>> Reported-by: Nishanth Menon <nm@ti.com> >>> --- >>> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts >>> index 19f1f7e..90098f9 100644 >>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts >>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts >>> @@ -319,6 +319,10 @@ >>> phy-mode = "rmii"; >>> }; >>> >>> +&phy_sel { >>> + rmii-clock-ext; >>> +}; >>> + >>> &i2c0 { >>> status = "okay"; >>> pinctrl-names = "default"; >>> >> Where does this apply on? >> With linux-next next-20140506 tag, and this patch applied, I get the > Is'nt next-20140506 a month old. Uggh.. yeah - 1AM+migraine is not a good combination to try to do testing. :( Apologies on the noise > I tried the patch on next-20140604. Tested on next-20140606 - applies clean, builds and works :) am43xx-epos: Boot PASS: http://slexy.org/raw/s2fT6zs45y Tested-by: Nishanth Menon <nm@ti.com>
* Nishanth Menon <nm@ti.com> [140606 08:30]: > On 06/06/2014 04:52 AM, George Cherian wrote: > > On 6/6/2014 12:23 PM, Nishanth Menon wrote: > >> On 06/06/2014 01:17 AM, George Cherian wrote: > >>> AM437x EPOS evm use external clock for RMII interface. > >>> Enable the same in DT. > >>> > >>> Signed-off-by: George Cherian <george.cherian@ti.com> > >>> Reported-by: Nishanth Menon <nm@ti.com> > >>> --- > >>> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts > >>> index 19f1f7e..90098f9 100644 > >>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts > >>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts > >>> @@ -319,6 +319,10 @@ > >>> phy-mode = "rmii"; > >>> }; > >>> > >>> +&phy_sel { > >>> + rmii-clock-ext; > >>> +}; > >>> + > >>> &i2c0 { > >>> status = "okay"; > >>> pinctrl-names = "default"; > >>> > >> Where does this apply on? > >> With linux-next next-20140506 tag, and this patch applied, I get the > > Is'nt next-20140506 a month old. > > Uggh.. yeah - 1AM+migraine is not a good combination to try to do > testing. :( Apologies on the noise > > > > I tried the patch on next-20140604. > > Tested on next-20140606 - applies clean, builds and works :) > > am43xx-epos: Boot PASS: http://slexy.org/raw/s2fT6zs45y > > Tested-by: Nishanth Menon <nm@ti.com> Applying into omap-for-v3.16/fixes thanks. Tony
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts index 19f1f7e..90098f9 100644 --- a/arch/arm/boot/dts/am43x-epos-evm.dts +++ b/arch/arm/boot/dts/am43x-epos-evm.dts @@ -319,6 +319,10 @@ phy-mode = "rmii"; }; +&phy_sel { + rmii-clock-ext; +}; + &i2c0 { status = "okay"; pinctrl-names = "default";
AM437x EPOS evm use external clock for RMII interface. Enable the same in DT. Signed-off-by: George Cherian <george.cherian@ti.com> Reported-by: Nishanth Menon <nm@ti.com> --- arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ 1 file changed, 4 insertions(+)